diff mbox

[1/2] kcmp: Make it to depend on CONFIG_KCMP

Message ID 20130219221548.GK5627@moon (mailing list archive)
State New, archived
Headers show

Commit Message

Cyrill Gorcunov Feb. 19, 2013, 10:15 p.m. UTC
On Wed, Feb 20, 2013 at 02:11:46AM +0400, Cyrill Gorcunov wrote:
> On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote:
> > > 
> > > I think this syscall is usefull even without c/r stuff.
> > > That's why I made it with separate config option.
> > 
> > hm, OK.
> > 
> > But the patch also permits CONFIG_CHECKPOINT_RESTORE=y, CONFIG_KCMP=n
> > which surely isn't something which CRIU wants to support?
> Hmm, yes from one pov this feature is useful for out-of-c/r user,
> from another pov -- we will have to ask users to turn on additional
> CONFIG entries (which i'm sure not set by default in wide range of distros).
> Thus it seems less paiful way is either make it obj-(CHECKPOINT_RESTORE)
> as you proposed, or obj-y by default. The last can't be undone, so I'll
> prepare the patch for obj-(CHECKPOINT_RESTORE) I think.

Here is update. Peter, does it look good for you too?
From: Cyrill Gorcunov <gorcunov@openvz.org>
Subject: kcmp: Make it to depend on CHECKPOINT_RESTORE

Since kcmp syscall has been implemented (initially on x86
architecture) a number of other archs wire it up as well:
xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking
into account those who uses <asm-generic/unistd.h> for syscall
numbers definitions).

But the Makefile, which turns kcmp.o generation on still
depends on former config-x86. Thus get rid of this
limitation and make kcmp.o depend on CHECKPOINT_RESTORE

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Andrey Vagin <avagin@openvz.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Glauber Costa <glommer@parallels.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Valdis.Kletnieks@vt.edu
Cc: Michal Marek <mmarek@suse.cz>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
 kernel/Makefile |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox


Index: linux-2.6.git/kernel/Makefile
--- linux-2.6.git.orig/kernel/Makefile
+++ linux-2.6.git/kernel/Makefile
@@ -25,9 +25,7 @@  endif
 obj-y += sched/
 obj-y += power/
-obj-$(CONFIG_X86) += kcmp.o
+obj-$(CHECKPOINT_RESTORE) += kcmp.o
 obj-$(CONFIG_FREEZER) += freezer.o
 obj-$(CONFIG_PROFILING) += profile.o
 obj-$(CONFIG_STACKTRACE) += stacktrace.o