From patchwork Tue Feb 19 22:15:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyrill Gorcunov X-Patchwork-Id: 2165341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 99919DF24C for ; Tue, 19 Feb 2013 22:19:03 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U7vTh-0001c0-OQ; Tue, 19 Feb 2013 22:15:57 +0000 Received: from mail-lb0-f178.google.com ([209.85.217.178]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U7vTc-0001an-JX for linux-arm-kernel@lists.infradead.org; Tue, 19 Feb 2013 22:15:53 +0000 Received: by mail-lb0-f178.google.com with SMTP id n1so5542736lba.9 for ; Tue, 19 Feb 2013 14:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=o56OrEsf6xUUmxvOMzjXlM1Iq0Lkk6MB3ErggfxGAR0=; b=CfTR0Pk+zubyhr9K7dapxTLtlUN1ibZP8Y8/UWlAkoeLkXqe7aQraFX31gQkSmCX63 ACVfSBK+YaO7PRkd8PS2mpz9Ks063v6aQ3UJzI91uD0K/8gEInLxH11gEwHP8lCZkEEk gU2bVp650czfBkYLbVlbO4fYo1fxz2y6LBmTXiBdUrq7iJW4tj4QLfLEatMzV+3masAX d8nZj/dEpSTq/oHPnVV2H+fwIa/wkbFlUAN7s51gQA65IXWi4sJ7hA74TJhVooyWxIdW GxaJGGn4pVewtvoFpIdBIa2lA+BX6lTDrehB9RPXQeK135gm2IJHHcv+RC7HkZQVo5IY q0aQ== X-Received: by 10.152.48.113 with SMTP id k17mr15681124lan.29.1361312150146; Tue, 19 Feb 2013 14:15:50 -0800 (PST) Received: from moon.localdomain ([188.134.39.131]) by mx.google.com with ESMTPS id tm10sm37890185lab.10.2013.02.19.14.15.48 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 19 Feb 2013 14:15:49 -0800 (PST) Received: by moon.localdomain (Postfix, from userid 1000) id 2C922840213; Wed, 20 Feb 2013 02:15:48 +0400 (MSK) Date: Wed, 20 Feb 2013 02:15:48 +0400 From: Cyrill Gorcunov To: Andrew Morton Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP Message-ID: <20130219221548.GK5627@moon> References: <20130219064800.719149796@openvz.org> <20130219065210.030802820@openvz.org> <5123444D.6000806@suse.cz> <20130219093154.GF20312@moon> <5123BC2B.6000304@zytor.com> <20130219182838.GL20312@moon> <20130219134256.f4cedf44.akpm@linux-foundation.org> <20130219215432.GP20312@moon> <20130219140035.373ce4d2.akpm@linux-foundation.org> <20130219221146.GR20312@moon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130219221146.GR20312@moon> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130219_171552_802200_BA5073A1 X-CRM114-Status: GOOD ( 23.96 ) X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.178 listed in list.dnswl.org] 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gorcunov[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Michal Marek , Andrey Vagin , Eric Dumazet , xemul@parallels.com, Alexey Dobriyan , Frederic Weisbecker , Vasiliy Kulikov , linux-kernel@vger.kernel.org, Glauber Costa , Pekka Enberg , Andi Kleen , ebiederm@xmission.com, "H. Peter Anvin" , Tejun Heo , KOSAKI Motohiro , Ingo Molnar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Matt Helsley X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Wed, Feb 20, 2013 at 02:11:46AM +0400, Cyrill Gorcunov wrote: > On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: > > > > > > I think this syscall is usefull even without c/r stuff. > > > That's why I made it with separate config option. > > > > hm, OK. > > > > But the patch also permits CONFIG_CHECKPOINT_RESTORE=y, CONFIG_KCMP=n > > which surely isn't something which CRIU wants to support? > > Hmm, yes from one pov this feature is useful for out-of-c/r user, > from another pov -- we will have to ask users to turn on additional > CONFIG entries (which i'm sure not set by default in wide range of distros). > Thus it seems less paiful way is either make it obj-(CHECKPOINT_RESTORE) > as you proposed, or obj-y by default. The last can't be undone, so I'll > prepare the patch for obj-(CHECKPOINT_RESTORE) I think. Here is update. Peter, does it look good for you too? --- From: Cyrill Gorcunov Subject: kcmp: Make it to depend on CHECKPOINT_RESTORE Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses for syscall numbers definitions). But the Makefile, which turns kcmp.o generation on still depends on former config-x86. Thus get rid of this limitation and make kcmp.o depend on CHECKPOINT_RESTORE option. Signed-off-by: Cyrill Gorcunov Cc: KOSAKI Motohiro Cc: "Eric W. Biederman" Cc: Pavel Emelyanov Cc: Andrey Vagin Cc: Ingo Molnar Cc: H. Peter Anvin Cc: Thomas Gleixner Cc: Glauber Costa Cc: Andi Kleen Cc: Tejun Heo Cc: Matt Helsley Cc: Pekka Enberg Cc: Eric Dumazet Cc: Vasiliy Kulikov Cc: Alexey Dobriyan Cc: Valdis.Kletnieks@vt.edu Cc: Michal Marek Cc: Frederic Weisbecker Cc: Andrew Morton --- kernel/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: linux-2.6.git/kernel/Makefile =================================================================== --- linux-2.6.git.orig/kernel/Makefile +++ linux-2.6.git/kernel/Makefile @@ -25,9 +25,7 @@ endif obj-y += sched/ obj-y += power/ -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y) -obj-$(CONFIG_X86) += kcmp.o -endif +obj-$(CHECKPOINT_RESTORE) += kcmp.o obj-$(CONFIG_FREEZER) += freezer.o obj-$(CONFIG_PROFILING) += profile.o obj-$(CONFIG_STACKTRACE) += stacktrace.o