From patchwork Wed Feb 27 16:29:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffen Trumtrar X-Patchwork-Id: 2194021 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 30577DF2F2 for ; Wed, 27 Feb 2013 16:32:51 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UAjsu-0003hV-1D; Wed, 27 Feb 2013 16:29:36 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UAjsp-0003h6-SV for linux-arm-kernel@lists.infradead.org; Wed, 27 Feb 2013 16:29:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1UAjsi-0005ex-0G; Wed, 27 Feb 2013 17:29:24 +0100 Received: from str by ptx.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1UAjsf-0006K7-G8; Wed, 27 Feb 2013 17:29:21 +0100 Date: Wed, 27 Feb 2013 17:29:21 +0100 From: Steffen Trumtrar To: Marc Kleine-Budde Subject: Re: [PATCH] otg-for-v3.9-v1: USB otg: fix usage of try_module_get() and module_put() Message-ID: <20130227162921.GB10491@pengutronix.de> References: <1361974273-17087-1-git-send-email-mkl@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1361974273-17087-1-git-send-email-mkl@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:27:33 up 180 days, 1:02, 15 users, load average: 0.01, 0.10, 0.18 User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: str@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130227_112932_328983_7F86C36D X-CRM114-Status: GOOD ( 21.08 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: alexander.shishkin@linux.intel.com, linux-usb@vger.kernel.org, matthieu.castet@parrot.com, kishon@ti.com, peter.chen@freescale.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Wed, Feb 27, 2013 at 03:11:12PM +0100, Marc Kleine-Budde wrote: > Hello, > > this patch is intended for v3.9 and applies to Greg's usb/master tree. If fixes > the use of try_module_get() and module_put() in all usb_get_phy functions. > > regards, > Marc > > > The following changes since commit 74e1a2a39355b2d3ae8c60c78d8add162c6d7183: > > Merge tag 'usb-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb (2013-02-21 12:20:00 -0800) > > are available in the git repository at: > > > git://git.pengutronix.de/git/mkl/linux.git tags/otg-for-v3.9-v1 > > for you to fetch changes up to 6bef020b4aebd7886281fb7fb37c788d5a365eea: > > USB otg: use try_module_get in all usb_get_phy functions and add missing module_put (2013-02-27 12:53:15 +0100) > > ---------------------------------------------------------------- > USB otg: add missing try_module_get and module_put > > Add try_module_get() to usb_get_phy() and usb_get_phy_dev(). Further the > missing module_put() is added to usb_put_phy() > > ---------------------------------------------------------------- > Marc Kleine-Budde (1): > USB otg: use try_module_get in all usb_get_phy functions and add missing module_put > > drivers/usb/otg/otg.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > Hi, with this series plus otg-for-v3.10-v1: separate phy code and add DT helper chipidea-for-v3.10-v1 : USB chipidea: make use of DT helpers in chipidea driver improve driver v9: Add tested id switch and vbus connect detect support for Chipidea and I have USB otg+host working on v3.8 on an i.MX28. So, Tested-by: Steffen Trumtrar Regards, Steffen diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 13b7053..1eeff3c 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -907,7 +907,8 @@ compatible = "fsl,imx28-usb", "fsl,imx27-usb"; reg = <0x80080000 0x10000>; interrupts = <93>; - clocks = <&clks 60>; + clocks = <&clks 60>, <&clks 60>, <&clks 60>; + clock-names = "ipg", "ahb", "per"; fsl,usbphy = <&usbphy0>; status = "disabled"; }; @@ -916,7 +917,8 @@ compatible = "fsl,imx28-usb", "fsl,imx27-usb"; reg = <0x80090000 0x10000>; interrupts = <92>; - clocks = <&clks 61>; + clocks = <&clks 61>, <&clks 61>, <&clks 61>; + clock-names = "ipg", "ahb", "per"; fsl,usbphy = <&usbphy1>; status = "disabled"; };