From patchwork Thu Mar 28 19:54:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olof Johansson X-Patchwork-Id: 2359301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 22536DF2A1 for ; Thu, 28 Mar 2013 19:57:52 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ULIuN-0003TV-Ur; Thu, 28 Mar 2013 19:54:47 +0000 Received: from mail-da0-x22c.google.com ([2607:f8b0:400e:c00::22c]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ULIuK-0003TB-IG for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2013 19:54:45 +0000 Received: by mail-da0-f44.google.com with SMTP id z20so4653923dae.31 for ; Thu, 28 Mar 2013 12:54:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=U7qvRZ22lLAFDfedG8+8UwYbqs8dKMbfv6unOfyTL7M=; b=L5rHX0+Q7SXxqIhJIsfnCA3FtiXAvVL4TBDn+VipJZGvMlxSXkl3EyMaqWzfhnHL84 r/7IVcUeyYg/CgDlHIG6OecXhjYfxszFGkL8S7NwMRIwX7Bj6h7vbLFvh9Nzl9bHohYq 1G18IS7AsmMcdUqibNf0E5GDLZHhJdz9eQjiwj4wg0aU/9LsLE6thnTZN/OK7OFdDpek r/Tfojs4LCS/cUvArAjpzIiDlXgmSM8UkLl/e7KHLsEPIrGkafPQcwJXtlNUrg6fnEMz H3LNqYcvB0VLB9xYQ1yebp7j4kEhC+yzYRaLtRqUAh25xBtrnmhL3ktjvLV7E9tnDZXa RECQ== X-Received: by 10.66.171.232 with SMTP id ax8mr658235pac.67.1364500480357; Thu, 28 Mar 2013 12:54:40 -0700 (PDT) Received: from localhost ([2001:470:1f05:1640:f9bf:e1a0:f345:4dbd]) by mx.google.com with ESMTPS id i10sm11390pbd.1.2013.03.28.12.54.30 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 28 Mar 2013 12:54:38 -0700 (PDT) Date: Thu, 28 Mar 2013 12:54:56 -0700 From: Olof Johansson To: Pavel Machek Subject: Re: 3.9-rc1 regression in arm dtb build Message-ID: <20130328195456.GA22527@quad.lixom.net> References: <20130306193332.GA6022@amd.pavel.ucw.cz> <5137C404.9060902@wwwdotorg.org> <20130307144506.GB7344@amd.pavel.ucw.cz> <5138FDAE.8060202@wwwdotorg.org> <20130311050546.GA21863@quad.lixom.net> <20130328092916.GA11187@amd.pavel.ucw.cz> <51545870.4010209@wwwdotorg.org> <20130328193323.GA25166@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130328193323.GA25166@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnDQQDOC0jgapdcb2+OAgMh3dxM8liQXvshzOFsGelES+dVquG0ae6o+P7161zk8u0nz/fd X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130328_155444_685974_94ADDA5C X-CRM114-Status: GOOD ( 20.30 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "Rafael J. Wysocki" , Russell King - ARM Linux , Arnd Bergmann , Stephen Warren , kernel list , Rob Herring , Grant Likely , Linus Torvalds , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Mar 28, 2013 at 08:33:23PM +0100, Pavel Machek wrote: > On Thu 2013-03-28 08:49:20, Stephen Warren wrote: > > On 03/28/2013 03:29 AM, Pavel Machek wrote: > > ... > > > There's change that makes it pretty much impossible to build dtbs > > > reliably between different kernel versions, because it leaves old dtbs > > > around, and they survive even make clean. > > > > One question here: Presumably the dtbs don't survive "make clean" if you > > run that right after building the dtbs, but only if you check out a new > > kernel version before running clean? Or is that not the case? > > That was the case I seen, yes. > > Have old kernel running, dtbs building. Apply a patch. It starts > behaving weird. You do make clean... but you still get old dtbs. > > (It would be nice if make socfpga_cyclone5.dtb would magically remove > all the dtbs from old location; make dtbs does that if I understand > stuff correctly). This takes care of the "make dtbs" case (or just "make" case), but not when you build a specific target. ARM: dts: remove stale dtb files from arch/arm/boot This will result in stale dtb files being removed from arch/arm/boot, which can cause confusion when someone goes from an older kernel version to a newer one without doing make clean on the old version (or git clean -f -d -x). Signed-off-by: Olof Johansson index 84aa2ca..b1127b8 100644 --- a/arch/arm/boot/Makefile +++ b/arch/arm/boot/Makefile @@ -115,4 +115,5 @@ i: $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \ $(obj)/Image System.map "$(INSTALL_PATH)" +clean-files := *.dtb subdir- := bootp compressed dts