From patchwork Tue Apr 23 18:55:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2479761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 3BAA33FCA5 for ; Tue, 23 Apr 2013 18:55:53 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiNV-0000w0-W2; Tue, 23 Apr 2013 18:55:46 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiNR-0000YU-NJ; Tue, 23 Apr 2013 18:55:41 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiNP-0000YA-5Y for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2013 18:55:39 +0000 Received: from klappe2.localnet (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0Lx4sD-1UbOK11JZx-016N38; Tue, 23 Apr 2013 20:55:36 +0200 From: Arnd Bergmann To: Chris Ball Subject: Re: [PATCH 12/21] mmc: sdhci-tegra: fix MODULE_DEVICE_TABLE Date: Tue, 23 Apr 2013 20:55:32 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; ) References: <1366734653-488286-1-git-send-email-arnd@arndb.de> <1366734653-488286-13-git-send-email-arnd@arndb.de> <87bo95tctk.fsf@octavius.laptop.org> In-Reply-To: <87bo95tctk.fsf@octavius.laptop.org> MIME-Version: 1.0 Message-Id: <201304232055.32715.arnd@arndb.de> X-Provags-ID: V02:K0:RsSHkUlttN70n3kqd6KDsyEOdGok+SYYSmO1NlfVTUr bNJjy9l6LWDvEcRAkiOBN8KEwvkIyMDCNfjgkD47uoq7FTIe/l 2E12IOh5YRu76Ow2viADVh6zmHFHBlNVqOPkN7Yyp44jJj0r/p 8SVRca5+wqNpydB/QsEa+yGJ1HrdXneYz4mw/DcshK0PxBlzmM 0w+fv89OEcV1jCqszfXHW2iw9K0bLNDPawOAGO5U0xiz0S+die g0uMwbISXyDcDupt0Vvi7qzUp4gTVdjNzkaB8H8DRDE/WaD52M ajOJRTSbhGUratKaL5faNubsHRSb1xf0UPMB33IkfaAJaZ3J2k bpE6QG9S0yMdGOar4Ng4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130423_145539_421760_CBB52909 X-CRM114-Status: GOOD ( 12.83 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Stephen Warren , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The symbol referenced in MODULE_DEVICE_TABLE must match the actual table, otherwise we get a build error like sdhci-tegra.c:206:34: error: '__mod_of_device_table' aliased to undefined symbol 'sdhci_dt_ids' Signed-off-by: Arnd Bergmann Cc: Stephen Warren Cc: Chris Ball --- On Tuesday 23 April 2013, Chris Ball wrote: > I was going to take this, but it doesn't apply to mmc-next or > linux-next, because the #endif in your first line of context isn't > present in those trees -- which tree is this based on? I based it on 3.9-rc8. > Sounds like it might make more sense for you to take this; if so: > Acked-by: Chris Ball This is the rebased version on linux-next. I think it's better if you take it, otherwise we just create a merge conflict for Linus. diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 45048d1..e0dba74 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -203,7 +203,7 @@ static const struct of_device_id sdhci_tegra_dt_match[] = { { .compatible = "nvidia,tegra20-sdhci", .data = &soc_data_tegra20 }, {} }; -MODULE_DEVICE_TABLE(of, sdhci_dt_ids); +MODULE_DEVICE_TABLE(of, sdhci_tegra_dt_match); static void sdhci_tegra_parse_dt(struct device *dev) {