| Message ID | 201304232107.22084.arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 23, 2013 at 09:07:21PM +0200, Arnd Bergmann wrote: > It makes no sense for a symbol to be both exported and marked __init, > because any users in modules would be calling this function after > it gets discarded. Further, this patch revolves a section mismatch > warning from usbhs_init_phys(), which is intentionally not marked > __init: > > WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from > the function usbhs_init_phys() to the function .init.text:usb_bind_phy() > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > --- > > v2: rebased on linux-next not needed, Greg already has a patch doing exactly this in usb-next.
On Tuesday 23 April 2013, Felipe Balbi wrote: > On Tue, Apr 23, 2013 at 09:07:21PM +0200, Arnd Bergmann wrote: > > It makes no sense for a symbol to be both exported and marked __init, > > because any users in modules would be calling this function after > > it gets discarded. Further, this patch revolves a section mismatch > > warning from usbhs_init_phys(), which is intentionally not marked > > __init: > > > > WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from > > the function usbhs_init_phys() to the function .init.text:usb_bind_phy() > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Alan Stern <stern@rowland.harvard.edu> > > Cc: Felipe Balbi <balbi@ti.com> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: linux-usb@vger.kernel.org > > --- > > > > v2: rebased on linux-next > > not needed, Greg already has a patch doing exactly this in usb-next. Right, I see it now. I had checked today's linux-next but not usb-next or any of the other trees for stuff that was just applied today. Arnd
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index f52c006..a9984c7 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -413,7 +413,7 @@ EXPORT_SYMBOL_GPL(usb_remove_phy); * * To be used by platform specific initialization code. */ -int __init usb_bind_phy(const char *dev_name, u8 index, +int usb_bind_phy(const char *dev_name, u8 index, const char *phy_dev_name) { struct usb_phy_bind *phy_bind;
It makes no sense for a symbol to be both exported and marked __init, because any users in modules would be calling this function after it gets discarded. Further, this patch revolves a section mismatch warning from usbhs_init_phys(), which is intentionally not marked __init: WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from the function usbhs_init_phys() to the function .init.text:usb_bind_phy() Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Felipe Balbi <balbi@ti.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org --- v2: rebased on linux-next