From patchwork Tue Apr 23 19:07:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2479881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 208543FD1A for ; Tue, 23 Apr 2013 19:07:43 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiYy-0007qd-HJ; Tue, 23 Apr 2013 19:07:36 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiYu-0000pM-7R; Tue, 23 Apr 2013 19:07:32 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUiYs-0000p5-8U for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2013 19:07:30 +0000 Received: from klappe2.localnet (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0MEWCH-1UK0730AP3-00FWn0; Tue, 23 Apr 2013 21:07:24 +0200 From: Arnd Bergmann To: "Greg Kroah-Hartman" Subject: [PATCH v2] usb: phy: don't mark usb_bind_phy as __init Date: Tue, 23 Apr 2013 21:07:21 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; ) References: <1366734653-488286-1-git-send-email-arnd@arndb.de> <1366734653-488286-20-git-send-email-arnd@arndb.de> <20130423171734.GA31432@kroah.com> In-Reply-To: <20130423171734.GA31432@kroah.com> MIME-Version: 1.0 Message-Id: <201304232107.22084.arnd@arndb.de> X-Provags-ID: V02:K0:pY1yBMW/nogzeT+s67Hhz91ameukexp+ql26WM0qbjT ypVaipp2hLEn1BuiEMtzt80lwHVGEvX6mcCrKzg2ZH1ND+c/1u a7F05DppKuyyq+SooX1LXxiYDAZfp8pXaTT1rv2vUnfyPr20Yg xVSh1JF96zJlxdXkXFCvUZTVSSkGy+KQzSrC8GJa5Pvvi6Om6h htz9FDJ5Ka47AFbTbD3AWP5MKyPtmzhpP/pNX6JYgnyYihJNnZ d6K67Dtg0hgR9AHZcXISFk/F4nd1fkVGTX51ToX9SEy2VuyfGT IAZeyeHzhCTSVkZ69sypxLLYR6CzzCFr7XBMSyxbUBfetGsDyZ G11a3pLTZNZYUQuTXH/U= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130423_150730_501784_707DA764 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Felipe Balbi , linux-usb@vger.kernel.org, Alan Stern , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It makes no sense for a symbol to be both exported and marked __init, because any users in modules would be calling this function after it gets discarded. Further, this patch revolves a section mismatch warning from usbhs_init_phys(), which is intentionally not marked __init: WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from the function usbhs_init_phys() to the function .init.text:usb_bind_phy() Signed-off-by: Arnd Bergmann Cc: Alan Stern Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org --- v2: rebased on linux-next diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index f52c006..a9984c7 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -413,7 +413,7 @@ EXPORT_SYMBOL_GPL(usb_remove_phy); * * To be used by platform specific initialization code. */ -int __init usb_bind_phy(const char *dev_name, u8 index, +int usb_bind_phy(const char *dev_name, u8 index, const char *phy_dev_name) { struct usb_phy_bind *phy_bind;