From patchwork Tue Apr 30 11:43:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot for Dave Martin X-Patchwork-Id: 2504251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 8F3DB3FD40 for ; Tue, 30 Apr 2013 11:44:28 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UX8yc-0000zj-94; Tue, 30 Apr 2013 11:44:06 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UX8yL-0007q3-2K; Tue, 30 Apr 2013 11:43:49 +0000 Received: from mail-ee0-f53.google.com ([74.125.83.53]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UX8yI-0007p8-2H for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2013 11:43:46 +0000 Received: by mail-ee0-f53.google.com with SMTP id d17so207173eek.40 for ; Tue, 30 Apr 2013 04:43:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=3P6eeeVMwKN5QT0SZ0MRsy7xpLrfmBpwkS4JIauKvoE=; b=TxI1Q/RN+HI55ihHh5EFByElz4YatbHNSJ7pyYwyO+ghk0mb87I+Tja1LXdFNCb/CO 6dxt4+8o4YjDAF+qkuXqj4s6LLSdlaadSuhxXgyrftrZLI0A8n0D5dCFx/38gdszk1kS /IlH6W+/P1Osa3XSc2ofH++U4wEhCgoBJJLa0DZAJsyRWycB3kMVQ7HKKHuISmrG3fba U8VQ4lTALZJZj/vzo2tq1CsbIL2sGvW87IfuVylSSXljtRFZBX0Dc02AxcQ/Qb8DmMc+ ECzR79k2IE7UvZtU0qnNLx5XvuohAtDrWupi3AZgbvmCUuDdCf6FintP4H5tlaibtqHf Lxtw== X-Received: by 10.14.105.1 with SMTP id j1mr89201410eeg.6.1367322202413; Tue, 30 Apr 2013 04:43:22 -0700 (PDT) Received: from linaro.org (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id ch6sm38203517eeb.17.2013.04.30.04.43.19 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 30 Apr 2013 04:43:21 -0700 (PDT) Date: Tue, 30 Apr 2013 12:43:11 +0100 From: Dave Martin To: Arnd Bergmann Subject: Re: Latest build results - errors/warnings - lots of them Message-ID: <20130430114229.GA2439@linaro.org> References: <20130430081739.GP14496@n2100.arm.linux.org.uk> <201304301304.20650.arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201304301304.20650.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlBbCPliNAh375E3W2CpMc7QgFKIIGu//p2hQvWbVa8298gjxBE0JsNh20soJ0CVOreD+u1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130430_074346_231815_50015EBB X-CRM114-Status: GOOD ( 22.94 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.83.53 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King - ARM Linux , Nicolas Pitre , Tony Lindgren , Catalin Marinas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Tue, Apr 30, 2013 at 01:04:20PM +0200, Arnd Bergmann wrote: > On Tuesday 30 April 2013, Russell King - ARM Linux wrote: > > Latest nightly build of 3.9+my for-next+arm-soc's for-next results in a > > great load of new warnings and errors. arch/arm/common/mcpm_head.S, > > arch/arm/common/mcpm_platsmp.c, arch/arm/common/vlock.S are the biggest > > source of errors. [...] > >arch/arm/common/mcpm_head.S:39: Error: selected processor does not support ARM mode `ubfx r9,r0,#0,#8' > >arch/arm/common/mcpm_head.S:40: Error: selected processor does not support ARM mode `ubfx r10,r0,#8,#8' > >arch/arm/common/mcpm_head.S:100: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:115: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:127: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:131: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:138: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/mcpm_head.S:152: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:161: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/mcpm_head.S:175: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:62: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:72: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/vlock.S:89: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:95: Error: selected processor does not support ARM mode `dsb' > >arch/arm/common/vlock.S:102: Error: selected processor does not support ARM mode `dmb' > >arch/arm/common/vlock.S:105: Error: selected processor does not support ARM mode `dsb' > > Right, the problem here is that the code was never tested with an ARMv6+ARMv7 config. > We can either fix it up by adding > > .arch armv7-a > > in the assembly files, or by doing the same in the Makefile: > > AFLAGS_vlock.S += -march=armv7-a > AFLAGS_mcpm_head.S += -march=armv7-a Hmmm, this code was tested with ARCH_MULTIPLATFORM, but it looks like no v6 boards were configured in when testing that... Assuming people are OK with the Makefile route, here's a patch for that, build-tested with a v6+v7 ARCH_MULTIPLATFORM config. Cheers ---Dave From 193f254689beaa1612d29bcc5ba004a933b37d95 Mon Sep 17 00:00:00 2001 From: Dave Martin Date: Tue, 30 Apr 2013 12:25:04 +0100 Subject: [PATCH 1/3] ARM: mcpm: Add explicit AFLAGS to support v6/v7 multiplatform kernels The full mcpm layer is not likely to be relevant to v6 based platforms, so a multiplatform kernel won't use that code if booted on v6 hardware. This patch modifies the AFLAGS for affected mcpm .S files to specify armv7-a explicitly for that code. Signed-off-by: Dave Martin Acked-by: Arnd Bergmann Acked-by: Nicolas Pitre --- arch/arm/common/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/common/Makefile b/arch/arm/common/Makefile index 546a932..d65a0a8 100644 --- a/arch/arm/common/Makefile +++ b/arch/arm/common/Makefile @@ -12,6 +12,8 @@ obj-$(CONFIG_SHARP_SCOOP) += scoop.o obj-$(CONFIG_PCI_HOST_ITE8152) += it8152.o obj-$(CONFIG_ARM_TIMER_SP804) += timer-sp.o obj-$(CONFIG_MCPM) += mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o +AFLAGS_mcpm_head.o := -march=armv7-a +AFLAGS_vlock.o := -march=armv7-a CFLAGS_REMOVE_mcpm_entry.o = -pg obj-$(CONFIG_FIQ_GLUE) += fiq_glue.o fiq_glue_setup.o obj-$(CONFIG_FIQ_DEBUGGER) += fiq_debugger.o