From patchwork Thu May 2 18:03:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2513381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 69AAC3FD85 for ; Thu, 2 May 2013 18:04:41 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXxri-0004QP-R0; Thu, 02 May 2013 18:04:22 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXxrJ-0006tY-K4; Thu, 02 May 2013 18:03:57 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXxrG-0006ss-Um for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2013 18:03:55 +0000 Received: from klappe2.localnet (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0M2GKi-1UHOwH0NUa-00sL8a; Thu, 02 May 2013 20:03:29 +0200 From: Arnd Bergmann To: Eduardo Valentin Subject: Re: Latest build results - errors/warnings - lots of them Date: Thu, 2 May 2013 20:03:26 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; ) References: <20130430081739.GP14496@n2100.arm.linux.org.uk> <20130502153834.GR28721@atomide.com> <51829D65.7040109@ti.com> In-Reply-To: <51829D65.7040109@ti.com> MIME-Version: 1.0 Message-Id: <201305022003.27037.arnd@arndb.de> X-Provags-ID: V02:K0:0XiHRAvON8EQZ7KpX2nihSJHG1HXKRNMko9IgCCdzxO XM+7cY65Y78X6IUQQIAeul3zopld7Inf7jZqTq0j6RvWp8Srcy jGmSTFh3/sIQsynSA2bd0UzM9/iD4RWwDincAdekEPx+Oy5bMF +NFftrX0DUcQ9UsPUREYmEzRjJuqGUhTk0C9Kma1vSfWoXC6tM ag51sSW7w4/kt7lrPU4S6ei6YtM3cAvyxVc6La4bxlWzcfBE1c p7vpNzpZ1sywECs9FCqCHdpaODrqlbOdyOXCgpIx0GVvW44ryE 2B8EuAnw8Ua3BGmtDeThrjFr16Zx71sqxc8aCgnX4i6b6YhG+5 ik9GTRNf0Q0rPUdz4I70= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130502_140355_282508_213B30EB X-CRM114-Status: GOOD ( 13.85 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King - ARM Linux , Nicolas Pitre , Tony Lindgren , Neil Brown , Durgadoss R , "Zhang, Rui" , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thursday 02 May 2013, Eduardo Valentin wrote: > index e3c0ae9..e3f3cba 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -250,12 +250,6 @@ void thermal_unregister_governor(struct > thermal_governor *); > #ifdef CONFIG_NET > extern int thermal_generate_netlink_event(struct thermal_zone_device *tz, > enum events event); > -#else > -static int thermal_generate_netlink_event(struct thermal_zone_device *tz, > - enum events event) > -{ > - return 0; > -} > #endif Actually it seems this bug is already fixed in linux-next: commit f8b587055a793c7719f0d4f41b7b4aeeef43aa2d Author: Ezequiel Garcia Date: Wed Mar 20 21:38:07 2013 +0000 thermal: Fix compiler warning The following warning is obtained when CONFIG_NET is not defined: In file included from drivers/thermal/mvebu_thermal.c:27:0: include/linux/thermal.h:254:12: warning: 'thermal_generate_netlink_event' defined but not used [-Wunused-function] This patch fixes the warning by properly inlining thermal_generate_netlink_event(). Signed-off-by: Ezequiel Garcia Signed-off-by: Zhang Rui Your patch also seems correct, but it would conflict with Ezequiel's. The problem was apparently that you removed the 'inline' keyword in 8ab3e6a08a "thermal: Use thermal zone device id in netlink messages", I assume by accident, since defining a non-inline function in a header file is obviously wrong. Arnd diff --git a/include/linux/thermal.h b/include/linux/thermal.h index f0bd7f9..fd7b8f3 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -251,7 +251,7 @@ void thermal_unregister_governor(struct thermal_governor *); extern int thermal_generate_netlink_event(struct thermal_zone_device *tz, enum events event); #else -static int thermal_generate_netlink_event(struct thermal_zone_device *tz, +static inline int thermal_generate_netlink_event(struct thermal_zone_device *tz, enum events event) { return 0;