From patchwork Fri May 3 21:50:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 2519701 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id D23C73FCA5 for ; Fri, 3 May 2013 21:54:46 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYNuN-0004Ia-TI; Fri, 03 May 2013 21:52:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYNtm-0001A1-I0; Fri, 03 May 2013 21:52:14 +0000 Received: from galois.linutronix.de ([2001:470:1f0b:db:abcd:42:0:1]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UYNsx-00013O-TS for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2013 21:51:29 +0000 Received: from localhost ([127.0.0.1] helo=localhost6.localdomain6) by Galois.linutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1UYNsW-00070M-F9; Fri, 03 May 2013 23:50:56 +0200 Message-Id: <20130503214629.880345092@linutronix.de> User-Agent: quilt/0.48-1 Date: Fri, 03 May 2013 21:50:55 -0000 From: Thomas Gleixner To: LKML Subject: [RFC patch 8/8] irqchip: sun4i: Convert to generic irq chip References: <20130503212258.385818955@linutronix.de> Content-Disposition: inline; filename=irqchip-convert-sun4i.patch X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130503_175124_582418_E4FF773E X-CRM114-Status: GOOD ( 16.51 ) X-Spam-Score: -4.5 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Thomas Petazzoni , Andrew Lunn , Russell King - ARM Linux , Jason Cooper , Arnd Bergmann , Jean-Francois Moine , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, Rob Herring , Jason Gunthorpe , Gregory Clement , Gerlando Falauto , Rob Landley , Grant Likely , Maxime Ripard , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Proof of concept patch to demonstrate the new irqdomain support for the generic irq chip. Untested !! Signed-off-by: Thomas Gleixner Cc: Maxime Ripard --- drivers/irqchip/irq-sun4i.c | 100 ++++++++++++-------------------------------- 1 file changed, 29 insertions(+), 71 deletions(-) Index: linux-2.6/drivers/irqchip/irq-sun4i.c =================================================================== --- linux-2.6.orig/drivers/irqchip/irq-sun4i.c +++ linux-2.6/drivers/irqchip/irq-sun4i.c @@ -32,70 +32,43 @@ #define SUN4I_IRQ_FIQ_PENDING_REG(x) (0x20 + 0x4 * x) #define SUN4I_IRQ_ENABLE_REG(x) (0x40 + 0x4 * x) #define SUN4I_IRQ_MASK_REG(x) (0x50 + 0x4 * x) +#define SUN4I_NUM_CHIPS 3 +#define SUN4I_IRQS_PER_CHIP 32 static void __iomem *sun4i_irq_base; static struct irq_domain *sun4i_irq_domain; static asmlinkage void __exception_irq_entry sun4i_handle_irq(struct pt_regs *regs); -void sun4i_irq_ack(struct irq_data *irqd) +static int __init sun4i_init_domain_chips(void) { - unsigned int irq = irqd_to_hwirq(irqd); - unsigned int irq_off = irq % 32; - int reg = irq / 32; - u32 val; - - val = readl(sun4i_irq_base + SUN4I_IRQ_PENDING_REG(reg)); - writel(val | (1 << irq_off), - sun4i_irq_base + SUN4I_IRQ_PENDING_REG(reg)); -} - -static void sun4i_irq_mask(struct irq_data *irqd) -{ - unsigned int irq = irqd_to_hwirq(irqd); - unsigned int irq_off = irq % 32; - int reg = irq / 32; - u32 val; - - val = readl(sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(reg)); - writel(val & ~(1 << irq_off), - sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(reg)); -} - -static void sun4i_irq_unmask(struct irq_data *irqd) -{ - unsigned int irq = irqd_to_hwirq(irqd); - unsigned int irq_off = irq % 32; - int reg = irq / 32; - u32 val; - - val = readl(sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(reg)); - writel(val | (1 << irq_off), - sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(reg)); -} - -static struct irq_chip sun4i_irq_chip = { - .name = "sun4i_irq", - .irq_ack = sun4i_irq_ack, - .irq_mask = sun4i_irq_mask, - .irq_unmask = sun4i_irq_unmask, -}; - -static int sun4i_irq_map(struct irq_domain *d, unsigned int virq, - irq_hw_number_t hw) -{ - irq_set_chip_and_handler(virq, &sun4i_irq_chip, - handle_level_irq); - set_irq_flags(virq, IRQF_VALID | IRQF_PROBE); - + unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; + struct irq_chip_generic *gc; + int i, ret, base = 0; + + ret = irq_alloc_domain_generic_chips(d, SUN4I_IRQS_PER_CHIP, 1, + "sun4i_irq", handle_level_irq, + clr, 0, IRQ_GC_INIT_MASK_CACHE); + if (ret) + return ret; + + for (i = 0; i < SUN4I_NUM_CHIPS; i++, base += SUN4I_IRQS_PER_CHIP) { + gc = irq_get_domain_generic_chip(sun4i_irq_domain, base); + gc->reg_base = sun4i_irq_base; + gc->chip_types[0].regs.mask = SUN4I_IRQ_ENABLE_REG(i); + gc->chip_types[0].regs.ack = SUN4I_IRQ_PENDING_REG(i); + gc->chip_types[0].chip.mask = irq_gc_mask_clr_bit; + gc->chip_types[0].chip.ack = irq_gc_ack_set_bit; + gc->chip_types[0].chip.unmask = irq_gc_mask_set_bit; + + /* Disable, mask and clear all pending interrupts */ + writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(i)); + writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(i)); + writel(0xffffffff, sun4i_irq_base + SUN4I_IRQ_PENDING_REG(i)); + } return 0; } -static struct irq_domain_ops sun4i_irq_ops = { - .map = sun4i_irq_map, - .xlate = irq_domain_xlate_onecell, -}; - static int __init sun4i_of_init(struct device_node *node, struct device_node *parent) { @@ -104,21 +77,6 @@ static int __init sun4i_of_init(struct d panic("%s: unable to map IC registers\n", node->full_name); - /* Disable all interrupts */ - writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(0)); - writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(1)); - writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(2)); - - /* Mask all the interrupts */ - writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(0)); - writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(1)); - writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(2)); - - /* Clear all the pending interrupts */ - writel(0xffffffff, sun4i_irq_base + SUN4I_IRQ_PENDING_REG(0)); - writel(0xffffffff, sun4i_irq_base + SUN4I_IRQ_PENDING_REG(1)); - writel(0xffffffff, sun4i_irq_base + SUN4I_IRQ_PENDING_REG(2)); - /* Enable protection mode */ writel(0x01, sun4i_irq_base + SUN4I_IRQ_PROTECTION_REG); @@ -126,8 +84,8 @@ static int __init sun4i_of_init(struct d writel(0x00, sun4i_irq_base + SUN4I_IRQ_NMI_CTRL_REG); sun4i_irq_domain = irq_domain_add_linear(node, 3 * 32, - &sun4i_irq_ops, NULL); - if (!sun4i_irq_domain) + &irq_generic_chip_ops, NULL); + if (!sun4i_irq_domain || sun4i_init_domain_chips()) panic("%s: unable to create IRQ domain\n", node->full_name); set_handle_irq(sun4i_handle_irq);