From patchwork Tue May 14 16:20:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jamie Iles X-Patchwork-Id: 2567461 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id C53B2DF24C for ; Tue, 14 May 2013 16:24:41 +0000 (UTC) Received: from merlin.infradead.org ([205.233.59.134]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcI0N-0008DA-NY; Tue, 14 May 2013 16:23:15 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcHyZ-0003JN-IH; Tue, 14 May 2013 16:21:19 +0000 Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UcHyW-0003Hc-Pr for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2013 16:21:17 +0000 Received: by mail-ea0-f171.google.com with SMTP id b15so464115eae.2 for ; Tue, 14 May 2013 09:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=+nE3mCDyYARrvfWPxumqxytj4yp6uVc6RCCcrnXTLYY=; b=V7mxVt8Xh4LDhIVFT1oUcExrSzcQdqGBamFbM9oXsQqvlkcuvkbFJGAZQOKKVW7j5U EqqoHFQD+28C5CY57GM7cKIpyLsB8IyF4c8yVtf8O4SjlIF/kPOKF24iQwe2V6XqEI1O WYbo5A7pPPcWiEYuk61DTWC17+Ml6tEXuKdVWkP/It/VLBXzUYZ2No6h+QI8unuecrOZ zmgu9/FF+Fz3YT1QdO8+BGEfwHUnVonZIb/zD4N6CUBmY/ZOljY0uLhhQ6KRKAPsVwiA RqfiHGiBwVkWtd5HzraPP3SiOpX7cZa/x4em1RfTxnUl+xAav5iUnWQSgaqBUf/WkPny urRA== X-Received: by 10.14.211.69 with SMTP id v45mr19014702eeo.45.1368548450158; Tue, 14 May 2013 09:20:50 -0700 (PDT) Received: from localhost ([2.216.16.214]) by mx.google.com with ESMTPSA id x41sm30489001eey.17.2013.05.14.09.20.47 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 14 May 2013 09:20:49 -0700 (PDT) Date: Tue, 14 May 2013 17:20:46 +0100 From: Jamie Iles To: Maxime Ripard Subject: Re: [PATCH 04/20] ARM: picoxcell: Remove init_irq declaration in machine description Message-ID: <20130514162046.GA16346@page> References: <1368545933-7430-1-git-send-email-maxime.ripard@free-electrons.com> <1368545933-7430-5-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1368545933-7430-5-git-send-email-maxime.ripard@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQl0tA+frtN88TBbN+2XWiul7m2SJU5AGSqI6wB0hr/w8bwu9JS6wo4yMTc31DyIpuK9lTw6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130514_122117_363403_8C1E70DC X-CRM114-Status: GOOD ( 13.88 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-msm@vger.kernel.org, Andrew Lunn , Jason Cooper , Arnd Bergmann , linux-sh@vger.kernel.org, Christian Daudt , Viresh Kumar , Linus Walleij , Magnus Damm , Michal Simek , linux-kernel@vger.kernel.org, Olof Johansson , Simon Horman , Barry Song , Gregory Clement , Jamie Iles , David Brown , Shawn Guo , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Maxime, Thanks for this, I'll add it to my tree. I've modified it slightly to kill off the other irq includes, hopefully that's okay with you. Thanks, Jamie 8<--- From 4b83f75a7af388aaf5f79ccf72c37074bc9166da Mon Sep 17 00:00:00 2001 From: Maxime Ripard Date: Tue, 14 May 2013 17:38:37 +0200 Subject: [PATCH] ARM: picoxcell: Remove init_irq declaration in machine description Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is specified") removed the need to explictly setup the init_irq field in the machine description when using only irqchip_init. Remove that declaration for picoxcell as well. [ jiles: removed other, unused irq includes. ] Signed-off-by: Maxime Ripard Signed-off-by: Jamie Iles --- arch/arm/mach-picoxcell/common.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm/mach-picoxcell/common.c b/arch/arm/mach-picoxcell/common.c index f6f71bb..b069fa6 100644 --- a/arch/arm/mach-picoxcell/common.c +++ b/arch/arm/mach-picoxcell/common.c @@ -8,12 +8,8 @@ * All enquiries to support@picochip.com */ #include -#include -#include -#include #include #include -#include #include #include @@ -85,7 +81,6 @@ static void picoxcell_wdt_restart(char mode, const char *cmd) DT_MACHINE_START(PICOXCELL, "Picochip picoXcell") .map_io = picoxcell_map_io, .nr_irqs = NR_IRQS_LEGACY, - .init_irq = irqchip_init, .init_time = dw_apb_timer_init, .init_machine = picoxcell_init_machine, .dt_compat = picoxcell_dt_match,