[01/15] ARM: shmobile: Per-board uImage load addresses

Commit Message

Magnus Damm June 5, 2013, 7:06 a.m. UTC

From: Magnus Damm <[e-mail]>

Introduce per-board uImage load address calculation.

This will allow us to use the same uImage for multiple
boards if the load address happens to match. For now
keep on using CONFIG_MEMORY_START.

Signed-off-by: Magnus Damm <[e-mail]>
---

 arch/arm/mach-shmobile/Makefile.boot |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Arnd Bergmann June 5, 2013, 8:29 a.m. UTC | #1

On Wednesday 05 June 2013 16:06:25 Magnus Damm wrote:
> 
> +__ZRELADDR     := $(shell /bin/bash -c \
> +                    'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
> +

It's not important, but I think this can be written much simpler using
makefile syntax as

__ZRELADDR	:= $(sort $(loadaddr-y))

	Arnd

Magnus Damm June 6, 2013, 7:26 a.m. UTC | #2

Hi Arnd,

On Wed, Jun 5, 2013 at 5:29 PM, Arnd Bergmann <[e-mail]> wrote:
> On Wednesday 05 June 2013 16:06:25 Magnus Damm wrote:
>>
>> +__ZRELADDR     := $(shell /bin/bash -c \
>> +                    'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
>> +
>
> It's not important, but I think this can be written much simpler using
> makefile syntax as
>
> __ZRELADDR      := $(sort $(loadaddr-y))

Yes, correct. Just double checked by comparing the output. Your
proposal is much cleaner, will follow that if/when I send a V2.

Thanks,

/ magnus

Patch

--- 0001/arch/arm/mach-shmobile/Makefile.boot
+++ work/arch/arm/mach-shmobile/Makefile.boot	2013-06-04 12:33:07.000000000 +0900
@@ -1,6 +1,9 @@ 
-__ZRELADDR	:= $(shell /bin/bash -c 'printf "0x%08x" \
+loadaddr-y	:= $(shell /bin/bash -c 'printf "0x%08x" \
 		     $$[$(CONFIG_MEMORY_START) + 0x8000]')
 
+__ZRELADDR	:= $(shell /bin/bash -c \
+		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
+
    zreladdr-y   += $(__ZRELADDR)
 
 # Unsupported legacy stuff