From patchwork Tue Jun 18 16:58:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2744221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 34AD59F8E1 for ; Tue, 18 Jun 2013 16:59:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03E7B202F8 for ; Tue, 18 Jun 2013 16:59:38 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75FBC2024C for ; Tue, 18 Jun 2013 16:59:36 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UozFX-0005hq-9h; Tue, 18 Jun 2013 16:59:20 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UozFJ-0005xB-Oo; Tue, 18 Jun 2013 16:59:05 +0000 Received: from moutng.kundenserver.de ([212.227.126.171]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UozFG-0005wo-Cv for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2013 16:59:03 +0000 Received: from klappe2.localnet (HSI-KBW-095-208-002-043.hsi5.kabel-badenwuerttemberg.de [95.208.2.43]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0Ld8Qn-1UOl5i2Mgj-00iTD3; Tue, 18 Jun 2013 18:58:39 +0200 From: Arnd Bergmann Organization: Linaro Limited To: Naresh Kamboju Subject: Re: linux-next: origen build failed at drivers/pinctrl/pinctrl-exynos.c Date: Tue, 18 Jun 2013 18:58:37 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; ) References: In-Reply-To: MIME-Version: 1.0 Message-Id: <201306181858.37999.arnd.bergmann@linaro.org> X-Provags-ID: V02:K0:uxwG8vFuSY8kOyAJqSJKJd6hTc5B5MZa0w+RdaRalqN HREGGw5XTa3A4Lwf2ksB/88P7DnrYKYVgZXVROwIcZWvvBufB6 /BtTtBAgW7mz28MzD40HjvHpJchjM4RQFz7oOrn99FWrn1I4SI lZ3yVprgD0gP+sLo7Td842o6yc5KAKgrOV4JucjPsQOjkWtrJC bzmR0/GOTMfEbVWsJaJBFvwyNRrzCLS/yRFvtEH2A3Jwp1Sl4K fzPGVcKAmltJgpf/y36Q+QAMOvzLImEeNeg+ycj3Q4M4PfPZjA lFWBXtWp/2gLRzNmd0xMybLZw5Fn0kqw0gKXfRe6Q3NL4OzJVb jcGaG3qjBjcIgHsXBSp2UYklz8wj+0qqs9G3IL6dX X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130618_125902_664094_004A2D11 X-CRM114-Status: GOOD ( 14.57 ) X-Spam-Score: -1.9 (-) Cc: Kukjin Kim , Tomasz Figa , "linux-kernel@vger.kernel.org" , Doug Anderson , linux-samsung-soc@vger.kernel.org, Thomas Abraham , Milosz Wasilewski , Linus Walleij , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday 18 June 2013, Naresh Kamboju wrote: > Hi, > > linux-next branch failed to build origen build > > defconfig: exynos_defconfig > > full build log: > ---------------- > https://ci.linaro.org/jenkins/job/linux-next/hwpack=origen,label=kernel_cloud/72/console > > build error log: > -------------------- > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c: > In function ‘exynos_wkup_irq_mask’: > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c:299:3: > error: implicit declaration of function ‘exynos_wkup_irq_ack’ > [-Werror=implicit-function-declaration] > 05:02:12 exynos_wkup_irq_ack(irqd); > 05:02:12 ^ > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c: > At top level: > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c:310:13: > warning: conflicting types for ‘exynos_wkup_irq_ack’ [enabled by > default] > 05:02:12 static void exynos_wkup_irq_ack(struct irq_data *irqd) > 05:02:12 ^ > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c:310:13: > error: static declaration of ‘exynos_wkup_irq_ack’ follows non-static > declaration > 05:02:12 /mnt/ci_build/workspace/linux-next/hwpack/origen/label/kernel_cloud/drivers/pinctrl/pinctrl-exynos.c:299:3: > note: previous implicit declaration of ‘exynos_wkup_irq_ack’ was here > 05:02:12 exynos_wkup_irq_ack(irqd); > 05:02:12 ^ > 05:02:12 cc1: some warnings being treated as errors > 05:02:12 make[3]: *** [drivers/pinctrl/pinctrl-exynos.o] Error 1 > 05:02:12 make[2]: *** [drivers/pinctrl] Error 2 > > Best regards > Naresh kamboju > I got the same thing and used this patch to fix it up. Signed-off-by: Arnd Bergmann --- Linus, could you fold that into Doug's patch? diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c index ef75321..00cd89a 100644 --- a/drivers/pinctrl/pinctrl-exynos.c +++ b/drivers/pinctrl/pinctrl-exynos.c @@ -279,6 +279,15 @@ err_domains: return ret; } +static void exynos_wkup_irq_ack(struct irq_data *irqd) +{ + struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); + struct samsung_pinctrl_drv_data *d = b->drvdata; + unsigned long pend = d->ctrl->weint_pend + b->eint_offset; + + writel(1 << irqd->hwirq, d->virt_base + pend); +} + static void exynos_wkup_irq_mask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); @@ -296,15 +305,6 @@ static void exynos_wkup_irq_mask(struct irq_data *irqd) spin_unlock_irqrestore(&b->slock, flags); } -static void exynos_wkup_irq_ack(struct irq_data *irqd) -{ - struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); - struct samsung_pinctrl_drv_data *d = b->drvdata; - unsigned long pend = d->ctrl->weint_pend + b->eint_offset; - - writel(1 << irqd->hwirq, d->virt_base + pend); -} - static void exynos_wkup_irq_unmask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd);