From patchwork Tue Jun 25 23:02:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 2781401 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 14B85C0AB1 for ; Tue, 25 Jun 2013 23:04:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F106D2026C for ; Tue, 25 Jun 2013 23:04:04 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B29BF20268 for ; Tue, 25 Jun 2013 23:04:03 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrcGz-0004mT-AH; Tue, 25 Jun 2013 23:03:41 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrcGn-0007Bp-4Y; Tue, 25 Jun 2013 23:03:29 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UrcGj-0007BB-JA for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2013 23:03:26 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r5PN2wlb028879; Tue, 25 Jun 2013 18:02:58 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r5PN2wwl011982; Tue, 25 Jun 2013 18:02:58 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Tue, 25 Jun 2013 18:02:58 -0500 Received: from localhost (kahuna.am.dhcp.ti.com [128.247.91.59]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r5PN2wvi006074; Tue, 25 Jun 2013 18:02:58 -0500 Date: Tue, 25 Jun 2013 18:02:58 -0500 From: Nishanth Menon To: Santosh Shilimkar Subject: Re: [PATCH] ARM: omap5: build opp4xxx_data.c Message-ID: <20130625230258.GA8127@kahuna> References: <51C9F595.3060609@ti.com> <20130625195751.GA6529@kahuna> <51C9F993.6050109@ti.com> <51C9FC97.1020502@ti.com> <87a9mducye.fsf@linaro.org> <51CA0498.9010506@ti.com> <20130625223636.GA4455@kahuna> <51CA1D14.4070600@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51CA1D14.4070600@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130625_190325_711140_F5750331 X-CRM114-Status: GOOD ( 30.44 ) X-Spam-Score: -8.2 (--------) Cc: Paul Walmsley , Kevin Hilman , Benoit Cousson , Arnd Bergmann , Tony Lindgren , "J, KEERTHY" , linux-omap , Linux ARM Kernel List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 18:43-20130625, Santosh Shilimkar wrote: > On Tuesday 25 June 2013 06:36 PM, Nishanth Menon wrote: > > On 16:59-20130625, Santosh Shilimkar wrote: > >> On Tuesday 25 June 2013 04:56 PM, Kevin Hilman wrote: > >>> Santosh Shilimkar writes: > >>> > >>>> On Tuesday 25 June 2013 04:17 PM, Nishanth Menon wrote: > >>>>> On Tue, Jun 25, 2013 at 3:12 PM, Santosh Shilimkar > >>>>> wrote: > >>>>>> > >>>>>> Well having voltage data in voltage domain was not my decision ;-) > >>>>>> Instead of creating another set of dummy data, I just used what > >>>>>> is out there(OMAP4) with clear comment that data needs to be updated. > >>>>>> I don't see any problem in this considering we have devices booting > >>>>>> and working nicely for OMAP5 > >>>>> I really wish the OMAP5 devices(the latest ones from Fab) I have would > >>>>> like to function at OMAP4 configurations! Unfortunately the devices > >>>>> tend to follow the data manual for OMAP5. > >>>>> *if* there is no need for it to boot, I suggest removing it. > >>>>> > >>>> I don't understand you. For OMAP5, that data without voltage > >>>> controller support doesn't do anything bad. Since there was some > >>>> dependency of voltage domain association whit PD's, I have to keep > >>>> that. I never claimed that OMAP4 settings would work for OMAP5 > >>>> in absolute terms. > >>>> > >>>> Feel free to post a patch with right data which you seems to have. > >>>> I don't mind you removing that data as long as the device > >>>> continues to boot. Patch welcome. > >>> > >>> Thanks to Rajendra's cleanup, I don't think we need dummy data anymore: > >>> > >>> http://marc.info/?l=linux-omap&m=137147503827947&w=2 > >>> > >>> That series is queued for v3.11. > >>> > >> I knew the series but wasn't sure about it getting queued up > >> for 3.11. Nice to see the dependency is getting removed. > > > > Anyways, I tried booting up a kernel built on linux-next-20130625 > > with omap2plus_defconfig and [1] on OMAP5uEVM and all I see is: > > Importing environment from mmc0 ... > > reading //zImage > > 4030024 bytes read in 198 ms (19.4 MiB/s) > > reading //omap5-uevm.dtb > > 17729 bytes read in 16 ms (1.1 MiB/s) > > [..] > > ## Flattened Device Tree blob at 80f80000 > > Booting using the fdt blob at 0x80f80000 > > Using Device Tree in place at 80f80000, end 80f87540 > > > > Starting kernel ... > > > > If someone can point me to a functional base, it'd be nice, or if there > > is a known pending fix, it'd be better.. > > Taking http://marc.info/?l=linux-omap&m=136984555408516&w=2 and rebasing > > on linux next tag resulted practically in NOP. > > > As mentioned in the cover-letter, you are probably missing the clock data. > ------------ > That means for the boot, one clock data patch needs to be applied. > It is available on my git tree in 'out_of_tree/omap5_clk_data' branch. > --------------------------------------- Thanks on the hint, I had missed it. I merged the for_3.11/out_of_tree/omap5_clk_data from git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git to linux-next-20130625 with a minor conflict in arch/arm/mach-omap2/io.c omap2plus_defconfig: http://pastebin.com/rTuEn0H6 Then applied: Result: http://pastebin.com/t8cdd7uj As kevin mentioned, we can boot without registering wrong voltage data. diff --git a/arch/arm/mach-omap2/voltagedomains54xx_data.c b/arch/arm/mach-omap2/voltagedomains54xx_data.c index 72b8971..89a5589f 100644 --- a/arch/arm/mach-omap2/voltagedomains54xx_data.c +++ b/arch/arm/mach-omap2/voltagedomains54xx_data.c @@ -89,11 +89,6 @@ void __init omap54xx_voltagedomains_init(void) * XXX Will depend on the process, validation, and binning * for the currently-running IC. Use OMAP4 data for time being. */ -#ifdef CONFIG_PM_OPP - omap5_voltdm_mpu.volt_data = omap446x_vdd_mpu_volt_data; - omap5_voltdm_mm.volt_data = omap446x_vdd_iva_volt_data; - omap5_voltdm_core.volt_data = omap446x_vdd_core_volt_data; -#endif for (i = 0; voltdm = voltagedomains_omap5[i], voltdm; i++) voltdm->sys_clk.name = sys_clk_name;