From patchwork Wed Jul 3 01:46:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 2814981 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F3F15BF4A1 for ; Wed, 3 Jul 2013 01:46:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 195FC20109 for ; Wed, 3 Jul 2013 01:46:54 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EAF7200F2 for ; Wed, 3 Jul 2013 01:46:53 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UuC9Y-00032h-Ri; Wed, 03 Jul 2013 01:46:41 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UuC9W-0007Ie-IB; Wed, 03 Jul 2013 01:46:38 +0000 Received: from co1ehsobe006.messaging.microsoft.com ([216.32.180.189] helo=co1outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UuC9T-0007I9-Ui for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2013 01:46:37 +0000 Received: from mail208-co1-R.bigfish.com (10.243.78.244) by CO1EHSOBE010.bigfish.com (10.243.66.73) with Microsoft SMTP Server id 14.1.225.22; Wed, 3 Jul 2013 01:46:07 +0000 Received: from mail208-co1 (localhost [127.0.0.1]) by mail208-co1-R.bigfish.com (Postfix) with ESMTP id 07B2C200BC; Wed, 3 Jul 2013 01:46:07 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dIc89bh1432Izz1f42h1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzzz2dh87h2a8h668h839h93fhd25hf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1151h1155h) X-FB-DOMAIN-IP-MATCH: fail Received: from mail208-co1 (localhost.localdomain [127.0.0.1]) by mail208-co1 (MessageSwitch) id 1372815964610990_6820; Wed, 3 Jul 2013 01:46:04 +0000 (UTC) Received: from CO1EHSMHS025.bigfish.com (unknown [10.243.78.248]) by mail208-co1.bigfish.com (Postfix) with ESMTP id 87B616C0052; Wed, 3 Jul 2013 01:46:04 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO1EHSMHS025.bigfish.com (10.243.66.35) with Microsoft SMTP Server (TLS) id 14.1.225.23; Wed, 3 Jul 2013 01:46:00 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-005.039d.mgd.msft.net (10.84.1.17) with Microsoft SMTP Server (TLS) id 14.2.328.11; Wed, 3 Jul 2013 01:45:59 +0000 Received: from S2101-09.ap.freescale.net ([10.192.185.47]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r631jtgN013212; Tue, 2 Jul 2013 18:45:56 -0700 Date: Wed, 3 Jul 2013 09:46:24 +0800 From: Shawn Guo To: Huang Shijie Subject: Re: [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property Message-ID: <20130703014623.GB9145@S2101-09.ap.freescale.net> References: <1372746628-20092-1-git-send-email-b32955@freescale.com> <1372746628-20092-4-git-send-email-b32955@freescale.com> <20130702095645.GD31358@e106331-lin.cambridge.arm.com> <51D2AEC1.6030004@freescale.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51D2AEC1.6030004@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130702_214636_161794_B6C86E14 X-CRM114-Status: GOOD ( 14.52 ) X-Spam-Score: -2.6 (--) Cc: Mark Rutland , "gregkh@linuxfoundation.org" , "s.hauer@pengutronix.de" , "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jul 02, 2013 at 06:43:13PM +0800, Huang Shijie wrote: > ? 2013?07?02? 17:56, Mark Rutland ??: > >On Tue, Jul 02, 2013 at 07:30:26AM +0100, Huang Shijie wrote: > >>> The imx6 uart can supports the DMA, imx uart driver has added a new > >>> compatible property for the imx6 uart. > >>> > In order to enable the DMA for some uart port in imx6, we > >>rename the > >>> uart's compatible property to "fsl,imx6-uart". > >Doesn't this change break using these dts with an older kernel? You > is it reasonable to use a new dts with an old kernel? > > > >remove the "fsl,imx21-uart" string older kernels understand. > > > >Given you already had "fsl,imx6q-uart" and "fsl,imx6sl-uart" strings, > >would it not have made more sense to just add these to the driver? > I think it's not a good idea. > > Shawn, what's your opinion about this? I agree with Mark. I think all we need is to add "fsl,imx6q-uart" into both driver matching table and imx6sl uart compatible property, something like the below. Shawn ---8<------- diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index c5e5da0..078dfc7 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -152,7 +152,8 @@ }; uart5: serial@02018000 { - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart"; + compatible = "fsl,imx6sl-uart", "fsl,imx6q-uart", + "fsl,imx21-uart"; reg = <0x02018000 0x4000>; interrupts = <0 30 0x04>; clocks = <&clks IMX6SL_CLK_UART>, diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 8cdfbd3..457984d 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -249,6 +249,7 @@ MODULE_DEVICE_TABLE(platform, imx_uart_devtype); static struct of_device_id imx_uart_dt_ids[] = { { .compatible = "fsl,imx1-uart", .data = &imx_uart_devdata[IMX1_UART], }, { .compatible = "fsl,imx21-uart", .data = &imx_uart_devdata[IMX21_UART], }, + { .compatible = "fsl,imx6q-uart", .data = &imx_uart_devdata[IMX6Q_UART], }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, imx_uart_dt_ids);