From patchwork Thu Jul 25 21:58:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Domenico Andreoli X-Patchwork-Id: 2833690 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B4123C0319 for ; Thu, 25 Jul 2013 21:58:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7E5620340 for ; Thu, 25 Jul 2013 21:58:28 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F9F420320 for ; Thu, 25 Jul 2013 21:58:27 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2TYH-0000B9-8Y; Thu, 25 Jul 2013 21:58:25 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2TYE-0006p0-VO; Thu, 25 Jul 2013 21:58:23 +0000 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2TYB-0006o3-EI for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2013 21:58:20 +0000 Received: by mail-ee0-f54.google.com with SMTP id t10so1199578eei.27 for ; Thu, 25 Jul 2013 14:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to; bh=PVza1L8YBnS92Agh5HIVEz5JtOy995/ma5Ll0IYstI8=; b=aLhhUiFPnYFFu/vW4/zbJPjqyNDdT+3bVAuAtREVourrAYXOrECU0C+VM/7G5FeSqX BIJYfsSRwVS/z3y88EF9nXGtA4Cdc7HUmQ2cZgEwEtMmnKzgBB+/NLtaT9aGwdtyh3VC MQbna/3rwEpBmBNj4avmKDWkhEO4wWaCGvMl0JBLrce83XWdpFIjFzZiHOmYLxBEwwgr vjcsKvlKpLPLayCF7w0s/AGOwfJDdQmFTct7on456tEkszsBGJz4Cdk0hOEMxXSbuIJJ +gbGBOzvi0De44+ufcS5sz2GvAGY4tgDF2TSgwFO13/vCtnS7t1F12W8zGIqnLo6giwF y9Rw== X-Received: by 10.14.216.73 with SMTP id f49mr44296882eep.119.1374789477576; Thu, 25 Jul 2013 14:57:57 -0700 (PDT) Received: from glitch (j115181.upc-j.chello.nl. [24.132.115.181]) by mx.google.com with ESMTPSA id n5sm76525410eed.9.2013.07.25.14.57.55 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Jul 2013 14:57:56 -0700 (PDT) Received: by glitch (Postfix, from userid 1000) id EFAB53C1952; Thu, 25 Jul 2013 23:58:03 +0200 (CEST) Date: Thu, 25 Jul 2013 23:58:03 +0200 From: Domenico Andreoli To: Christian Daudt Subject: Re: [PATCH] bcm53xx: initial support for the BCM5301/BCM470X SoC with ARM CPU Message-ID: <20130725215803.GB22296@glitch> Mail-Followup-To: Christian Daudt , Hauke Mehrtens , Thomas Petazzoni , "matt.porter@linaro.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann References: <2043662.BcW19XTTMG@lenovo> <20130723184907.GA6811@ohporter.com> <20130723192203.GC6811@ohporter.com> <51EF1B8C.9020304@broadcom.com> <51F02947.7020301@hauke-m.de> <20130724225443.GA29801@glitch> <51F18BAA.1050806@hauke-m.de> <51F19A83.2090000@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51F19A83.2090000@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130725_175819_741476_5F6D9797 X-CRM114-Status: GOOD ( 30.16 ) X-Spam-Score: -2.0 (--) Cc: Thomas Petazzoni , Hauke Mehrtens , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "matt.porter@linaro.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jul 25, 2013 at 02:37:07PM -0700, Christian Daudt wrote: > On 13-07-25 01:33 PM, Hauke Mehrtens wrote: > >On 07/25/2013 12:54 AM, Domenico Andreoli wrote: > >>On Wed, Jul 24, 2013 at 09:21:43PM +0200, Hauke Mehrtens wrote: > >>>On 07/24/2013 02:44 AM, Domenico Andreoli wrote: > >>>>On Wednesday, July 24, 2013, Hauke Mehrtens >>>>> wrote: > >>>>>On 07/19/2013 03:36 AM, Domenico Andreoli wrote: > >>>>>>On Tue, Jul 16, 2013 at 05:35:21PM +0200, Hauke Mehrtens wrote: > >>>>>>>On 07/16/2013 05:20 PM, Thomas Petazzoni wrote: > >>>>>>>>>diff --git a/arch/arm/mach-bcm53xx/Kconfig > >>>>b/arch/arm/mach-bcm53xx/Kconfig > >>>>>>>>>new file mode 100644 > >>>>>>>>>index 0000000..1e16e87 > >>>>>>>>>--- /dev/null > >>>>>>>>>+++ b/arch/arm/mach-bcm53xx/Kconfig > >>>>>>>>>@@ -0,0 +1,10 @@ > >>>>>>>>>+config ARCH_BCM53XX > >>>>>>>>>+ bool "Broadcom BCM47XX / BCM53XX ARM SoC" > >>>>>>>>So the directory is named mach-bcm53xx, but you also handle BCM47xx > >>>>>>>>SoCs. This doesn't sound really easy to follow. > >>>>>>At the time of the BCM281XX merge we considered that such directories > >>>>would > >>>>>>mostly contain board files only, being these new entries DT based. Hence > >>>>>>the choice of mach-bcm to collect all of them. > >>>>>> > >>>>>>I think you should then put this stuff there. > >>>>>So you think I should move the file from > >>>>>arch/arm/mach-bcm53xx/bcm53xx.c to arch/arm/mach-bcm/bcm53xx.c ? > >>>>yes > >>>> > >>>>this looks more comsistent with the actual soc name: > >>>>arch/arm/mach-bcm/bcm530xx.c > >>>> > >>>>but I find also acceptable the complete name of the "parent" soc (as I'm > >>>>doing with the bcm4760), so: arch/arm/mach-bcm/bcm53010.c > >>>I do not think these Broadcom ARM SoCs (bcm4760, BCM5301X, bcm11351) > >>>have more in common than the vendor name, so I do not think it is a good > >>>idea to place them all at mach-bcm. > >>In an ideal DT-only world (as basically is for Broadcom ARM SoCs), whatever > >>two or more SoCs share can hopefully modelled in a driver and as such > >>would go in the drivers/ subtree. What's left is really SoC specific and, > >>again hopefully, very minimal. > >> > >>There should not be any SoC so weird to require a whole subdirectory full > >>of that SoC specific stuff. So grouping everything by vendor name looks > >>quite appealing to me. > >> > >>Sharing the same subdir requires people working in it to talk and find > >>agreements some more than the sparsely populated subdir did (because there > >>is not a single maintainer who owns it). I think this is a big advantage > >>Broadcomers can start with right now. > >I want to be able to build the BCM5301X SoC without building the current > >CONFIG_ARCH_BCM, so what name do you suggest for board_bcm.o ? > >My plan would be to make CONFIG_ARCH_BCM just activate the Broadcom > >submenu, but not build any code. Then the list of Broadcom SoCs is > >opened like CONFIG_ARCH_BCM5301X and the "old" CONFIG_ARCH_BCM. > > > > > CONFIG_ARCH_BCM wasn't the best name, but it is there now. We intend > to upstream the (mobile-team) ARM SoCs going forward, and have them > be multiplatform and all buildable into a single zImage with the > ARCH_BCM config option. Which is why this option does not have a > chip name on it. > Take ARCH_BCM == Broadcom Mobile team SoCs (I think that's what the > help on it says). This solves the double linking issue I had. No need to configure CONFIG_ARCH_BCM if you are not interested in what it brings. Regards, Domenico diff --git a/arch/arm/Makefile b/arch/arm/Makefile index c0ac0f5..230b5d7 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -145,7 +145,7 @@ textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000 # Machine directory name. This list is sorted alphanumerically # by CONFIG_* macro name. machine-$(CONFIG_ARCH_AT91) += at91 -machine-$(CONFIG_ARCH_BCM) += bcm +machine-y += bcm machine-$(CONFIG_ARCH_BCM2835) += bcm2835 machine-$(CONFIG_ARCH_CLPS711X) += clps711x machine-$(CONFIG_ARCH_CNS3XXX) += cns3xxx