From patchwork Thu Sep 26 16:06:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 2949531 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 993AD9F288 for ; Thu, 26 Sep 2013 16:09:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69C4120333 for ; Thu, 26 Sep 2013 16:09:00 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 919A72031A for ; Thu, 26 Sep 2013 16:08:55 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VPE6a-0007no-5s; Thu, 26 Sep 2013 16:07:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VPE6B-0003We-1v; Thu, 26 Sep 2013 16:07:27 +0000 Received: from bear.ext.ti.com ([192.94.94.41]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VPE67-0003Uq-W0 for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2013 16:07:24 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r8QG6wOn014648; Thu, 26 Sep 2013 11:06:58 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8QG6wPg004763; Thu, 26 Sep 2013 11:06:58 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Thu, 26 Sep 2013 11:06:57 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8QG6vYm024397; Thu, 26 Sep 2013 11:06:57 -0500 Date: Thu, 26 Sep 2013 11:06:57 -0500 From: Nishanth Menon To: Tero Kristo Subject: Re: [PATCHv7 30/36] ARM: dts: omap3 clock data Message-ID: <20130926160657.GA6280@kahuna> References: <1380098922-30340-1-git-send-email-t-kristo@ti.com> <1380098922-30340-31-git-send-email-t-kristo@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1380098922-30340-31-git-send-email-t-kristo@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130926_120724_102268_72F3F762 X-CRM114-Status: GOOD ( 12.81 ) X-Spam-Score: -9.3 (---------) Cc: devicetree@vger.kernel.org, paul@pwsan.com, mturquette@linaro.org, tony@atomide.com, rnayak@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11:48-20130925, Tero Kristo wrote: > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index 16420ae..bc11b83 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -533,4 +533,11 @@ > ram-bits = <12>; > }; > }; > + > + clocks { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + /include/ "omap3xxx-clocks.dtsi" > + }; > }; Clocks are introduced towards the tail of the dts -> this has a problem associated with it -> device nodes should be able to reference phandle like: devicex { clocks = <&sys_ck>; } Since all the devices on ocp and cpu0 node appears above the definition they fail to catch the phandle. instead, moving the clocks node as high in the tree as possible resolves this: something like: What do you think of the change? applies for all clock nodes in other dtsi as well - I will mark them as I find them. Further, > diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi > index 5355d61..2ed7c69 100644 > --- a/arch/arm/boot/dts/omap34xx.dtsi > +++ b/arch/arm/boot/dts/omap34xx.dtsi > @@ -25,4 +25,123 @@ > clock-latency = <300000>; /* From legacy driver */ > }; > }; > -}; > + > + clocks { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; dont need to state the above two -> already done in omap3.dtsi. > + /include/ "omap34xx-omap36xx-clocks.dtsi" > + /include/ "omap36xx-omap3430es2plus-clocks.dtsi" > + /include/ "omap36xx-am35xx-omap3430es2plus-clocks.dtsi" > + }; > +}; [...] > \ No newline at end of file ^^ [...] > diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi > index f8b3765..71fb6fb 100644 > --- a/arch/arm/boot/dts/omap36xx.dtsi > +++ b/arch/arm/boot/dts/omap36xx.dtsi > @@ -35,4 +35,124 @@ > clock-frequency = <48000000>; > }; > }; > -}; > + > + clocks { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; ^^ here as well. > + /include/ "omap36xx-clocks.dtsi" > + /include/ "omap34xx-omap36xx-clocks.dtsi" > + /include/ "omap36xx-omap3430es2plus-clocks.dtsi" > + /include/ "omap36xx-am35xx-omap3430es2plus-clocks.dtsi" > + }; [...] > +}; > \ No newline at end of file ^^ this need fix as well. diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index bc11b83..0b2161d 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -24,6 +24,13 @@ serial2 = &uart3; }; + clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; + /include/ "omap3xxx-clocks.dtsi" + }; + cpus { #address-cells = <1>; #size-cells = <0>; @@ -534,10 +541,4 @@ }; }; - clocks { - #address-cells = <1>; - #size-cells = <1>; - ranges; - /include/ "omap3xxx-clocks.dtsi" - }; };