From patchwork Wed Nov 6 23:31:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 3149971 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A9C029F47C for ; Wed, 6 Nov 2013 23:35:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C50AC2058E for ; Wed, 6 Nov 2013 23:35:30 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D83412050B for ; Wed, 6 Nov 2013 23:35:29 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VeCai-0002rj-GV; Wed, 06 Nov 2013 23:32:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VeCaD-0006pp-7c; Wed, 06 Nov 2013 23:32:21 +0000 Received: from smtp.outflux.net ([2001:19d0:2:6:c0de:0:736d:7470]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VeCa9-0006pE-3i for linux-arm-kernel@lists.infradead.org; Wed, 06 Nov 2013 23:32:18 +0000 Received: from www.outflux.net (serenity-end.outflux.net [10.2.0.2]) by vinyl.outflux.net (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id rA6NVHiI018588; Wed, 6 Nov 2013 15:31:18 -0800 Date: Wed, 6 Nov 2013 15:31:17 -0800 From: Kees Cook To: linux-kernel@vger.kernel.org Subject: [PATCH] seccomp: not compatible with ARM OABI Message-ID: <20131106233117.GA24545@www.outflux.net> MIME-Version: 1.0 Content-Disposition: inline X-MIMEDefang-Filter: outflux$Revision: 1.316 $ X-HELO: www.outflux.net X-Scanned-By: MIMEDefang 2.71 on 10.2.0.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131106_183217_366961_D4985573 X-CRM114-Status: GOOD ( 12.25 ) X-Spam-Score: -1.9 (-) Cc: Stephen Rothwell , James Hogan , Russell King - ARM Linux , Eric Paris , Andy Lutomirski , libseccomp-discuss@lists.sourceforge.net, Will Drewry , Andrew Morton , Thomas Gleixner , linux-arm-kernel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure that seccomp filter won't be built when ARM OABI is in use, since there is work needed to distinguish calling conventions. Until that is done (which is likely never since OABI is deprecated), make sure seccomp filter is unavailable in the OABI compat world. Signed-off-by: Kees Cook Reviewed-By: Will Drewry --- arch/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index af2cc6eabcc7..6eaca7d92399 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER config SECCOMP_FILTER def_bool y - depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET + depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT help Enable tasks to build secure computing environments defined in terms of Berkeley Packet Filter programs which implement task-defined system call filtering polices. + Not available on ARM when built with OABI compatibility due to + lack of a sensible way to distinguish the calling conventions. + See Documentation/prctl/seccomp_filter.txt for details. config HAVE_CONTEXT_TRACKING