From patchwork Thu Nov 14 19:00:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 3184591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4BAFFC045B for ; Thu, 14 Nov 2013 19:00:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2FF6B20931 for ; Thu, 14 Nov 2013 19:00:55 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A32E2092F for ; Thu, 14 Nov 2013 19:00:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vh29g-0004ko-7B; Thu, 14 Nov 2013 19:00:40 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vh29d-0001Kl-Ks; Thu, 14 Nov 2013 19:00:37 +0000 Received: from mail-qe0-x232.google.com ([2607:f8b0:400d:c02::232]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vh29W-0001JQ-S6; Thu, 14 Nov 2013 19:00:31 +0000 Received: by mail-qe0-f50.google.com with SMTP id 1so1565239qee.23 for ; Thu, 14 Nov 2013 11:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=dIAbOaAr0xqu6Mn6BCHSZx5yj2qVnX2FElXlHavSfNw=; b=B++oq5LvWb76ZzDoS8ExNOtQqj2KBKOzphTxf7sa3pfiUNArPv4g5pa9oxLjQpiy2n klskK4MPs5KWpMS8snbIFFSwHmdva1UInpul/YJ5EutSr2b7eYHlu67OI7Hz6bnfnQvS 8xi0Zm3o/N5b1wH1ZoIptmGN5az3dHdSOdzMo+QlPFWtdb96SZ+JneNYsnFvzi8hvUXV shzaQRBEfET+goLi5vLw9ljwdMVGplLk397YfIV6M1km0iiziDdZCoY60quJ6SKqU+G4 OUl/WxNWgchwesd7kObwN/W7VwOp24F00q7BCzoRm/p8XmSxgrEpCgU2tsb0cmNFbSAx s8/g== X-Received: by 10.49.3.3 with SMTP id 3mr4637478qey.56.1384455608621; Thu, 14 Nov 2013 11:00:08 -0800 (PST) Received: from ld-irv-0074.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id j15sm1618023qaa.6.2013.11.14.11.00.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 14 Nov 2013 11:00:08 -0800 (PST) Date: Thu, 14 Nov 2013 11:00:04 -0800 From: Brian Norris To: Ezequiel Garcia Subject: Re: [PATCH v4 06/31] mtd: nand: pxa3xx: Add documentation about the controller Message-ID: <20131114190004.GP9468@ld-irv-0074.broadcom.com> References: <1383837455-30721-1-git-send-email-ezequiel.garcia@free-electrons.com> <1383837455-30721-7-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1383837455-30721-7-git-send-email-ezequiel.garcia@free-electrons.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131114_140030_962240_32A50CB9 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -2.0 (--) Cc: Lior Amsalem , devicetree@vger.kernel.org, Jason Cooper , Tawfik Bayouk , linux-doc@vger.kernel.org, Willy Tarreau , Huang Shijie , linux-mtd@lists.infradead.org, Gregory Clement , Daniel Mack , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Nov 07, 2013 at 12:17:10PM -0300, Ezequiel Garcia wrote: > Given there's no public specification to this date, and in order > to capture some important details and singularities about the > controller let's document them once and for good. Made a few small tweaks for spelling and such (see the following diff) and pushed patches 5 through 14 to l2-mtd.git/next. Thanks, Brian diff --git a/Documentation/mtd/nand/pxa3xx-nand.txt b/Documentation/mtd/nand/pxa3xx-nand.txt index 00e601c..840fd41 100644 --- a/Documentation/mtd/nand/pxa3xx-nand.txt +++ b/Documentation/mtd/nand/pxa3xx-nand.txt @@ -36,7 +36,7 @@ OOB, one per chunk read. So, in order to achieve reading (for instance), we issue several READ0 commands (with some additional controller-specific magic) and read two chunks of 2080B (2048 data + 32 spare) each. -The driver accomodates this data to expose the NAND core a contiguous buffer +The driver accommodates this data to expose the NAND core a contiguous buffer (4096 data + spare) or (4096 + spare + ECC + spare + ECC). ECC @@ -81,7 +81,7 @@ an *entire* page. Factory bad blocks handling =========================== -Given the ECC BCH requires to layout the device's pages in a splitted +Given the ECC BCH requires to layout the device's pages in a split data/OOB/data/OOB way, the controller has a view of the flash page that's different from the specified (aka the manufacturer's) view. In other words, @@ -109,5 +109,5 @@ disabled by using the NAND_BBT_NO_OOB_BBM option in the driver. The rationale for this is that there's no point in marking a block as bad, because good blocks are also 'marked as bad' (in the OOB BBM sense) under normal usage. -Instead, the drive relies in the bad block table alone, and should only perform +Instead, the driver relies on the bad block table alone, and should only perform the bad block scan on the very first time (when the device hasn't been used).