diff mbox

Versatile LEDs initialise to off state

Message ID 20131126194418.GI16735@n2100.arm.linux.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Russell King - ARM Linux Nov. 26, 2013, 7:44 p.m. UTC
There really is no excuse to turn on all 8 LEDs at boot time, such
that on the Versatile PB/926 we end up with 6 LEDs on continuously
and forever.  We're not a christmas decoration!

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/plat-versatile/leds.c |    4 +-
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Linus Walleij Nov. 26, 2013, 11:23 p.m. UTC | #1
On Tue, Nov 26, 2013 at 8:44 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:

> There really is no excuse to turn on all 8 LEDs at boot time, such
> that on the Versatile PB/926 we end up with 6 LEDs on continuously
> and forever.  We're not a christmas decoration!
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Do you want me to queue this patch thru ARM SoC or are you
taking it through your tree?

Yours,
Linus Walleij
Russell King - ARM Linux Nov. 27, 2013, 2:18 p.m. UTC | #2
On Wed, Nov 27, 2013 at 12:23:32AM +0100, Linus Walleij wrote:
> On Tue, Nov 26, 2013 at 8:44 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> 
> > There really is no excuse to turn on all 8 LEDs at boot time, such
> > that on the Versatile PB/926 we end up with 6 LEDs on continuously
> > and forever.  We're not a christmas decoration!
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Do you want me to queue this patch thru ARM SoC or are you
> taking it through your tree?

I don't mind.  If you want to queue it please use rmk+kernel in the
author address, thanks.
diff mbox

Patch

diff --git a/arch/arm/plat-versatile/leds.c b/arch/arm/plat-versatile/leds.c
index d2490d00b46c..c74aa5707dab 100644
--- a/arch/arm/plat-versatile/leds.c
+++ b/arch/arm/plat-versatile/leds.c
@@ -73,7 +73,7 @@  static int __init versatile_leds_init(void)
 {
 	int i;
 
-	/* All ON */
-	writel(0xff, LEDREG);
+	/* All off */
+	writel(0, LEDREG);
 	for (i = 0; i < ARRAY_SIZE(versatile_leds); i++) {
 		struct versatile_led *led;