From patchwork Fri Dec 20 01:53:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 3385271 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8C838C0D4A for ; Fri, 20 Dec 2013 02:01:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A8C9B203EC for ; Fri, 20 Dec 2013 02:01:12 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C24201BD for ; Fri, 20 Dec 2013 02:01:11 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VtpOl-0006da-Gn; Fri, 20 Dec 2013 02:01:07 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VtpOj-0003hR-7u; Fri, 20 Dec 2013 02:01:05 +0000 Received: from mail-yh0-f53.google.com ([209.85.213.53]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VtpOg-0003gk-8W for linux-arm-kernel@lists.infradead.org; Fri, 20 Dec 2013 02:01:03 +0000 Received: by mail-yh0-f53.google.com with SMTP id b20so493661yha.26 for ; Thu, 19 Dec 2013 18:00:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version :content-transfer-encoding:to:from:in-reply-to:cc:references :message-id:user-agent:subject:date; bh=aFWtW8f8uDQMLw6HkaXNiX9hkxIXSCPdbR3SKnayTAU=; b=AnPCEU444DlUwf8LjYrXku6t0y9uJYrPNXx8E/iRu35+zX1fSV9xWBeuWhmd9V/XyM rs+Ulzke+gwwsCpqPruJB70E1IGJQtSe4co++HF+oiqIhoNA72647B0L4siklfAWQTB9 pjgV4nkM6jNBNgb+6piX/rb6wqGm8KFeaIvKbPe1ISxQ29NVETFH8Nn8dU7CVwOxP0EV MnVCmQdUjA6o22iWOcTk0eH0ztfSlObU7Y5nJx8cqdZ0aTNIHBr3cfArgh0ZkXfaAaa2 Q+NM/0oI0mvKTI3zvrgABMqHeDrf61S6uVwkhFjb+0NFp6zFt0ZRfFxHlHvUpBmuq3WE iTwQ== X-Gm-Message-State: ALoCoQmCrJOonB5b6NId70wVwi9obETuyz3eUzptFoNejzYE87xS081Fj54NRPnvp8dqCBO8SgGi X-Received: by 10.236.62.194 with SMTP id y42mr4087444yhc.54.1387504389407; Thu, 19 Dec 2013 17:53:09 -0800 (PST) Received: from localhost ([2601:9:5900:1fe:ca60:ff:fe0a:8a36]) by mx.google.com with ESMTPSA id m29sm8840867yho.14.2013.12.19.17.53.07 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 19 Dec 2013 17:53:08 -0800 (PST) MIME-Version: 1.0 To: Sachin Kamat , linux-arm-kernel@lists.infradead.org From: Mike Turquette In-Reply-To: <1381231068-6053-3-git-send-email-sachin.kamat@linaro.org> References: <1381231068-6053-1-git-send-email-sachin.kamat@linaro.org> <1381231068-6053-3-git-send-email-sachin.kamat@linaro.org> Message-ID: <20131220015304.18119.81485@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c Date: Thu, 19 Dec 2013 17:53:04 -0800 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131219_210102_370158_213C2662 X-CRM114-Status: GOOD ( 11.22 ) X-Spam-Score: -2.6 (--) Cc: sachin.kamat@linaro.org, Stephen Warren X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Quoting Sachin Kamat (2013-10-08 04:17:41) > Local variables used only in this file are made static. > > Signed-off-by: Sachin Kamat > Cc: Stephen Warren I updated this patch to staticize tegra_clk_pllxc_ops after taking Peter's Tegra pull request. Refreshed patch has been applied to clk-next and a copy is found below. Let me know if you have any comments. Regards, Mike From: Sachin Kamat Date: Tue, 8 Oct 2013 16:47:41 +0530 Subject: [PATCH] clk: tegra: Staticize local variables in clk-pll.c Local variables used only in this file are made static. Signed-off-by: Sachin Kamat Cc: Stephen Warren Signed-off-by: Mike Turquette [mturquette@linaro.org: staticize struct clk_ops tegra_clk_pllxc_ops] --- drivers/clk/tegra/clk-pll.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 2dd4322..0d20241 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -1433,7 +1433,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name, } #if defined(CONFIG_ARCH_TEGRA_114_SOC) || defined(CONFIG_ARCH_TEGRA_124_SOC) -const struct clk_ops tegra_clk_pllxc_ops = { +static const struct clk_ops tegra_clk_pllxc_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable, @@ -1442,7 +1442,7 @@ const struct clk_ops tegra_clk_pllxc_ops = { .set_rate = clk_pllxc_set_rate, }; -const struct clk_ops tegra_clk_pllm_ops = { +static const struct clk_ops tegra_clk_pllm_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable, @@ -1451,7 +1451,7 @@ const struct clk_ops tegra_clk_pllm_ops = { .set_rate = clk_pllm_set_rate, }; -const struct clk_ops tegra_clk_pllc_ops = { +static const struct clk_ops tegra_clk_pllc_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pllc_enable, .disable = clk_pllc_disable, @@ -1460,7 +1460,7 @@ const struct clk_ops tegra_clk_pllc_ops = { .set_rate = clk_pllc_set_rate, }; -const struct clk_ops tegra_clk_pllre_ops = { +static const struct clk_ops tegra_clk_pllre_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable, @@ -1469,7 +1469,7 @@ const struct clk_ops tegra_clk_pllre_ops = { .set_rate = clk_pllre_set_rate, }; -const struct clk_ops tegra_clk_plle_tegra114_ops = { +static const struct clk_ops tegra_clk_plle_tegra114_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_plle_tegra114_enable, .disable = clk_plle_tegra114_disable, @@ -1731,7 +1731,7 @@ struct clk *tegra_clk_register_plle_tegra114(const char *name, #endif #ifdef CONFIG_ARCH_TEGRA_124_SOC -const struct clk_ops tegra_clk_pllss_ops = { +static const struct clk_ops tegra_clk_pllss_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable,