| Message ID | 201312200219.31121.sergei.shtylyov@cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 20, 2013 at 02:19:30AM +0300, Sergei Shtylyov wrote: > Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ > trigger type to be low-level as per the Micrel PHY driver's setup. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Hi Sergei, for better or for worse I believe this is a v3.15 candidate. Could you repost it once v3.14-rc1 has been released, I believe it will include the dependencies of this patch. Thanks
On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ > trigger type to be low-level as per the Micrel PHY driver's setup. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > 1 file changed, 4 insertions(+) Thanks for your efforts. The code looks fine. I have now also tested this on my Lager board. Acked-by: Magnus Damm <damm@opensource.se> Cheers, / magnus
On Fri, Jan 17, 2014 at 03:00:29PM +0900, Magnus Damm wrote: > On Fri, Dec 20, 2013 at 8:19 AM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ > > trigger type to be low-level as per the Micrel PHY driver's setup. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > --- > > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > Thanks for your efforts. The code looks fine. I have now also tested > this on my Lager board. > > Acked-by: Magnus Damm <damm@opensource.se> Hi Sergei, please repost this patch with Magnus's ack once an rc release is available with the pre-requisites of this patch. Thanks
Index: renesas/arch/arm/mach-shmobile/board-lager.c =================================================================== --- renesas.orig/arch/arm/mach-shmobile/board-lager.c +++ renesas/arch/arm/mach-shmobile/board-lager.c @@ -22,6 +22,7 @@ #include <linux/gpio_keys.h> #include <linux/input.h> #include <linux/interrupt.h> +#include <linux/irq.h> #include <linux/kernel.h> #include <linux/leds.h> #include <linux/mmc/host.h> @@ -228,6 +229,7 @@ static const struct resource mmcif1_reso /* Ether */ static const struct sh_eth_plat_data ether_pdata __initconst = { .phy = 0x1, + .phy_irq = irq_pin(0), .edmac_endian = EDMAC_LITTLE_ENDIAN, .phy_interface = PHY_INTERFACE_MODE_RMII, .ether_link_active_low = 1, @@ -391,6 +393,8 @@ static void __init lager_init(void) { lager_add_standard_devices(); + irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW); + if (IS_ENABLED(CONFIG_PHYLIB)) phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ trigger type to be low-level as per the Micrel PHY driver's setup. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/mach-shmobile/board-lager.c | 4 ++++ 1 file changed, 4 insertions(+)