diff mbox

[2/2] ARM: shmobile: Lager: conditionally select CONFIG_MICREL_PHY

Message ID 201312200220.54747.sergei.shtylyov@cogentembedded.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sergei Shtylyov Dec. 19, 2013, 11:20 p.m. UTC
Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/mach-shmobile/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Horman Dec. 23, 2013, 12:53 a.m. UTC | #1
On Fri, Dec 20, 2013 at 02:20:54AM +0300, Sergei Shtylyov wrote:
> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Hi Sergei,

while I am very happy to see this change unfortunately it no longer
applies. Could you please rebase it on top of
renesas-devel-v3.13-rc4-20131219?

Thanks

> 
> ---
>  arch/arm/mach-shmobile/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: renesas/arch/arm/mach-shmobile/Kconfig
> ===================================================================
> --- renesas.orig/arch/arm/mach-shmobile/Kconfig
> +++ renesas/arch/arm/mach-shmobile/Kconfig
> @@ -54,6 +54,7 @@ config MACH_KZM9D
>  config MACH_LAGER
>  	bool "Lager board"
>  	depends on ARCH_R8A7790
> +	select MICREL_PHY if SH_ETH
>  
>  comment "Renesas ARM SoCs System Configuration"
>  endif
> @@ -261,6 +262,7 @@ config MACH_LAGER
>  	bool "Lager board"
>  	depends on ARCH_R8A7790
>  	select USE_OF
> +	select MICREL_PHY if SH_ETH
>  
>  config MACH_KOELSCH
>  	bool "Koelsch board"
>
Sergei Shtylyov Dec. 23, 2013, 6:57 p.m. UTC | #2
Hello.

On 12/23/2013 03:53 AM, Simon Horman wrote:

>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we intend
>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Hi Sergei,

> while I am very happy to see this change unfortunately it no longer
> applies. Could you please rebase it on top of
> renesas-devel-v3.13-rc4-20131219?

    Hmm, it *was done* on top of this tag. Perhaps you meant today's 
renesas-devel-v3.13-rc5-20131223?

> Thanks

WBR, Sergei
Sergei Shtylyov Dec. 23, 2013, 7:08 p.m. UTC | #3
Hello.

On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:

>>> Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
>>> intend
>>> to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
>>> Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> Hi Sergei,

>> while I am very happy to see this change unfortunately it no longer
>> applies. Could you please rebase it on top of
>> renesas-devel-v3.13-rc4-20131219?

>     Hmm, it *was done* on top of this tag. Perhaps you meant today's
> renesas-devel-v3.13-rc5-20131223?

    It continues to apply even to that tag seamlessly. Some issue must be on 
your side...

>> Thanks

WBR, Sergei
Simon Horman Dec. 24, 2013, 2:55 a.m. UTC | #4
On Mon, Dec 23, 2013 at 10:08:24PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/23/2013 09:57 PM, Sergei Shtylyov wrote:
> 
> >>>Now that support for KSZ8041RNLI is added to the Micrel PHY driver and we
> >>>intend
> >>>to support PHY IRQs on the Lager board, we have to enable the Micrel driver.
> >>>Do this by selecting CONFIG_MICREL_PHY for Lager if CONFIG_SH_ETH is enabled.
> 
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>Hi Sergei,
> 
> >>while I am very happy to see this change unfortunately it no longer
> >>applies. Could you please rebase it on top of
> >>renesas-devel-v3.13-rc4-20131219?
> 
> >    Hmm, it *was done* on top of this tag. Perhaps you meant today's
> >renesas-devel-v3.13-rc5-20131223?
> 
>    It continues to apply even to that tag seamlessly. Some issue
> must be on your side...

Indeed. I have now queued up the patch.
diff mbox

Patch

Index: renesas/arch/arm/mach-shmobile/Kconfig
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/Kconfig
+++ renesas/arch/arm/mach-shmobile/Kconfig
@@ -54,6 +54,7 @@  config MACH_KZM9D
 config MACH_LAGER
 	bool "Lager board"
 	depends on ARCH_R8A7790
+	select MICREL_PHY if SH_ETH
 
 comment "Renesas ARM SoCs System Configuration"
 endif
@@ -261,6 +262,7 @@  config MACH_LAGER
 	bool "Lager board"
 	depends on ARCH_R8A7790
 	select USE_OF
+	select MICREL_PHY if SH_ETH
 
 config MACH_KOELSCH
 	bool "Koelsch board"