From patchwork Thu Jan 9 15:25:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 3461661 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0BE959F1C4 for ; Thu, 9 Jan 2014 15:26:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B1BC2013D for ; Thu, 9 Jan 2014 15:26:00 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E78C720103 for ; Thu, 9 Jan 2014 15:25:58 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W1HUD-00064i-Sz; Thu, 09 Jan 2014 15:25:34 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W1HU8-0000kk-81; Thu, 09 Jan 2014 15:25:28 +0000 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16] helo=va3outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W1HTs-0000iu-SN for linux-arm-kernel@lists.infradead.org; Thu, 09 Jan 2014 15:25:14 +0000 Received: from mail64-va3-R.bigfish.com (10.7.14.253) by VA3EHSOBE008.bigfish.com (10.7.40.28) with Microsoft SMTP Server id 14.1.225.22; Thu, 9 Jan 2014 15:24:51 +0000 Received: from mail64-va3 (localhost [127.0.0.1]) by mail64-va3-R.bigfish.com (Postfix) with ESMTP id 55C5840013D; Thu, 9 Jan 2014 15:24:51 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -1 X-BigFish: VS-1(z579eh551biz98dI1432Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6hzz1de098h1de097hz2dh87h2a8h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh2216h22d0h2336h2438h1151h1155h) X-FB-DOMAIN-IP-MATCH: fail Received: from mail64-va3 (localhost.localdomain [127.0.0.1]) by mail64-va3 (MessageSwitch) id 1389281089200400_14299; Thu, 9 Jan 2014 15:24:49 +0000 (UTC) Received: from VA3EHSMHS032.bigfish.com (unknown [10.7.14.238]) by mail64-va3.bigfish.com (Postfix) with ESMTP id 2091F36004B; Thu, 9 Jan 2014 15:24:49 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS032.bigfish.com (10.7.99.42) with Microsoft SMTP Server (TLS) id 14.16.227.3; Thu, 9 Jan 2014 15:24:46 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-004.039d.mgd.msft.net (10.84.1.14) with Microsoft SMTP Server (TLS) id 14.3.158.2; Thu, 9 Jan 2014 15:24:45 +0000 Received: from S2101-09.ap.freescale.net ([10.192.185.4]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id s09FOWdh007198; Thu, 9 Jan 2014 08:24:37 -0700 Date: Thu, 9 Jan 2014 23:25:38 +0800 From: Shawn Guo To: Russell King - ARM Linux Subject: Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support Message-ID: <20140109152536.GG21717@S2101-09.ap.freescale.net> References: <20140102212528.GD7383@n2100.arm.linux.org.uk> <20140107085930.GD12346@S2101-09.ap.freescale.net> <20140108213258.GS27432@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140108213258.GS27432@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140109_102513_011712_0F8F8DAE X-CRM114-Status: GOOD ( 21.03 ) X-Spam-Score: -3.5 (---) Cc: devel@driverdev.osuosl.org, David Airlie , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Sascha Hauer , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jan 08, 2014 at 09:32:58PM +0000, Russell King - ARM Linux wrote: > On Tue, Jan 07, 2014 at 04:59:35PM +0800, Shawn Guo wrote: > > On Thu, Jan 02, 2014 at 09:28:03PM +0000, Russell King wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > > index e75e11b36dff..0e005f21d241 100644 > > > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > > @@ -62,6 +62,12 @@ > > > }; > > > }; > > > > > > + imx-drm { > > > + compatible = "fsl,imx-drm"; > > > + crtcs = <&ipu1 0>, <&ipu1 1>; > > > + connectors = <&ldb>; > > > + }; > > > + > > > > While the change works fine on imx6dl, it breaks LVDS support on imx6q > > right away. > > > > imx-ipuv3 2400000.ipu: IPUv3H probed > > imx-ipuv3 2800000.ipu: IPUv3H probed > > [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). > > [drm] No driver support for vblank timestamp query. > > imx-drm imx-drm.16: bound imx-ipuv3-crtc.0 (ops ipu_crtc_ops) > > imx-drm imx-drm.16: bound imx-ipuv3-crtc.1 (ops ipu_crtc_ops) > > imx-drm imx-drm.16: failed to bind ldb.10 (ops imx_ldb_ops): -517 > > > > Because we have 4 crtcs for lvds-channel on imx6q while imx-drm master > > defines only 2 in there, the imx_drm_encoder_parse_of() call from > > imx_ldb_register() will always return -EPROBE_DEFER. > > > > lvds-channel@0 { > > crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>; > > }; > > > > lvds-channel@1 { > > crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>; > > }; > > This is why some help would be useful here - I think I got these right > but I've no way to check them. > > Can you confirm that adding all four is the right thing not only for > the imx6q but also the imx6dl sabresd please? Yea, adding all four into imx-drm crtcs works for imx6q, but it doesn't for imx6dl, because &ipu2 is unavailable for imx6dl at all. Here is how I get around it. ---8<----------- diff --git a/arch/arm/boot/dts/imx6q-sabresd.dts b/arch/arm/boot/dts/imx6q-sabresd.dts index 9cbdfe7..66f220a 100644 --- a/arch/arm/boot/dts/imx6q-sabresd.dts +++ b/arch/arm/boot/dts/imx6q-sabresd.dts @@ -20,6 +20,10 @@ compatible = "fsl,imx6q-sabresd", "fsl,imx6q"; }; +&imx_drm { + crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>; +}; + &sata { status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 0e005f2..dfca3e0 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -62,7 +62,7 @@ }; }; - imx-drm { + imx_drm: imx-drm { compatible = "fsl,imx-drm"; crtcs = <&ipu1 0>, <&ipu1 1>; connectors = <&ldb>;