| Message ID | 201402282115.55948.arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Arnd Bergmann <arnd@arndb.de> writes: > On Friday 28 February 2014, Kevin Hilman wrote: >> On Tue, Feb 11, 2014 at 1:11 PM, Rob Herring <robherring2@gmail.com> wrote: >> > From: Rob Herring <robh@kernel.org> >> > >> > Multi-platform requires various kconfig options to be selected, so >> > platforms don't need to select them individually. >> > >> > Signed-off-by: Rob Herring <robh@kernel.org> >> > Cc: Linus Walleij <linus.walleij@linaro.org> >> > Cc: Russell King <linux@arm.linux.org.uk> >> >> FYI... this recently hit arm-soc/for-next and according to my bisect, >> is the cause for two new boot failures[1] for sunxi_defconfig on >> cubieboard and cubie2. The previous build/boot passed on both >> boards[2]. Interestingly, both boards boot fine with >> multi_v7_defconfig though. >> >> There's zero console output on the boards, and I haven't dug further >> since I still have to pack for a trip tomorrow. >> >> Kevin >> >> [1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-February/002615.html >> [2] http://lists.linaro.org/pipermail/kernel-build-reports/2014-February/002613.html > > I suspect we want this one: > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 7d1588e..cf35d18 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -304,6 +304,7 @@ config ARCH_MULTIPLATFORM > bool "Allow multiple platforms to be selected" > select ARCH_WANT_OPTIONAL_GPIOLIB > select AUTO_ZRELADDR > + select CLKSRC_OF > select COMMON_CLK > select GENERIC_CLOCKEVENTS > select MULTI_IRQ_HANDLER Yup, that's it. With that, sunxi_defconfig is booting again. Tested-by: Kevin Hilman <khilman@linaro.org>
On Friday 28 February 2014, Kevin Hilman wrote: > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 7d1588e..cf35d18 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -304,6 +304,7 @@ config ARCH_MULTIPLATFORM > > bool "Allow multiple platforms to be selected" > > select ARCH_WANT_OPTIONAL_GPIOLIB > > select AUTO_ZRELADDR > > + select CLKSRC_OF > > select COMMON_CLK > > select GENERIC_CLOCKEVENTS > > select MULTI_IRQ_HANDLER > > Yup, that's it. With that, sunxi_defconfig is booting again. > > Tested-by: Kevin Hilman <khilman@linaro.org> I've added this patch on the *for-next* branch for now, while we still decide whether it is the correct solution. The alternative would be to only select it from the clocksource drivers that want it. Arnd
On Fri, 2014-02-28 at 21:33, Arnd Bergmann wrote: > On Friday 28 February 2014, Kevin Hilman wrote: > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > > index 7d1588e..cf35d18 100644 > > > --- a/arch/arm/Kconfig > > > +++ b/arch/arm/Kconfig > > > @@ -304,6 +304,7 @@ config ARCH_MULTIPLATFORM > > > bool "Allow multiple platforms to be selected" > > > select ARCH_WANT_OPTIONAL_GPIOLIB > > > select AUTO_ZRELADDR > > > + select CLKSRC_OF > > > select COMMON_CLK > > > select GENERIC_CLOCKEVENTS > > > select MULTI_IRQ_HANDLER > > > > Yup, that's it. With that, sunxi_defconfig is booting again. > > > > Tested-by: Kevin Hilman <khilman@linaro.org> > > I've added this patch on the *for-next* branch for now, while we > still decide whether it is the correct solution. The alternative > would be to only select it from the clocksource drivers that want I see the same lockup with v3.15-rc1 on an imx233 board (olinuxino nano) and this patch also fixes the issues I see. Tested-by: Daniel Willmann <daniel@totalueberwachung.de> Regards, Daniel Willmann
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 7d1588e..cf35d18 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -304,6 +304,7 @@ config ARCH_MULTIPLATFORM bool "Allow multiple platforms to be selected" select ARCH_WANT_OPTIONAL_GPIOLIB select AUTO_ZRELADDR + select CLKSRC_OF select COMMON_CLK select GENERIC_CLOCKEVENTS select MULTI_IRQ_HANDLER