From patchwork Fri Apr 25 13:08:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Pargmann X-Patchwork-Id: 4062221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4FF12BFF02 for ; Fri, 25 Apr 2014 13:11:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 702F02037F for ; Fri, 25 Apr 2014 13:11:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AB3F2037D for ; Fri, 25 Apr 2014 13:11:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wdfsc-0006gb-Ac; Fri, 25 Apr 2014 13:09:26 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WdfsZ-0006R8-3Q for linux-arm-kernel@lists.infradead.org; Fri, 25 Apr 2014 13:09:24 +0000 Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1Wdfs2-0006iF-Tb; Fri, 25 Apr 2014 15:08:50 +0200 Received: from mpa by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1Wdfs1-0006g8-Lq; Fri, 25 Apr 2014 15:08:49 +0200 Date: Fri, 25 Apr 2014 15:08:49 +0200 From: Markus Pargmann To: Russell King - ARM Linux Subject: Re: [PATCH 21/38] mmc: sdhci: hack up driver to make it more compliant with UHS-1 Message-ID: <20140425130849.GB15179@pengutronix.de> References: <20140423185534.GA26756@n2100.arm.linux.org.uk> <20140425123820.GA15179@pengutronix.de> <20140425124945.GM26756@n2100.arm.linux.org.uk> MIME-Version: 1.0 In-Reply-To: <20140425124945.GM26756@n2100.arm.linux.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:59:33 up 2 days, 6:30, 35 users, load average: 0.05, 0.06, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140425_060923_604083_6FEC724D X-CRM114-Status: GOOD ( 23.73 ) X-Spam-Score: -0.7 (/) Cc: Ulf Hansson , linux-mmc@vger.kernel.org, Chris Ball , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Apr 25, 2014 at 01:49:45PM +0100, Russell King - ARM Linux wrote: > On Fri, Apr 25, 2014 at 02:38:20PM +0200, Markus Pargmann wrote: > > Hi, > > > > On Wed, Apr 23, 2014 at 08:07:57PM +0100, Russell King wrote: > > > Patch suggested by Dong Aisheng , this avoids > > > additional clock start/stop cycles during the transition to 1.8V > > > signalling mode. > > > > > > Signed-off-by: Russell King > > > > I tested the series on imx6s with a RIoT board. With this patch applied > > the RIoT board emmc does not work. Here is the output of the board: > > Unfortunately, I don't have any emmc sdhci using devices, so this is > a combination I can't test myself. > > What would be useful is to find out which of the two changes in there > is the cause - can you try with just the change to > sdhci_do_start_signal_voltage_switch applied, iow just this change: I just tried the different parts of the patch. Without the following change, emmc works: Markus --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1507,12 +1507,6 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) host->ops->set_clock(host, host->clock); } - - /* Reset SD Clock Enable */ - clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL); - clk &= ~SDHCI_CLOCK_CARD_EN; - sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); - Regards,