| Message ID | 201405060245.32952.sergei.shtylyov@cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 06, 2014 at 02:45:31AM +0400, Sergei Shtylyov wrote: > Define the Henninger board dependent part of the QSPI device node. > Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's > 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. > > arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) Thanks, I have queued this up.
Hello. On 05/06/2014 02:45 AM, Sergei Shtylyov wrote: > Define the Henninger board dependent part of the QSPI device node. > Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- > This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's > 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. > arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts > +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts [...] > @@ -158,3 +163,36 @@ > cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > + > +&qspi { > + pinctrl-0 = <&qspi_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "spansion,s25fl512s"; > + reg = <0>; > + spi-max-frequency = <30000000>; > + spi-tx-bus-width = <4>; > + spi-rx-bus-width = <4>; > + m25p,fast-read; > + > + partition@0 { > + label = "loader_prg"; > + reg = <0x00000000 0x00040000>; > + read-only; > + }; > + partition@40000 { > + label = "user_prg"; > + reg = <0x00040000 0x00400000>; > + read-only; Oops, there shouldn't be "read-only" here, I forgot to refresh the patch as I'm now seeing... too bad it's too late to resend now. :-( WBR, Sergei
On Sun, May 11, 2014 at 10:17:27PM +0400, Sergei Shtylyov wrote: > Hello. > > On 05/06/2014 02:45 AM, Sergei Shtylyov wrote: > > >Define the Henninger board dependent part of the QSPI device node. > >Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. > > >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >--- > >This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's > >'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. > > > arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > >Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts > >=================================================================== > >--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts > >+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts > [...] > >@@ -158,3 +163,36 @@ > > cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; > > status = "okay"; > > }; > >+ > >+&qspi { > >+ pinctrl-0 = <&qspi_pins>; > >+ pinctrl-names = "default"; > >+ > >+ status = "okay"; > >+ > >+ flash@0 { > >+ #address-cells = <1>; > >+ #size-cells = <1>; > >+ compatible = "spansion,s25fl512s"; > >+ reg = <0>; > >+ spi-max-frequency = <30000000>; > >+ spi-tx-bus-width = <4>; > >+ spi-rx-bus-width = <4>; > >+ m25p,fast-read; > >+ > >+ partition@0 { > >+ label = "loader_prg"; > >+ reg = <0x00000000 0x00040000>; > >+ read-only; > >+ }; > >+ partition@40000 { > >+ label = "user_prg"; > >+ reg = <0x00040000 0x00400000>; > >+ read-only; > > Oops, there shouldn't be "read-only" here, I forgot to refresh > the patch as I'm now seeing... too bad it's too late to resend now. > :-( Could you send an incremental fix for me to queue up?
Hello. On 05/12/2014 02:53 AM, Simon Horman wrote: >>> Define the Henninger board dependent part of the QSPI device node. >>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>> --- >>> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's >>> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. >>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts >>> =================================================================== >>> --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts >>> +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts >> [...] >>> @@ -158,3 +163,36 @@ >>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; >>> status = "okay"; >>> }; >>> + >>> +&qspi { >>> + pinctrl-0 = <&qspi_pins>; >>> + pinctrl-names = "default"; >>> + >>> + status = "okay"; >>> + >>> + flash@0 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + compatible = "spansion,s25fl512s"; >>> + reg = <0>; >>> + spi-max-frequency = <30000000>; >>> + spi-tx-bus-width = <4>; >>> + spi-rx-bus-width = <4>; >>> + m25p,fast-read; >>> + >>> + partition@0 { >>> + label = "loader_prg"; >>> + reg = <0x00000000 0x00040000>; >>> + read-only; >>> + }; >>> + partition@40000 { >>> + label = "user_prg"; >>> + reg = <0x00040000 0x00400000>; >>> + read-only; >> Oops, there shouldn't be "read-only" here, I forgot to refresh >> the patch as I'm now seeing... too bad it's too late to resend now. >> :-( > Could you send an incremental fix for me to queue up? Yes, I will. WBR, Sergei
Hello. On 05/12/2014 02:53 AM, Simon Horman wrote: >>> Define the Henninger board dependent part of the QSPI device node. >>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>> --- >>> This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's >>> 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. >>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts >>> =================================================================== >>> --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts >>> +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts >> [...] >>> @@ -158,3 +163,36 @@ >>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; >>> status = "okay"; >>> }; >>> + >>> +&qspi { >>> + pinctrl-0 = <&qspi_pins>; >>> + pinctrl-names = "default"; >>> + >>> + status = "okay"; >>> + >>> + flash@0 { >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + compatible = "spansion,s25fl512s"; >>> + reg = <0>; >>> + spi-max-frequency = <30000000>; >>> + spi-tx-bus-width = <4>; >>> + spi-rx-bus-width = <4>; >>> + m25p,fast-read; >>> + >>> + partition@0 { >>> + label = "loader_prg"; >>> + reg = <0x00000000 0x00040000>; >>> + read-only; >>> + }; >>> + partition@40000 { >>> + label = "user_prg"; >>> + reg = <0x00040000 0x00400000>; >>> + read-only; >> Oops, there shouldn't be "read-only" here, I forgot to refresh >> the patch as I'm now seeing... too bad it's too late to resend now. >> :-( > Could you send an incremental fix for me to queue up? Oops, I've rechecked and it should indeed be read-only, so the patch was correct. Sorry. :-) WBR, Sergei
On Tue, May 13, 2014 at 02:57:30AM +0400, Sergei Shtylyov wrote: > Hello. > > On 05/12/2014 02:53 AM, Simon Horman wrote: > > >>>Define the Henninger board dependent part of the QSPI device node. > >>>Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. > > >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >>>--- > >>>This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's > >>>'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. > > >>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ > >>> 1 file changed, 38 insertions(+) > > >>>Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts > >>>=================================================================== > >>>--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts > >>>+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts > >>[...] > >>>@@ -158,3 +163,36 @@ > >>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; > >>> status = "okay"; > >>> }; > >>>+ > >>>+&qspi { > >>>+ pinctrl-0 = <&qspi_pins>; > >>>+ pinctrl-names = "default"; > >>>+ > >>>+ status = "okay"; > >>>+ > >>>+ flash@0 { > >>>+ #address-cells = <1>; > >>>+ #size-cells = <1>; > >>>+ compatible = "spansion,s25fl512s"; > >>>+ reg = <0>; > >>>+ spi-max-frequency = <30000000>; > >>>+ spi-tx-bus-width = <4>; > >>>+ spi-rx-bus-width = <4>; > >>>+ m25p,fast-read; > >>>+ > >>>+ partition@0 { > >>>+ label = "loader_prg"; > >>>+ reg = <0x00000000 0x00040000>; > >>>+ read-only; > >>>+ }; > >>>+ partition@40000 { > >>>+ label = "user_prg"; > >>>+ reg = <0x00040000 0x00400000>; > >>>+ read-only; > > >> Oops, there shouldn't be "read-only" here, I forgot to refresh > >>the patch as I'm now seeing... too bad it's too late to resend now. > >>:-( > > >Could you send an incremental fix for me to queue up? > > Oops, I've rechecked and it should indeed be read-only, so the > patch was correct. Sorry. :-) Thanks for double checking. I think we can safely do nothing for now :-)
Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts +++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts @@ -109,6 +109,11 @@ renesas,groups = "sdhi2_data4", "sdhi2_ctrl"; renesas,function = "sdhi2"; }; + + qspi_pins: spi0 { + renesas,groups = "qspi_ctrl", "qspi_data4"; + renesas,function = "qspi"; + }; }; &scif0 { @@ -158,3 +163,36 @@ cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>; status = "okay"; }; + +&qspi { + pinctrl-0 = <&qspi_pins>; + pinctrl-names = "default"; + + status = "okay"; + + flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "spansion,s25fl512s"; + reg = <0>; + spi-max-frequency = <30000000>; + spi-tx-bus-width = <4>; + spi-rx-bus-width = <4>; + m25p,fast-read; + + partition@0 { + label = "loader_prg"; + reg = <0x00000000 0x00040000>; + read-only; + }; + partition@40000 { + label = "user_prg"; + reg = <0x00040000 0x00400000>; + read-only; + }; + partition@440000 { + label = "flash_fs"; + reg = <0x00440000 0x03bc0000>; + }; + }; +};
Define the Henninger board dependent part of the QSPI device node. Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's 'renesas.git' repo and SDHI0/2 DT support patch posted last weekend. arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)