From patchwork Tue Jul 8 01:09:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minchan Kim X-Patchwork-Id: 4501561 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E56A59F1C4 for ; Tue, 8 Jul 2014 01:12:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBEB5202A1 for ; Tue, 8 Jul 2014 01:12:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9604F202F0 for ; Tue, 8 Jul 2014 01:12:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X4Jv2-0007Lr-95; Tue, 08 Jul 2014 01:10:04 +0000 Received: from lgeamrelo02.lge.com ([156.147.1.126]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X4Jux-0006ta-Rz for linux-arm-kernel@lists.infradead.org; Tue, 08 Jul 2014 01:10:01 +0000 Received: from unknown (HELO localhost) (10.177.220.169) by 156.147.1.126 with ESMTP; 8 Jul 2014 10:09:28 +0900 X-Original-SENDERIP: 10.177.220.169 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 8 Jul 2014 10:09:36 +0900 From: Minchan Kim To: Steve Capper Subject: Re: [PATCH v10 6/7] ARM: add pmd_[dirty|mkclean] for THP Message-ID: <20140708010936.GC6076@bbox> References: <1404694438-10272-1-git-send-email-minchan@kernel.org> <1404694438-10272-7-git-send-email-minchan@kernel.org> <20140707092247.GA15168@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140707092247.GA15168@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140707_181000_425738_AEC6B81B X-CRM114-Status: GOOD ( 23.73 ) X-Spam-Score: -0.0 (/) Cc: Jason Evans , Rik van Riel , Catalin Marinas , Linux API , Hugh Dickins , linux-kernel@vger.kernel.org, Will Deacon , Russell King , linux-mm@kvack.org, Zhang Yanfei , Michael Kerrisk , KOSAKI Motohiro , Johannes Weiner , "Kirill A. Shutemov" , Andrew Morton , linux-arm-kernel@lists.infradead.org, Mel Gorman X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jul 07, 2014 at 10:22:48AM +0100, Steve Capper wrote: > On Mon, Jul 07, 2014 at 09:53:57AM +0900, Minchan Kim wrote: > > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > > overwrite of the contents since MADV_FREE syscall is called for > > THP page. > > > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > > support. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Steve Capper > > Cc: Russell King > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Minchan Kim > > --- > > arch/arm64/include/asm/pgtable.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > > index 579702086488..f3ec01cef04f 100644 > > --- a/arch/arm64/include/asm/pgtable.h > > +++ b/arch/arm64/include/asm/pgtable.h > > @@ -240,10 +240,12 @@ static inline pmd_t pte_pmd(pte_t pte) > > #endif > > > > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > > #define pmd_mksplitting(pmd) pte_pmd(pte_mkspecial(pmd_pte(pmd))) > > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > > #define pmd_mknotpresent(pmd) (__pmd(pmd_val(pmd) & ~PMD_TYPE_MASK)) > > -- > > 2.0.0 > > > > Hi Minchan, Hello Steve and Will, > > This looks good to me too. > As Will said this applies to arm64, we will also need a version for: > arch/arm/include/asm/pgtable-3level.h. Does it work? diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h index 85c60adc8b60..3a7bb8dc7d05 100644 --- a/arch/arm/include/asm/pgtable-3level.h +++ b/arch/arm/include/asm/pgtable-3level.h @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) #endif +#define pmd_dirty (pmd_val(pmd) & PMD_SECT_DIRTY) + #define PMD_BIT_FUNC(fn,op) \ static inline pmd_t pmd_##fn(pmd_t pmd) { pmd_val(pmd) op; return pmd; } @@ -228,6 +230,7 @@ PMD_BIT_FUNC(mkold, &= ~PMD_SECT_AF); PMD_BIT_FUNC(mksplitting, |= PMD_SECT_SPLITTING); PMD_BIT_FUNC(mkwrite, &= ~PMD_SECT_RDONLY); PMD_BIT_FUNC(mkdirty, |= PMD_SECT_DIRTY); +PMD_BIT_FUNC(mkclean, &= ~PMD_SECT_DIRTY); PMD_BIT_FUNC(mkyoung, |= PMD_SECT_AF); #define pmd_mkhuge(pmd) (__pmd(pmd_val(pmd) & ~PMD_TABLE_BIT))