| Message ID | 20140805144840.25462.57101.stgit@localhost (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 05, 2014 at 03:48:40PM +0100, Martin Fuzzey wrote: > Add device tree node for PMU on i.MX53 > > Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com> > --- > arch/arm/boot/dts/imx53.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > index 6456a00..ab3afe0 100644 > --- a/arch/arm/boot/dts/imx53.dtsi > +++ b/arch/arm/boot/dts/imx53.dtsi > @@ -101,6 +101,11 @@ > interrupt-parent = <&tzic>; > ranges; > > + pmu { > + compatible = "arm,cortex-a8-pmu"; > + interrupts = <77>; > + }; You're missing the new property. Will
On 06/08/14 12:50, Will Deacon wrote: > On Tue, Aug 05, 2014 at 03:48:40PM +0100, Martin Fuzzey wrote: >> Add device tree node for PMU on i.MX53 >> >> Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com> >> --- >> arch/arm/boot/dts/imx53.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi >> index 6456a00..ab3afe0 100644 >> --- a/arch/arm/boot/dts/imx53.dtsi >> +++ b/arch/arm/boot/dts/imx53.dtsi >> @@ -101,6 +101,11 @@ >> interrupt-parent = <&tzic>; >> ranges; >> >> + pmu { >> + compatible = "arm,cortex-a8-pmu"; >> + interrupts = <77>; >> + }; > You're missing the new property. Actually this was deliberate. Since the property should only be used if booting in secure mode this generic dtsi file can't know if it is ok or not. I presume a (probably out of tree) board / application dts file will add the property. Maybe I should put a comment here about that though? Martin
On Wed, Aug 06, 2014 at 03:35:49PM +0200, Martin Fuzzey wrote: > On 06/08/14 12:50, Will Deacon wrote: > >On Tue, Aug 05, 2014 at 03:48:40PM +0100, Martin Fuzzey wrote: > >>Add device tree node for PMU on i.MX53 > >> > >>Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com> > >>--- > >> arch/arm/boot/dts/imx53.dtsi | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >>diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi > >>index 6456a00..ab3afe0 100644 > >>--- a/arch/arm/boot/dts/imx53.dtsi > >>+++ b/arch/arm/boot/dts/imx53.dtsi > >>@@ -101,6 +101,11 @@ > >> interrupt-parent = <&tzic>; > >> ranges; > >>+ pmu { > >>+ compatible = "arm,cortex-a8-pmu"; > >>+ interrupts = <77>; > >>+ }; > >You're missing the new property. > > Actually this was deliberate. > > Since the property should only be used if booting in secure mode > this generic dtsi file can't know if it is ok or not. As far as I know, most of the i.MX53 systems boot Linux kernel in secure mode. In that case, we should probably have the new property by default? Shawn > I presume a (probably out of tree) board / application dts file will > add the property. > > Maybe I should put a comment here about that though? > > Martin
On 07/08/14 07:53, Shawn Guo wrote: > On Wed, Aug 06, 2014 at 03:35:49PM +0200, Martin Fuzzey wrote: >> On 06/08/14 12:50, Will Deacon wrote: >>> >>> You're missing the new property. >> Actually this was deliberate. >> >> Since the property should only be used if booting in secure mode >> this generic dtsi file can't know if it is ok or not. > As far as I know, most of the i.MX53 systems boot Linux kernel in secure > mode. In that case, we should probably have the new property by > default? Is it possible to override a boolean property to remove it (set to false) in a board specific dts? If it can be done then yes I agree it should be the default. However seeing as the dts syntax doesn't give a value for boolean properties I don't see how. But I don't think people booting non secure should have to modify imx53.dtsi Martin
On Thu, Aug 07, 2014 at 10:00:08AM +0200, Martin Fuzzey wrote: > On 07/08/14 07:53, Shawn Guo wrote: > >On Wed, Aug 06, 2014 at 03:35:49PM +0200, Martin Fuzzey wrote: > >>On 06/08/14 12:50, Will Deacon wrote: > >>> > >>>You're missing the new property. > >>Actually this was deliberate. > >> > >>Since the property should only be used if booting in secure mode > >>this generic dtsi file can't know if it is ok or not. > >As far as I know, most of the i.MX53 systems boot Linux kernel in secure > >mode. In that case, we should probably have the new property by > >default? > > Is it possible to override a boolean property to remove it (set to > false) in a board specific dts? > > If it can be done then yes I agree it should be the default. > > However seeing as the dts syntax doesn't give a value for boolean > properties I don't see how. > > But I don't think people booting non secure should have to modify imx53.dtsi Ah, yes. I missed the fact that the property is a boolean. Shawn
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index 6456a00..ab3afe0 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -101,6 +101,11 @@ interrupt-parent = <&tzic>; ranges; + pmu { + compatible = "arm,cortex-a8-pmu"; + interrupts = <77>; + }; + sata: sata@10000000 { compatible = "fsl,imx53-ahci"; reg = <0x10000000 0x1000>;
Add device tree node for PMU on i.MX53 Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com> --- arch/arm/boot/dts/imx53.dtsi | 5 +++++ 1 file changed, 5 insertions(+)