From patchwork Mon Oct 27 17:08:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 5163791 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3C24E9F318 for ; Mon, 27 Oct 2014 17:11:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56D1820211 for ; Mon, 27 Oct 2014 17:11:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 069372017E for ; Mon, 27 Oct 2014 17:11:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xinn7-0002dJ-5g; Mon, 27 Oct 2014 17:09:13 +0000 Received: from bear.ext.ti.com ([192.94.94.41]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xinn3-0002WI-DW for linux-arm-kernel@lists.infradead.org; Mon, 27 Oct 2014 17:09:10 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9RH8R9V023079; Mon, 27 Oct 2014 12:08:27 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9RH8RDV003806; Mon, 27 Oct 2014 12:08:27 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Mon, 27 Oct 2014 12:08:26 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9RH8PCl014023; Mon, 27 Oct 2014 12:08:26 -0500 Date: Mon, 27 Oct 2014 12:08:06 -0500 From: Felipe Balbi To: Heiko =?iso-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Message-ID: <20141027170806.GL14253@saruman> References: <1414427215-14380-1-git-send-email-romain.perier@gmail.com> <20141027164103.GD2006@localhost> <20141027164741.GJ14253@saruman> <108805117.sS9iL5zouT@diego> MIME-Version: 1.0 In-Reply-To: <108805117.sS9iL5zouT@diego> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141027_100909_552628_181DC189 X-CRM114-Status: GOOD ( 26.27 ) X-Spam-Score: -5.6 (-----) Cc: mark.rutland@arm.com, swarren@wwwdotorg.org, lgirdwood@gmail.com, thierry.reding@gmail.com, lee.jones@linaro.org, robh@kernel.org, linux@arm.linux.org.uk, linux-pm@vger.kernel.org, grant.likely@linaro.org, linux@roeck-us.net, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Johan Hovold , robh+dt@kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@ti.com, broonie@kernel.org, galak@codeaurora.org, Romain Perier , gnurou@gmail.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: balbi@ti.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Oct 27, 2014 at 06:05:35PM +0100, Heiko Stübner wrote: > Am Montag, 27. Oktober 2014, 11:47:41 schrieb Felipe Balbi: > > On Mon, Oct 27, 2014 at 05:41:03PM +0100, Johan Hovold wrote: > > > On Mon, Oct 27, 2014 at 11:38:40AM -0500, Felipe Balbi wrote: > > > > On Mon, Oct 27, 2014 at 04:26:46PM +0000, Romain Perier wrote: > > > > > As discussed on the mailing list, it makes more sense to rename this > > > > > property to "system-power-controller". Problem being that the word > > > > > "source" usually tends to be used for inputs and that is out of > > > > > control of the OS. The poweroff capability is an output which simply > > > > > turns the system-power off. Also, this property might be used by > > > > > drivers which power-off the system and power back on subsequent RTC > > > > > alarms. This seems to suggest to remove "poweroff" from the property > > > > > name and to choose "system-power-controller" as the more generic > > > > > name. This patchs adds the required renaming changes and defines an > > > > > helper function which is compatible with both properties, the old one > > > > > prefixed by a vendor name and the new one without any prefix. > > > > > > > > I think you still need to support poweroff-source since it has been > > > > released on a stable kernel. Perhaps add a warning message telling users > > > > it's deprecated and asking them to switch over to > > > > system-power-controller ? Still, simply removing it isn't very nice. > > > > > > No, Romain sent a patch that replaced ",system-power-controller" > > > with "poweroff-source". It's now in Mark's tree (for v3.19), and this > > > series "reverts" to the old name minus the vendor-prefix. > > > > oh, so poweroff-source isn't in Linus' tree yet ? (/me goes grep) > > > > Then it should be fine. My bad. > > > > Many of the other comments are still valid because even though > > poweroff-source isn't in mainline yet, this series still creates > > bisection points which are broken. The best solution would be to drop > > all those patches from Mark's tree. Read, not revert, drop. > > There have never been any users of the poweroff-source. The act8846 in the > radxarock would have been the first, but I held off with the dts patch as the > naming issue came up at the same time. > > So I guess if Romain keeps the renaming together there shouldn't be any other > bad bisection points? Not build breaks, but there will always be the commit below: commit a88f5c6deb2a44f694b01aac48231ec97059b26a Author: Romain Perier Date: Tue Oct 14 06:31:12 2014 +0000 dt-bindings: Document the standard property "poweroff-source" Signed-off-by: Romain Perier Signed-off-by: Mark Brown Even if for a small time frame, there will always be a commit where we called "poweroff-source" a standard binding and, as such, as should support it. diff --git a/Documentation/devicetree/bindings/power/poweroff.txt b/Documentation/devicetree/bindings/power/poweroff.txt new file mode 100644 index 0000000..845868b --- /dev/null +++ b/Documentation/devicetree/bindings/power/poweroff.txt @@ -0,0 +1,18 @@ +* Generic Poweroff capability + +Power-management integrated circuits or miscellaneous harware components are +sometimes able to control the system power. The device driver associated to these +components might needs to define poweroff capability, which tells to the kernel +how to switch off the system. The corresponding driver must have the standard +property "poweroff-source" in its device node. This property marks the device as +able to shutdown the system. In order to test if this property is found +programmatically, use the helper function "of_system_has_poweroff_source" from +of.h . + +Example: + +act8846: act8846@5 { + compatible = "active-semi,act8846"; + status = "okay"; + poweroff-source; +}