From patchwork Mon Nov 10 12:31:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5265821 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C55BD9F2ED for ; Mon, 10 Nov 2014 12:34:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0176B2015D for ; Mon, 10 Nov 2014 12:34:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1738020158 for ; Mon, 10 Nov 2014 12:34:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xno8G-0005lk-HF; Mon, 10 Nov 2014 12:31:44 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xno8D-0005gF-NN for linux-arm-kernel@lists.infradead.org; Mon, 10 Nov 2014 12:31:42 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 73CE981DD3; Mon, 10 Nov 2014 13:31:18 +0100 (CET) Date: Mon, 10 Nov 2014 13:31:18 +0100 From: Pavel Machek To: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg Subject: Tiny dts change breaks boot on n900 Message-ID: <20141110123118.GA31134@amd> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141110_043141_941543_5572F29B X-CRM114-Status: GOOD ( 15.15 ) X-Spam-Score: -2.3 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! I'm confused: This fixes boot on n900. Strange thing is ... adp1653 driver is not even compiled in -- it is module. It looks like tiny change in dts noone should care about breaks boot... I don't even have adp1653 device parsing code written. Something similar happened before -- change in device tree order broke boot. Any ideas? What is going on? Pavel diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index f3118bf..557a19e 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -565,11 +565,6 @@ adp1653: adp1653@30 { compatible = "ad,adp1653"; reg = <0x30>; - - max-flash-timeout-usec = <500000>; - max-flash-intensity-mA = <0>; - max-torch-intensity-mA = <0>; - max-indicator-intensity-uA = <0>; }; };