From patchwork Sat Dec 27 19:40:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5544861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1B2D49F1C6 for ; Sat, 27 Dec 2014 21:38:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1D40F20173 for ; Sat, 27 Dec 2014 21:38:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EC292015A for ; Sat, 27 Dec 2014 21:38:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y4xEc-0004EC-EK; Sat, 27 Dec 2014 19:41:10 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y4xEZ-0004A1-CG for linux-arm-kernel@lists.infradead.org; Sat, 27 Dec 2014 19:41:08 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 0DD4E81B8B; Sat, 27 Dec 2014 20:40:45 +0100 (CET) Date: Sat, 27 Dec 2014 20:40:45 +0100 From: Pavel Machek To: Sebastian Reichel Subject: Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor Message-ID: <20141227194045.GD10007@amd> References: <20141226102933.GA28778@amd> <1419597294-21487-1-git-send-email-sre@kernel.org> <1419597294-21487-3-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1419597294-21487-3-git-send-email-sre@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141227_114107_807027_EE074621 X-CRM114-Status: GOOD ( 20.17 ) X-Spam-Score: -2.3 (--) Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Tony Lindgren , Kumar Gala , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Rob Herring , Jean Delvare , =?iso-8859-1?Q?Beno=EEt?= Cousson , Pali Rohar , Mark Rutland , linux-omap@vger.kernel.org, Guenter Roeck X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri 2014-12-26 13:34:53, Sebastian Reichel wrote: > OMAP34xx and OMAP36xx processors contain a register in the syscon area, > which can be used to determine the SoCs temperature. This patch provides > a DT based driver for the temperature sensor based on an older driver > written by Peter De Schrijver for the Nokia N900 and N9. > > Signed-off-by: Sebastian Reichel I'd suggest these cleanups... But I don't see why it would fail. (Aha, and sorry for trailing whitespace, you'll probably need to delete it.) Signed-off-by: Pavel Machek diff --git a/drivers/hwmon/omap3-temp.c b/drivers/hwmon/omap3-temp.c index afe1b5a..8a69604 100644 --- a/drivers/hwmon/omap3-temp.c +++ b/drivers/hwmon/omap3-temp.c @@ -35,21 +35,29 @@ /* 32.768Khz clock speed in nano seconds */ #define CLOCK_32K_SPEED_NS 30518 -/* minimum delay for EOCZ rise after SOC rise is - * 11 cycles of the 32.768Khz clock */ +/* + * minimum delay for EOCZ rise after SOC rise is + * 11 cycles of the 32.768Khz clock + */ #define EOCZ_MIN_RISING_DELAY (11 * CLOCK_32K_SPEED_NS) -/* From docs, maximum delay for EOCZ rise after SOC rise is +/* + * From docs, maximum delay for EOCZ rise after SOC rise is * 14 cycles of the 32.768Khz clock. But after some experiments, - * 24 cycles as maximum is safer. */ + * 24 cycles as maximum is safer. + */ #define EOCZ_MAX_RISING_DELAY (24 * CLOCK_32K_SPEED_NS) -/* minimum delay for EOCZ falling is - * 36 cycles of the 32.768Khz clock */ +/* + * minimum delay for EOCZ falling is + * 36 cycles of the 32.768Khz clock + */ #define EOCZ_MIN_FALLING_DELAY (36 * CLOCK_32K_SPEED_NS) -/* maximum delay for EOCZ falling is - * 40 cycles of the 32.768Khz clock */ +/* + * maximum delay for EOCZ falling is + * 40 cycles of the 32.768Khz clock + */ #define EOCZ_MAX_FALLING_DELAY (40 * CLOCK_32K_SPEED_NS) /* temperature register offset in the syscon register area */ @@ -116,8 +124,8 @@ struct omap3_temp_data { bool valid; }; -static inline u32 wait_for_eocz(int min_delay, int max_delay, u32 level, - struct omap3_temp_data *data) +static inline bool wait_for_eocz(struct omap3_temp_data *data, + int min_delay, int max_delay, u32 level) { ktime_t timeout, expire; u32 temp_sensor_reg, eocz_mask; @@ -133,10 +141,10 @@ static inline u32 wait_for_eocz(int min_delay, int max_delay, u32 level, do { regmap_read(data->syscon, SYSCON_TEMP_REG, &temp_sensor_reg); if ((temp_sensor_reg & eocz_mask) == level) - break; + return true; } while (ktime_us_delta(expire, ktime_get()) > 0); - return (temp_sensor_reg & eocz_mask) == level; + return false; } static int omap3_temp_update(struct omap3_temp_data *data) @@ -153,16 +161,16 @@ static int omap3_temp_update(struct omap3_temp_data *data) regmap_update_bits(data->syscon, SYSCON_TEMP_REG, soc_mask, soc_mask); - if (!wait_for_eocz(EOCZ_MIN_RISING_DELAY, - EOCZ_MAX_RISING_DELAY, 1, data)) { + if (!wait_for_eocz(data, EOCZ_MIN_RISING_DELAY, + EOCZ_MAX_RISING_DELAY, 1)) { e = -EIO; goto err; } regmap_update_bits(data->syscon, SYSCON_TEMP_REG, soc_mask, 0); - if (!wait_for_eocz(EOCZ_MIN_FALLING_DELAY, - EOCZ_MAX_FALLING_DELAY, 0, data)) { + if (!wait_for_eocz(data, EOCZ_MIN_FALLING_DELAY, + EOCZ_MAX_FALLING_DELAY, 0)) { e = -EIO; goto err; }