| Message ID | 20150106015210.27249.91222.stgit@dusk.lan (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Paul, On Tue, Jan 06, 2015 at 01:52:15AM +0000, Paul Walmsley wrote: > On next-20150105, defconfig compilation breaks with: > > ./arch/arm64/include/asm/arch_timer.h:112:2: error: implicit declaration of function ‘BUG’ [-Werror=implicit-function-declaration] > > Fix by including linux/bug.h, where the BUG macro is defined. > > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Paul Walmsley <pwalmsley@nvidia.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > arch/arm64/include/asm/arch_timer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h > index b1fa4e614718..779455564c9a 100644 > --- a/arch/arm64/include/asm/arch_timer.h > +++ b/arch/arm64/include/asm/arch_timer.h > @@ -23,6 +23,7 @@ > > #include <linux/init.h> > #include <linux/types.h> > +#include <linux/bug.h> Nit: could you move this above the include of linux/init.h so as to keep these in alphabetical order? Otherwise: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark. > > #include <clocksource/arm_arch_timer.h> > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h index b1fa4e614718..779455564c9a 100644 --- a/arch/arm64/include/asm/arch_timer.h +++ b/arch/arm64/include/asm/arch_timer.h @@ -23,6 +23,7 @@ #include <linux/init.h> #include <linux/types.h> +#include <linux/bug.h> #include <clocksource/arm_arch_timer.h>
On next-20150105, defconfig compilation breaks with: ./arch/arm64/include/asm/arch_timer.h:112:2: error: implicit declaration of function ‘BUG’ [-Werror=implicit-function-declaration] Fix by including linux/bug.h, where the BUG macro is defined. Signed-off-by: Paul Walmsley <paul@pwsan.com> Cc: Paul Walmsley <pwalmsley@nvidia.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> --- arch/arm64/include/asm/arch_timer.h | 1 + 1 file changed, 1 insertion(+)