Message ID | 20150112134611.GF16706@leverpostej (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, Jan 12, 2015 at 01:46:11PM +0000, Mark Rutland wrote: > On Mon, Jan 12, 2015 at 12:29:44PM +0000, Mark Brown wrote: > > Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables) > > allmodconfig has failed to build on arm64 as a result of: > > > > ../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function) > > When I build a v3.19-rc4 allmodconfig, I don't see this failure, but I > agree that we need the explicit include for PCI_IOBASE. It's one of the failures in -next, but it didn't get resolved by Paul's series unfortunately (I probably just did a defconfig build for that). Will
On Mon, Jan 12, 2015 at 01:46:11PM +0000, Mark Rutland wrote: > I see that for other definitions we include the asm headers rather than > linux headers, and we also seem to be missing an include of asm/memory.h > for MODULES_VADDR and PAGE_OFFSET. > Does the below work for you? Should do.
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c index cf33f33..88f9ad9 100644 --- a/arch/arm64/mm/dump.c +++ b/arch/arm64/mm/dump.c @@ -19,7 +19,9 @@ #include <linux/sched.h> #include <linux/seq_file.h> +#include <asm/io.h> #include <asm/fixmap.h> +#include <asm/memory.h> #include <asm/pgtable.h> #define LOWEST_ADDR (UL(0xffffffffffffffff) << VA_BITS)