From patchwork Mon Jan 12 13:46:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 5610591 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 95AF79F357 for ; Mon, 12 Jan 2015 13:49:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CA1D520646 for ; Mon, 12 Jan 2015 13:49:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F12B720642 for ; Mon, 12 Jan 2015 13:49:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAfKk-0003dK-Rg; Mon, 12 Jan 2015 13:47:06 +0000 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YAfKb-0003Gr-At for linux-arm-kernel@lists.infradead.org; Mon, 12 Jan 2015 13:46:57 +0000 Received: from foss-smtp-na-1.foss.arm.com (unknown [10.80.61.8]) by foss-mx-na.foss.arm.com (Postfix) with ESMTP id 07BC2217; Mon, 12 Jan 2015 07:46:29 -0600 (CST) Received: from collaborate-mta1.arm.com (highbank-bc01-b06.austin.arm.com [10.112.81.134]) by foss-smtp-na-1.foss.arm.com (Postfix) with ESMTP id 817FF5FAD7; Mon, 12 Jan 2015 07:46:26 -0600 (CST) Received: from leverpostej (leverpostej.cambridge.arm.com [10.1.205.151]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 7C19213F78C; Mon, 12 Jan 2015 07:46:25 -0600 (CST) Date: Mon, 12 Jan 2015 13:46:11 +0000 From: Mark Rutland To: Mark Brown Subject: Re: [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE Message-ID: <20150112134611.GF16706@leverpostej> References: <1421065784-31708-1-git-send-email-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1421065784-31708-1-git-send-email-broonie@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150112_054657_457010_DF78896D X-CRM114-Status: GOOD ( 14.73 ) X-Spam-Score: -0.0 (/) Cc: Laura Abbott , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Steve Capper X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mark, On Mon, Jan 12, 2015 at 12:29:44PM +0000, Mark Brown wrote: > Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables) > allmodconfig has failed to build on arm64 as a result of: > > ../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function) When I build a v3.19-rc4 allmodconfig, I don't see this failure, but I agree that we need the explicit include for PCI_IOBASE. > Fix this by explicitly including io.h to ensure that a definition is > present. > > Signed-off-by: Mark Brown > --- > arch/arm64/mm/dump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c > index cf33f33333cc..258ce731c5cd 100644 > --- a/arch/arm64/mm/dump.c > +++ b/arch/arm64/mm/dump.c > @@ -14,6 +14,7 @@ > * of the License. > */ > #include > +#include > #include > #include > #include Nit: please keep includes ordered (unless there's some other include issue?). I see that for other definitions we include the asm headers rather than linux headers, and we also seem to be missing an include of asm/memory.h for MODULES_VADDR and PAGE_OFFSET. Does the below work for you? Thanks, Mark. ---->8---- diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c index cf33f33..88f9ad9 100644 --- a/arch/arm64/mm/dump.c +++ b/arch/arm64/mm/dump.c @@ -19,7 +19,9 @@ #include #include +#include #include +#include #include #define LOWEST_ADDR (UL(0xffffffffffffffff) << VA_BITS)