From patchwork Fri Feb 6 11:28:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 5789651 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D9C4FBF440 for ; Fri, 6 Feb 2015 11:31:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 12011201B4 for ; Fri, 6 Feb 2015 11:31:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D2502017D for ; Fri, 6 Feb 2015 11:31:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YJh5z-0007wp-Ql; Fri, 06 Feb 2015 11:29:11 +0000 Received: from mail-pd0-f171.google.com ([209.85.192.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YJh5y-0007st-8F; Fri, 06 Feb 2015 11:29:10 +0000 Received: by pdbfp1 with SMTP id fp1so14234636pdb.2; Fri, 06 Feb 2015 03:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=lA4i92+pa6lvX4dpxbol7YWJOVdXDkUIcMaUnDxyUdE=; b=ccaE37DvXwZdgKEijGXEk/vGYqGiA6XNu+QyoKBX21uLJFRmEjD9nJP/xmrZLU2Dqr VTVoMC2jExZrN/Uiym2uyAEai+TCfRcRBF7GnDYtGekbsPJueOeq14gHmh8ZA2rOkSJk 2uMcEYXc9NMxDcNt1YxLOUTi4WopAionfhwuO45UyxqVXBM7z0Z/LmqQoVxcoRoD+nmg ACs6GFjNsYSQCqjipnS+glKVPB2RMdxUlu9XEcEDVEFch5HggUiN4kotP18uezMDvt5m a2XzNGgfDi2H5IkADxyYDMTsVhyqB26HFeqWtOdFg9YqJvgUh7ktkt/PbA+iNCGjer5r 27wQ== X-Received: by 10.70.123.132 with SMTP id ma4mr5124466pdb.12.1423222129242; Fri, 06 Feb 2015 03:28:49 -0800 (PST) Received: from norris-Latitude-E6410 (cpe-45-48-59-37.socal.res.rr.com. [45.48.59.37]) by mx.google.com with ESMTPSA id ci17sm7800462pdb.70.2015.02.06.03.28.47 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Feb 2015 03:28:48 -0800 (PST) Date: Fri, 6 Feb 2015 03:28:45 -0800 From: Brian Norris To: Richard Weinberger Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string Message-ID: <20150206112845.GF4434@norris-Latitude-E6410> References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> <54856C75.1050309@nod.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54856C75.1050309@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150206_032910_317385_BAF619B4 X-CRM114-Status: GOOD ( 18.57 ) X-Spam-Score: -0.8 (/) Cc: linux-samsung-soc@vger.kernel.org, linux@rasmusvillemoes.dk, "kernel-janitors@vger.kernel.org" , LKML , Julia Lawall , Kukjin Kim , "linux-mtd@lists.infradead.org" , Joe Perches , David Woodhouse , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Dec 08, 2014 at 10:16:37AM +0100, Richard Weinberger wrote: > Am 08.12.2014 um 08:11 schrieb Julia Lawall: > >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > >>> index 35aef5e..0a9c41f 100644 > >>> --- a/drivers/mtd/nand/s3c2410.c > >>> +++ b/drivers/mtd/nand/s3c2410.c > >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) > >>> > >>> cpu_type = platform_get_device_id(pdev)->driver_data; > >>> > >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); > >>> + pr_debug("%s(%p)\n", __func__, pdev); > >> > >> I think we can drop the line completely. > >> We have ftrace to trace function calls... > > > > Should the "initialised ok" at the end of the function be remove as well? > > > > Will it be confusing if this cleanup is done in this function, but not in > > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > > example? > > Hmm, this driver seems to have a lot of debugging printks(). > IMHO we can remove them. > Let's see what Brain says. I'm a little late for this one, but I can apply this instead: From: Brian Norris Date: Fri, 6 Feb 2015 03:25:28 -0800 Subject: [PATCH] mtd: s3c2410: drop useless / misspelled debug prints s3c2410_nand_probe is not the name of the function. These prints have little utility, so let's just kill them. Reported-by: Julia Lawall Signed-off-by: Brian Norris --- drivers/mtd/nand/s3c2410.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 35aef5edb588..0e02be47ce1d 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -948,8 +948,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) cpu_type = platform_get_device_id(pdev)->driver_data; - pr_debug("s3c2410_nand_probe(%p)\n", pdev); - info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (info == NULL) { err = -ENOMEM; @@ -1045,7 +1043,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) s3c2410_nand_clk_set_state(info, CLOCK_SUSPEND); } - pr_debug("initialised ok\n"); return 0; exit_error: