From patchwork Wed Feb 25 11:27:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 5879251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A94E69F536 for ; Wed, 25 Feb 2015 11:29:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D6B1E20304 for ; Wed, 25 Feb 2015 11:29:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4CA220219 for ; Wed, 25 Feb 2015 11:29:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YQa8G-00010v-Ko; Wed, 25 Feb 2015 11:28:00 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YQa8A-0000uh-J4 for linux-arm-kernel@lists.infradead.org; Wed, 25 Feb 2015 11:27:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44AAC2A; Wed, 25 Feb 2015 03:27:46 -0800 (PST) Received: from red-moon (red-moon.cambridge.arm.com [10.1.203.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADEF43F251; Wed, 25 Feb 2015 03:27:31 -0800 (PST) Date: Wed, 25 Feb 2015 11:27:58 +0000 From: Lorenzo Pieralisi To: Mark Rutland Subject: Re: [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64 Message-ID: <20150225112758.GB20214@red-moon> References: <1424827506-12245-1-git-send-email-lauraa@codeaurora.org> <20150225111828.GA9714@leverpostej> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150225111828.GA9714@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150225_032754_781963_7F5AAEC4 X-CRM114-Status: GOOD ( 15.06 ) X-Spam-Score: -0.0 (/) Cc: Will Deacon , Laura Abbott , linux-arm , Catalin Marinas X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Feb 25, 2015 at 11:18:29AM +0000, Mark Rutland wrote: [...] > > drivers/cpuidle/cpuidle-arm64.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c > > index 80704b9..f1d5422 100644 > > --- a/drivers/cpuidle/cpuidle-arm64.c > > +++ b/drivers/cpuidle/cpuidle-arm64.c > > @@ -19,6 +19,7 @@ > > #include > > > > #include > > +#include > > #include > > I wasn't able to apply this patch atop of v4.0-rc1 or current mainline; > there's no asm/suspend.h include in either of those. Which tree is this > based on? Yes, it does not apply to mainline, either we fix that up or here is the version I was sending on top of mainline. Thanks, Lorenzo -- >8 -- Subject: [PATCH] drivers: cpuidle: cpuidle-arm64: include asm/proc-fns.h explicitly ARM64 CPUidle driver requires the cpu_do_idle function so that it can be used to enter the shallowest idle state, and it is declared in asm/proc-fns.h. This patch adds the explicit inclusion of the asm/proc-fns.h header file to stop relying on implicit inclusion of the same file through implicit header files dependencies. Signed-off-by: Laura Abbott [lp: rebased/rewrote commit log] Signed-off-by: Lorenzo Pieralisi Tested-by: Mark Rutland --- drivers/cpuidle/cpuidle-arm64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c index 39a2c62..c8bb6c5 100644 --- a/drivers/cpuidle/cpuidle-arm64.c +++ b/drivers/cpuidle/cpuidle-arm64.c @@ -19,6 +19,7 @@ #include #include +#include #include "dt_idle_states.h"