From patchwork Mon Mar 9 22:17:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 5972151 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 03CA1BF6C3 for ; Mon, 9 Mar 2015 22:22:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2A6F32044C for ; Mon, 9 Mar 2015 22:22:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E2862044B for ; Mon, 9 Mar 2015 22:22:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YV610-0005SR-Nn; Mon, 09 Mar 2015 22:19:10 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YV60w-0005NF-EJ for linux-arm-kernel@lists.infradead.org; Mon, 09 Mar 2015 22:19:07 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1YV5zu-0004TR-IN; Mon, 09 Mar 2015 23:18:02 +0100 Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.84) (envelope-from ) id 1YV5zk-0000R2-K0; Mon, 09 Mar 2015 23:17:52 +0100 Date: Mon, 9 Mar 2015 23:17:52 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Paul Bolle Subject: Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver Message-ID: <20150309221752.GE7525@pengutronix.de> References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-5-git-send-email-mcoquelin.stm32@gmail.com> <20150220195437.GT19388@pengutronix.de> <1424468908.24292.10.camel@x220> <1425411786.2606.24.camel@tiscali.nl> <1425935552.4244.6.camel@x220> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1425935552.4244.6.camel@x220> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150309_151906_701469_A235E7C9 X-CRM114-Status: GOOD ( 17.99 ) X-Spam-Score: -0.0 (/) Cc: Mark Rutland , "linux-doc@vger.kernel.org" , Linus Walleij , Will Deacon , Nikolay Borisov , "linux-api@vger.kernel.org" , Jiri Slaby , Mauro Carvalho Chehab , Kees Cook , Linux-Arch , Russell King , Arnd Bergmann , Jonathan Corbet , Daniel Lezcano , Antti Palosaari , Geert Uytterhoeven , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , Philipp Zabel , Pawel Moll , Ian Campbell , Rusty Russell , Tejun Heo , Rob Herring , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Michal Marek , "linux-gpio@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Andreas =?iso-8859-1?Q?F=E4rber?= , Maxime Coquelin , Kumar Gala , Joe Perches , Andrew Morton , "David S. Miller" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, On Mon, Mar 09, 2015 at 10:12:32PM +0100, Paul Bolle wrote: > On Wed, 2015-03-04 at 13:08 +0100, Maxime Coquelin wrote: > > This is because I added also support for COMPILE_TEST coverage as per > > Uwe advice, > > and thought it was necessary to have an entry for this. > > Maybe I'm just wrong? > > I missed that you added COMPILE_TEST. > > A quick scan of your idea doesn't show any obvious issues. (Note that I > don't really know how people actually use COMPILE_TEST. I guess things > like "make allyesconfig" are involved.) Maybe this can clearify the purpose of COMPILE_TEST: diff --git a/init/Kconfig b/init/Kconfig --- a/init/Kconfig +++ b/init/Kconfig @@ -67,6 +67,26 @@ config COMPILE_TEST here. If you are a user/distributor, say N here to exclude useless drivers to be distributed. + # If you are a driver author consider to adjust your driver's + # dependencies to make it buildable with minimal preconditions if + # COMPILE_TEST is enabled. This helps contributers and maintainers + # that might not have the necessary toolchain or kernel config handy and + # also increases compile test coverage. It's your advantage if others can + # build your driver more easily! So for a device that is only found on the + # foo cpu use: + # + # depends on CPU_FOO || COMPILE_TEST + # + # . You might have to use + # + # depends on CPU_FOO || (COMPILE_TEST && COOKIE) + # + # or + # + # depends on COOKIE && (CPU_FOO || COMPILE_TEST) + # + # if your driver uses features that are only available if COOKIE is on. + config LOCALVERSION string "Local version - append to kernel release" help