From patchwork Fri May 29 13:16:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 6507571 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 87A6B9F38D for ; Fri, 29 May 2015 13:19:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A814C20654 for ; Fri, 29 May 2015 13:19:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3FC5206A0 for ; Fri, 29 May 2015 13:19:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YyK9o-0008PI-JP; Fri, 29 May 2015 13:17:04 +0000 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YyK9g-00082M-Jx for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2015 13:16:57 +0000 Received: by qkhq76 with SMTP id q76so16097396qkh.2 for ; Fri, 29 May 2015 06:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=X/NeFcv3h+yhzhtKyDej101v26Gp6VBUBvC4OGj23EE=; b=e6UNd6kG8ls4IPkCpAR3a3QQShXW82RoSxpY9cDf2ynvfu0oZEOSeJCM0pGmoJdQgH ZDIRe1a50++WufF6NEKYQbBPxn/7yfTVizVur/66rSuJ8SKRZ7G2R8CMB9+vtJFsTGQI 0rNUAQsxVOzqlU/XZJgiAKB8mzp8Faq3boCe4EDX2XH492fP4OOH6AYq1D3fokws3fVS qhzY09WtZhu7005Q69VlxRL+TaoDByejjQlky+C0k0y88t0WROrgrrfkUW/PM1xcjVcf GFoUU+czjkV/PyNKgKDOm2Ems+lEjsMA0XQzePDioiQzldx5EjtGRYNOjbkSiWrVFsEy 18lQ== X-Received: by 10.55.15.87 with SMTP id z84mr15563424qkg.57.1432905393669; Fri, 29 May 2015 06:16:33 -0700 (PDT) Received: from htj.duckdns.org (207-38-238-8.c3-0.wsd-ubr1.qens-wsd.ny.cable.rcn.com. [207.38.238.8]) by mx.google.com with ESMTPSA id j66sm2653212qgj.8.2015.05.29.06.16.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 May 2015 06:16:32 -0700 (PDT) Date: Fri, 29 May 2015 09:16:30 -0400 From: Tejun Heo To: Arnd Bergmann Subject: Re: [PATCH] cgroup: add seq_file forward declaration for struct cftype Message-ID: <20150529131630.GI27479@htj.duckdns.org> References: <8289624.GnpfIU6Era@wuerfel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8289624.GnpfIU6Era@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150529_061656_747003_904872EB X-CRM114-Status: GOOD ( 11.30 ) X-Spam-Score: 0.0 (/) Cc: cgroups@vger.kernel.org, Li Zefan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, Arnd. Applied to cgroup/for-4.2 with the declaration moved so that it's where others are. Sorry that I missed that. Thanks. ----- 8< ----- From c80ef9e0c021ff86771fdd72583c75d8f7b6a720 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Fri, 29 May 2015 10:52:59 +0200 Subject: [PATCH] cgroup: add seq_file forward declaration for struct cftype Recent header file changes for cgroup caused lots of warnings about a missing struct seq_file form declaration for every inclusion of include/linux/cgroup-defs.h. As some files are built with -Werror, this leads to build failure like: from /git/arm-soc/drivers/gpu/drm/tilcdc/tilcdc_crtc.c:18: /git/arm-soc/include/linux/cgroup-defs.h:354:25: error: 'struct seq_file' declared inside parameter list [-Werror] cc1: all warnings being treated as errors make[6]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 This patch adds the declaration, which resolves both the warnings and the drm failure. tj: Moved it where other type declarations are. Signed-off-by: Arnd Bergmann Fixes: b4a04ab7a37b ("cgroup: separate out include/linux/cgroup-defs.h") Signed-off-by: Tejun Heo --- include/linux/cgroup-defs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index 7d83d7f..26d1cea 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -26,6 +26,7 @@ struct cgroup_taskset; struct kernfs_node; struct kernfs_ops; struct kernfs_open_file; +struct seq_file; #define MAX_CGROUP_TYPE_NAMELEN 32 #define MAX_CGROUP_ROOT_NAMELEN 64