From patchwork Tue Jun 2 03:33:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 6526451 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9B9CDC0020 for ; Tue, 2 Jun 2015 03:37:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B2537204E0 for ; Tue, 2 Jun 2015 03:37:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E48720490 for ; Tue, 2 Jun 2015 03:37:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yzcyu-0002Dx-Q9; Tue, 02 Jun 2015 03:35:12 +0000 Received: from mail-pd0-f181.google.com ([209.85.192.181]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yzcyr-00013R-0M for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2015 03:35:09 +0000 Received: by pdbqa5 with SMTP id qa5so122862650pdb.0 for ; Mon, 01 Jun 2015 20:34:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=Le1M0VZOMEdgsK3tB4rql/6AsOmU6YUdRb5UQ1NHQRs=; b=C55rRs0n9Kr2XDLgaAHtX0jcBbkup8q7BLcepLYDKDOS52fe/f/hMiLjm/pUg+XZSD eoaMR5vDr0RZ3h2ern7j3rYt0OfnP9C/7OiFaXwoANLteVNhThE1AEnUZ91dSnQ8LzSR Fyi9G1gxIBFiD7eEb7K7c3rxOogfoa2QU5NXVeqi5XDD2/YhsnvkmYctmF6wuAqKaVp6 jynsxAqqCT2op9xZhKXV5qLdThK19R+idzrlxmnFcDxUe/fSnBD2N2bfqJ+muBfeayEe 81eScIxOoa7LphYggpanxa2Qq0ohTE1OyWINQ5X91YqRNOFgaz80wGnOmr2wkYDWJ1ex fbtA== X-Gm-Message-State: ALoCoQmgoG3qgQwIO9h/ZMkBgafA0VMNx2R0BEZUn6KYvbL+zo0GsPBOlDLcC8YiH58IMQFqwfJJ X-Received: by 10.66.65.162 with SMTP id y2mr46022275pas.101.1433216087787; Mon, 01 Jun 2015 20:34:47 -0700 (PDT) Received: from dragon ([104.207.83.1]) by mx.google.com with ESMTPSA id ld1sm15749319pbc.26.2015.06.01.20.34.43 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 01 Jun 2015 20:34:46 -0700 (PDT) Date: Tue, 2 Jun 2015 11:33:39 +0800 From: Shawn Guo To: Fabio Estevam Subject: Re: [GIT PULL 3/4] ARM: imx: device tree changes for 4.2 Message-ID: <20150602033337.GA7571@dragon> References: <1433145206-2508-1-git-send-email-shawn.guo@linaro.org> <1433145206-2508-3-git-send-email-shawn.guo@linaro.org> <3918834.Y7ttkc5iBm@wuerfel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150601_203509_119730_DBA57366 X-CRM114-Status: GOOD ( 19.25 ) X-Spam-Score: -1.8 (-) Cc: Stephen Rothwell , Arnd Bergmann , Daniel Lezcano , "arm@kernel.org" , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jun 01, 2015 at 01:52:53PM -0300, Fabio Estevam wrote: > > Also, could you fold this change into the patch that moves the gpt driver? > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 3c15a49fdac9..fd43dbb5e47b 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -278,7 +278,7 @@ config CLKSRC_PXA > > > > config CLKSRC_IMX_GPT > > bool "Clocksource using i.MX GPT" if COMPILE_TEST > > - depends on OF > > + depends on OF && COMMON_CLK > > select CLKSRC_MMIO > > > > config H8300_TMR16 > > > > Without this, we get build errors for COMPILE_TEST. > > Shouldn't it be like this instead? > > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -278,7 +278,7 @@ config CLKSRC_PXA > > config CLKSRC_IMX_GPT > bool "Clocksource using i.MX GPT" if COMPILE_TEST > - depends on OF > + select CLKSRC_OF if OF > select CLKSRC_MMIO I just received a message [1] from Stephen which reports the build failures on powerpc allyesconfig. Basically, the errors are around the following 3 things. 1) delay_timer 2) clk_get_sys 3) SZ_4K The 1) is an ARM specific implementation, so we need to depend on ARM. For 2), clk_get_sys() is only available with CLKDEV_LOOKUP. I can understand that Arnd's change can help fix it, as COMMON_CLK indirectly selects CLKDEV_LOOKUP. But I'm not sure how CLKSRC_OF selecting is going to help. From compile test point of view, CLKSRC_OF is not mandatory, since there is a stub clocksource_of_init() in include/linux/clocksource.h for !CONFIG_CLKSRC_OF. For 3), we need the header include/linux/sizes.h. It doesn't expose on ARM, and should be fixed by a separate patch anyway. [1] https://lkml.org/lkml/2015/6/1/328 So here is my changes to fix all the errors reported by Stephen, except 'SZ_4K' one. Let me know if it's preferred or we'd like to drop COMPILE_TEST and simply depend on ARCH_MXC. ------8<-------------- diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 139a20795073..618102e5aa2a 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -261,7 +261,7 @@ config CLKSRC_PXA config CLKSRC_IMX_GPT bool "Clocksource using i.MX GPT" if COMPILE_TEST - depends on OF + depends on ARM && CLKDEV_LOOKUP select CLKSRC_MMIO endmenu