From patchwork Fri Oct 16 11:32:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 7414231 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8DB02BEEA4 for ; Fri, 16 Oct 2015 11:34:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7BA620A40 for ; Fri, 16 Oct 2015 11:34:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD43520A3E for ; Fri, 16 Oct 2015 11:34:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zn3GB-0006EY-DF; Fri, 16 Oct 2015 11:33:19 +0000 Received: from mail-wi0-f172.google.com ([209.85.212.172]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zn3G8-000681-9R for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2015 11:33:17 +0000 Received: by wijp11 with SMTP id p11so5900328wij.0 for ; Fri, 16 Oct 2015 04:32:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=BubUkppwgzcs33w3FBnfFHTSKffcicPThjzcGwDwyH0=; b=lwzMMft9ZoylWe4/E5dlYxZpeevchC//Az3JKlmNPwFhQClY0gFRlrlsz5KsWOF1qZ QlWhp7iJDPeqG1lAWxQd8zcX6FWQzfFC9u1+zQc8DLmpHGSZccqaWS6Svi6chz5PWv8d ED4R+ghn8d8i6gW+ifvrBLvo+VtAdIZW2J3Zc5IntghYykAT29gvi7C/1PulE/t9TUpD p+2+iO1a7H3uYm/MpWQkd90HjclEQJz9+2baTqaoUlrm21Hh2w4DpGk9Jzf1eettru0u DhVeks3A33P9xQDdZsihFNKpFuiCyphQIIpR+XOD0Fh61soOfFxKgNTOApMUGADex/Ta xvMQ== X-Gm-Message-State: ALoCoQlnCAobQt+V4cmaATjJEOLFBE0pfheLqrkJjcR4xm36swyT2AbTQWtyZuFuYowJqsG3EWxe X-Received: by 10.194.242.167 with SMTP id wr7mr16462203wjc.27.1444995174315; Fri, 16 Oct 2015 04:32:54 -0700 (PDT) Received: from x1 (host81-129-170-218.range81-129.btcentralplus.com. [81.129.170.218]) by smtp.gmail.com with ESMTPSA id lb10sm22018142wjc.9.2015.10.16.04.32.53 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 16 Oct 2015 04:32:53 -0700 (PDT) Date: Fri, 16 Oct 2015 12:32:51 +0100 From: Lee Jones To: kbuild test robot Subject: [PATCH] mailbox: Fix a couple of trivial static checker issues Message-ID: <20151016113251.GF31804@x1> References: <1444980091-16728-5-git-send-email-lee.jones@linaro.org> <201510161646.D4m1dK6L%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201510161646.D4m1dK6L%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151016_043316_489258_9BAF7C05 X-CRM114-Status: GOOD ( 14.19 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, kernel@stlinux.com, jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, kbuild-all@01.org, linux-arm-kernel@lists.infradead.org, maxime.coquelin@st.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_WEB, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mailbox: Fix a couple of trivial static checker issues This patch deals with a few spelling, white space and type warnings reported by Intel's Kbuild Test Robot. Reported-by: kbuild test robot Signed-off-by: Lee Jones --- drivers/mailbox/mailbox-sti.c | 2 +- drivers/mailbox/mailbox-test.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c index f11d4e8..4835817 100644 --- a/drivers/mailbox/mailbox-sti.c +++ b/drivers/mailbox/mailbox-sti.c @@ -64,7 +64,7 @@ struct sti_mbox_device { }; /** - * STi Mailbox platform specfic configuration + * STi Mailbox platform specific configuration * * @num_inst: Maximum number of instances in one HW Mailbox * @num_chan: Maximum number of channel per instance diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index cac1ba2..196144c 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -22,7 +22,7 @@ #define MBOX_MAX_SIG_LEN 8 #define MBOX_MAX_MSG_LEN 128 #define MBOX_BYTES_PER_LINE 16 -#define MBOX_HEXDUMP_LINE_LEN ((MBOX_BYTES_PER_LINE * 4) + 2) +#define MBOX_HEXDUMP_LINE_LEN ((MBOX_BYTES_PER_LINE * 4) + 2) #define MBOX_HEXDUMP_MAX_LEN (MBOX_HEXDUMP_LINE_LEN * \ (MBOX_MAX_MSG_LEN / MBOX_BYTES_PER_LINE)) @@ -30,7 +30,7 @@ static struct dentry *root_debugfs_dir; struct mbox_test_device { struct device *dev; - void __iomem *mmio; + void *mmio; struct mbox_chan *tx_channel; struct mbox_chan *rx_channel; char *rx_buffer; @@ -53,7 +53,7 @@ static ssize_t mbox_test_signal_write(struct file *filp, if (count > MBOX_MAX_SIG_LEN) { dev_err(tdev->dev, - "Signal length %d greater than max allowed %d\n", + "Signal length %lu greater than max allowed %d\n", count, MBOX_MAX_SIG_LEN); return -EINVAL; } @@ -92,7 +92,7 @@ static ssize_t mbox_test_message_write(struct file *filp, if (count > MBOX_MAX_MSG_LEN) { dev_err(tdev->dev, - "Message length %d greater than max allowed %d\n", + "Message length %lu greater than max allowed %d\n", count, MBOX_MAX_MSG_LEN); return -EINVAL; } @@ -303,7 +303,7 @@ static int mbox_test_probe(struct platform_device *pdev) tdev->tx_channel = mbox_test_request_channel(pdev, "tx"); tdev->rx_channel = mbox_test_request_channel(pdev, "rx"); - if (!tdev->tx_channel && !tdev->tx_channel) + if (!tdev->tx_channel && !tdev->rx_channel) return -EPROBE_DEFER; tdev->dev = &pdev->dev;