| Message ID | 20151022195208.GB24439@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 22-10-15, 22:52, Dan Carpenter wrote: > The "domain" variable needs to be signed for the error handling to work. > > Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c > index 2c3b16f..de5e89b 100644 > --- a/drivers/cpufreq/scpi-cpufreq.c > +++ b/drivers/cpufreq/scpi-cpufreq.c > @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops; > > static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev) > { > - u8 domain = topology_physical_package_id(cpu_dev->id); > + int domain = topology_physical_package_id(cpu_dev->id); > > if (domain < 0) > return ERR_PTR(-EINVAL); Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 22/10/15 20:52, Dan Carpenter wrote: > The "domain" variable needs to be signed for the error handling to > work. > > Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface > driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Thanks for the fix Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Hi Rafael, On Fri, Oct 23, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 22/10/15 20:52, Dan Carpenter wrote: >> >> The "domain" variable needs to be signed for the error handling to >> work. >> >> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface >> driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> > > Thanks for the fix > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Can you pick this up for your next -rc fixes ? Regards, Sudeep
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index 2c3b16f..de5e89b 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops; static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev) { - u8 domain = topology_physical_package_id(cpu_dev->id); + int domain = topology_physical_package_id(cpu_dev->id); if (domain < 0) return ERR_PTR(-EINVAL);
The "domain" variable needs to be signed for the error handling to work. Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>