From patchwork Wed Nov 11 20:38:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 7597831 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AEB7A9F392 for ; Wed, 11 Nov 2015 20:40:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A768B2066E for ; Wed, 11 Nov 2015 20:40:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56FF620667 for ; Wed, 11 Nov 2015 20:40:41 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZwcAM-0005Is-QM; Wed, 11 Nov 2015 20:38:50 +0000 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZwcAI-0004vT-EE; Wed, 11 Nov 2015 20:38:47 +0000 Received: by pasz6 with SMTP id z6so42045589pas.2; Wed, 11 Nov 2015 12:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=2SJznsxzMp3XOiP+LsSNoYg29rXxDCFSybmDrZUUXBE=; b=xWRqc8BQcjFfIutbl0FJm/UFkUAh2maorooy5EdF+Ef0wI8yWxT76PSOZKVR+SvK0A wVsUdd6Rw3sl8wFpJysNSnD2z6QvvIdYrcRCRRIJ0NweoiR5VFW8Ufocf8hxpr7vC150 IM1PytvovZn0BeJOtM/w0/7LLbZx8GHpS6ooR6l+fuHm/qLDSOJ66nnGk0/1kpwPn1RE dSLWgUSLjSWRxGuoImUMvA7B3/BtzEl2OuZ7HL+neP/xwXamI5t2UNsrlN6LZIU4zcYO Y8Ecmt6GEJIg7zoV1EEPyq1Qk7ztX1wAS44Csm+HqpBLwUZnnZ6QGZkWCdy7m8bjLvkZ Jx7A== X-Received: by 10.66.66.166 with SMTP id g6mr17028074pat.152.1447274305750; Wed, 11 Nov 2015 12:38:25 -0800 (PST) Received: from google.com ([2620:0:1000:1301:b5e8:66ef:5e80:54ae]) by smtp.gmail.com with ESMTPSA id yg2sm10881719pbb.79.2015.11.11.12.38.24 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 11 Nov 2015 12:38:25 -0800 (PST) Date: Wed, 11 Nov 2015 12:38:23 -0800 From: Brian Norris To: Bayi Cheng Subject: Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller Message-ID: <20151111203823.GJ12143@google.com> References: <1446824889-16144-1-git-send-email-bayi.cheng@mediatek.com> <1446824889-16144-2-git-send-email-bayi.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1446824889-16144-2-git-send-email-bayi.cheng@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151111_123846_593609_99A96ABB X-CRM114-Status: GOOD ( 20.13 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Pawel Moll , Ian Campbell , Sascha Hauer , linux-kernel@vger.kernel.org, Daniel Kurtz , jteki@openedev.com, Rob Herring , linux-mediatek@lists.infradead.org, ezequiel@vanguardiasur.com.ar, Kumar Gala , Matthias Brugger , linux-mtd@lists.infradead.org, David Woodhouse , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Nov 06, 2015 at 11:48:07PM +0800, Bayi Cheng wrote: > Add device tree binding documentation for serial flash with > Mediatek serial flash controller > > Signed-off-by: Bayi Cheng > --- Applied to l2-mtd.git/next (for 4.5). This will show up in linux-next.git after the merge window. Also squashed in a small diff (below), to fix up some language issues and to refer the reader to the jedec,spi-nor.txt document. > .../devicetree/bindings/mtd/mtk-quadspi.txt | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > new file mode 100644 > index 0000000..866b492 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt > @@ -0,0 +1,41 @@ > +* MTD SPI nor driver for MTK MT81xx (and similar) serial flash controller The DT binding document shouldn't be talking about software (i.e., shouldn't be talking about "drivers"). > + > +Required properties: > +- compatible: should be "mediatek,mt8173-nor"; > +- reg: physical base address and length of the controller's register > +- clocks: the phandle of the clock needed by the nor controller > +- clock-names: the name of the clocks > + the clocks needed "spi" and "sf". "spi" is used for spi bus, > + and "sf" is used for controller, these are the clocks witch > + hardware needs to enabling nor flash and nor flash controller. > + See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > +- #address-cells: should be <1> > +- #size-cells: should be <0> > + > +The SPI Flash must be a child of the nor_flash node and must have a > +compatible property. > + > +Required properties: > +- compatible: May include a device-specific string consisting of the manufacturer > + and name of the chip. Must also include "jedec,spi-nor" for any > + SPI NOR flash that can be identified by the JEDEC READ ID opcode (0x9F). > +- reg : Chip-Select number > + > +Example: > + > +nor_flash: spi@1100d000 { > + compatible = "mediatek,mt8173-nor"; > + reg = <0 0x1100d000 0 0xe0>; > + clocks = <&pericfg CLK_PERI_SPI>, > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > + clock-names = "spi", "sf"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + }; > +}; > + diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt index 866b492c38d2..fb314f09861b 100644 --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt @@ -1,19 +1,19 @@ -* MTD SPI nor driver for MTK MT81xx (and similar) serial flash controller +* Serial NOR flash controller for MTK MT81xx (and similar) Required properties: - compatible: should be "mediatek,mt8173-nor"; - reg: physical base address and length of the controller's register -- clocks: the phandle of the clock needed by the nor controller -- clock-names: the name of the clocks - the clocks needed "spi" and "sf". "spi" is used for spi bus, +- clocks: the phandle of the clocks needed by the nor controller +- clock-names: the names of the clocks + the clocks should be named "spi" and "sf". "spi" is used for spi bus, and "sf" is used for controller, these are the clocks witch hardware needs to enabling nor flash and nor flash controller. See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. - #address-cells: should be <1> - #size-cells: should be <0> -The SPI Flash must be a child of the nor_flash node and must have a -compatible property. +The SPI flash must be a child of the nor_flash node and must have a +compatible property. Also see jedec,spi-nor.txt. Required properties: - compatible: May include a device-specific string consisting of the manufacturer