From patchwork Wed Nov 18 03:17:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 7644411 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8DF04BF90C for ; Wed, 18 Nov 2015 03:22:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 949C52046F for ; Wed, 18 Nov 2015 03:22:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91F6020458 for ; Wed, 18 Nov 2015 03:22:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZytIp-0005Jv-CZ; Wed, 18 Nov 2015 03:20:59 +0000 Received: from mail-bl2on0105.outbound.protection.outlook.com ([65.55.169.105] helo=na01-bl2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZytIk-0005AY-W8 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2015 03:20:56 +0000 Received: from BLUPR03CA006.namprd03.prod.outlook.com (10.255.124.23) by DM2PR0301MB1232.namprd03.prod.outlook.com (10.160.219.21) with Microsoft SMTP Server (TLS) id 15.1.325.17; Wed, 18 Nov 2015 03:20:32 +0000 Received: from BN1AFFO11FD005.protection.gbl (10.255.124.4) by BLUPR03CA006.outlook.office365.com (10.255.124.23) with Microsoft SMTP Server (TLS) id 15.1.325.17 via Frontend Transport; Wed, 18 Nov 2015 03:20:32 +0000 Authentication-Results: spf=permerror (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Received-SPF: PermError (protection.outlook.com: domain of freescale.com used an invalid SPF mechanism) Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD005.mail.protection.outlook.com (10.58.52.65) with Microsoft SMTP Server (TLS) id 15.1.325.5 via Frontend Transport; Wed, 18 Nov 2015 03:20:32 +0000 Received: from shlinux2 (shlinux2.ap.freescale.net [10.192.224.44]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id tAI3KSZX003289; Tue, 17 Nov 2015 20:20:29 -0700 Date: Wed, 18 Nov 2015 11:17:50 +0800 From: Peter Chen To: Arnd Bergmann Subject: Re: [PATCH] USB: USB_OTG does not depend on PM Message-ID: <20151118031748.GA4228@shlinux2> References: <7521777.8ZmnT3AlIC@wuerfel> <874mgkjoh2.fsf@saruman.tx.rr.com> <5647698.81XCu85L5D@wuerfel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5647698.81XCu85L5D@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD005; 1:0okCRxanIP8/JiRwEmuWes2KLffKSV3gIMgRPP4DAZTC0VdRvLvbWlUgcp0pT7Frq6C7vNpOwsPSDHYW9gL3dMSkJoE3tP3Sir8fJ4Vze5MRqgw593BD1IUAfJ73LHriG3OUbxC9SKRLHPJ4Fhebrq8wYD4ZZS3tdznDWaWsf7I7F8QyzdOFvZhbFMjij4pq7fyxAleQCuJqgzfBPqLynW9rnqG8LDrq16RfECy1Myb0Y1iK1nagAn4hZ3cRKHynEm+SbwexEqv1UNzaZWODkOnz88DIvha9HlFTNrsyO6FmLRTkAZ6P+wpAfYkH6L5Bh9xhpn3CYApv9yF5vp0w1RKsEtojEn4d0MckGvFHXkAlsvi+xtTzqFRBVbOfUZ3Zs21egEaG+gmkpAjxLCJ/JpwaE3tN+G9EL8qevxTRD2U= X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(1060300003)(2980300002)(448002)(24454002)(189002)(199003)(23433003)(97756001)(83506001)(92566002)(11100500001)(86362001)(46406003)(87936001)(85326001)(106466001)(33716001)(19580405001)(110436001)(50986999)(5007970100001)(76176999)(54356999)(19580395003)(4001350100001)(50466002)(81156007)(33656002)(5001920100001)(23726002)(97736004)(5001960100002)(110136002)(104016004)(5008740100001)(606003)(77096005)(6806005)(2950100001)(4290100001)(47776003); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0301MB1232; H:tx30smr01.am.freescale.net; FPR:; SPF:PermError; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1232; 2:9LdQIJMK22LIUQo4VopwGUiUSwOtQ4khMFya6Lw0dplnzsiKoKOgejPdaGVD3ZXOWX4RjxGBRPIUIo6r7V6flPczDMKUm3vYW2CRfxdSZl+WtsLPK87jnKU7uRECuywzyPvJHiNEUhwwqyvzElqAt3Jt6xKnF+OynMywN7yMM1s=; 3:2u6dsHnfbb/AtKXktTe1dm3sULJLYh786HsKgU2igGb9aB7T0qdXuNwekKO9eA1Q79dqqiUekvke3YXBFvHL6nnbImhjXBNaJUE5hOgi3BN12XKSE3wOr8Kt4m/yFqd0ThPVhxnBUR6jDkdd/UV7fexrugBDpAmyeDTtDGGoxJqGeVr/chEeRTBSnv25mP3aQF151JVq8l9MaZnMOb7IpkNi+nJBLi05KatuDRykIaM=; 25:JrqzGI2+Mcp+YG3x3YPkuHVV6RApSTi3bSLIyoDgAmftoQ1YSJFRjoNT1iszFCViOMVRPeU26HUWtDocjCUUprSRYuulek1+pH7pzXFrg8CpPYoQDXVv/JlZycUC2USrflhgS3nRzZ5tIWyaIwSWVIuvcR+OoMUqEnQeQRlnJqPt6VioB9yq57uI9Mep63iV3VCFbn+dL0awqMlOPDO2p+2qGLHjDTKg6jbQzagOqGV+3V92S+uL4mZknFAuvGlz2wrR3FAyNeGFTRYLCKg7Ew== X-Microsoft-Antispam: UriScan:;BCL:1;PCL:0;RULEID:;SRVR:DM2PR0301MB1232; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1232; 20:gMwnk9lWCilw5oVnmy+GwjlnC3EZVNj28bWlGMauoa8PDZ8mO2r+AJFx+ZV+pT2cKkJEsxJTugiOXcVcSe6vPARe47Vbg9vEBv8SLT0RBKaBuEO8ug4GmW6dNXgMLxyjeti38ar+pEzDfxbRIrG0nnXMD20EKyulYmWMrjFsS76JMHJoPeliko1wmpzwUxS/JnRa5/8UvA2HoYAIzqGl/UoWvMlmzqUy/oKhetozfTDNSP8sB4OO381qdcC1A5L5GA6aKWCb3/ddXxk1+9tUfw6efaEtPVqmoestN8+DdF9udq7mN8dy8lgUHxvq9apMyJN6UZtwFyTOE50DvyTEOOzHtmaHD/IPDUk2lOsKdqg=; 4:fUg0flBbDXoZCpNcqFMhUNJI5xYLYT59u5L9y23sYDxYcUao+hpeHMISkA12Vn3Ej79pRNEzq7946a9QShF//168r1vqeO7vyqS9i3MWzm687HVLuifeUOj7ft1HGHQ30dwVL/1rwWl9TkJchLXxktq+2lHfMo+6hkOTpJ3iITRghUd3B6q0X/BEbCI9DCSbLszBDbJa9BZAknK62l6x3w/rI8NhVK5El7mbSksdRLaMcpuk2qNvmhdOqQPqj2nsUO4rTgG6GmfiiHhIsRCgit9NSohbz4mnjxMxxXumBmZnne/RMwqF0LyEUDre5je8PF81rmKU9Mnu6p45nSauNkTMWs/++G3oGzv4+Y5ydRc+lhZRcIK3pqwD8sWkDrIF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:1; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:DM2PR0301MB1232; BCL:1; PCL:0; RULEID:; SRVR:DM2PR0301MB1232; X-Forefront-PRVS: 0764C4A8CD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR0301MB1232; 23:67p6jySi5cGkmwvr6D6rODnEG238IKaraqP1OeC?= =?us-ascii?Q?KXhyGlLErxamzqOOZQkaXBM+gZDq3gg38v0XgYVSScGxl+PYDUXonZZF/4Yi?= =?us-ascii?Q?3pLLYi+8cORuERgQ78dAbeJFnTQgFAgWdqvGTYh+02vW0qxK+Ul2KuFm6UhP?= =?us-ascii?Q?oEPrjMLSD1sLjkt6297VDkOIwC7MUkbB1W7NcAx93zwcxkbqot4Axk3yBxCt?= =?us-ascii?Q?LKLmu3+gJN7o4wL1tXCsGxYLcsf9gAY62uaL19DW4yF/ktXbTSh2iWDdKhbG?= =?us-ascii?Q?CsTcOA1prLzmdTW8UsGrjuE9hNf8LvcxRqH6tZdFZh2as3mCBOUTaydacnw8?= =?us-ascii?Q?FCdy/qcF7K+3rbqao30whuzhVJgBqNXYubYTGxY6UoAMYSlEzZAfRFRZo7iq?= =?us-ascii?Q?6IxKf5Fkrng+ytf73I2Wpcp6Uv0vx9yKKKyjmgr0y8kHwj8OTSZB+4m7jal6?= =?us-ascii?Q?vKaaCcpQJc4m801R/a5LcfSR8/N+G8Xpciebz/naj9xo83jcgKoghp6qWCxl?= =?us-ascii?Q?wlCFM2R/RRYGFfWEnPAukd7f0vN4EcUv0IRZz10xwcf0YGK4QStsvq1CE391?= =?us-ascii?Q?3nHQjwA/tHPr9ZfNzTeyYr0qdL4o5ez99iBiDm3dMLtTjpDSkPcssH5jo3bm?= =?us-ascii?Q?PK80SmEMizzUnIi9flaaugXoLtfvOrm7MmuCG+Sx/dFiF3X/KENPdwQwhTpR?= =?us-ascii?Q?YiM7WI4WMYippdIMtj+rx2Hzsu9iU9/RKF7E/+pKSyoprP7fw0n6/+SThTfy?= =?us-ascii?Q?sUV26ogytb6mrzo+X+g19vSv5b1aE4iLNlGSH0Asa3BY8cVNRDcIL8TWVLCL?= =?us-ascii?Q?CECPFNDgySQdouBXlo7krZSVxCJLp7Dj1i0kYVM4yJHZ9oMMiTC+aEusul3F?= =?us-ascii?Q?5o1C6gn+uF5Kr+Wbf9KCiKWs8yfigLFuJRQFIsEzrwoXexMydrCBooqFRAK0?= =?us-ascii?Q?k/b4bkGwJd3rmrzHUBeWn/4OhjDRHFv70TYweGtMr5BbNdqbBuB8b9LpOB2q?= =?us-ascii?Q?7ihldxM3eNldktBFK66O6AyFXoF6IO8Yeq+myyanacZEiClkxtHFk9LpFdfJ?= =?us-ascii?Q?xZZ+sgLho1RV08qs5fUo1xGNvBAKWkyRXOMwRryvfLpKVlMwKlXN49TPlnRE?= =?us-ascii?Q?XQSr0eNIpNiU7agrT2otrrxPlymujUcEE?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB1232; 5:GdWh8aTL0rJOFrRjnlgbfWBGX2RGKzBIQJKnrMpk9LmgV5wndTpBt4LLFo6qjX0Z34zNqcD2lLtucCBHZ9PZr6jbVDijO/BIbTU3NSS+kH7H5P0H5frpVB1qeC4O+Z/3Dl1tbl3u5TJ/YWWzCz1LdQ==; 24:bcRezXQkSAO9EW7wPJ6DpTfpZwOtDUvwu135AhuqJZNL5jYmis7+Ub8ukCxF8DfJzLXd9Y9adPinLIcMMbgo2hTzaKmoxOqwC0qsI4WsuAI=; 20:cfbB7acixe8GwZp73tf/s/3Hb/SIG5MAdNOu3zdjdqlj0DVlDBSwDXHCjB1f/YRN8H1ARUZWIUQgjrlgl0DOhg== SpamDiagnosticOutput: 1:5 SpamDiagnosticMetadata: 00000000%2D0000%2D0000%2D0000%2D000000000000 SpamDiagnosticMetadata: 1 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2015 03:20:32.2096 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1232 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151117_192055_287153_45259733 X-CRM114-Status: GOOD ( 28.20 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Nov 17, 2015 at 11:00:18PM +0100, Arnd Bergmann wrote: > On Tuesday 17 November 2015 15:38:33 Felipe Balbi wrote: > > > > Arnd Bergmann writes: > > > USB_OTG initially depended on USB_SUSPEND, which was later turned into > > > PM_RUNTIME and finally into PM. I don't know at what point the dependency > > > became unnecessary but it appears to work fine without CONFIG_PM now. > > > > > > However, we get lots of warnings in randconfig kernels like: > > > > > > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM) > > > > > > whenever CONFIG_PM is disabled and something else selects USB_OTG. > > > Let's just drop the dependency to avoid the warnings. > > > > > > Signed-off-by: Arnd Bergmann > > > --- > > > I keep seeing this one in my ARM randconfig test > > > > and how did you test this ? Did you make sure you're not breaking HNP ? > > For HNP to happen we depend on a bus_suspend and bus_suspend is only > > available on CONFIG_PM, unless that has changed. > > > > Seems like you've only compile tested this patch, is that correct ? > > Yes, I compile-tested only and inspected the code briefly without finding > anything that contradicted this. It seems I missed the important part > as you say, so we should instead add 'depends on PM' for the other > symbols. > > Arnd Hi Arnd, would you kindly try if below patch can fix your problem From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001 From: Peter Chen Date: Wed, 18 Nov 2015 11:06:34 +0800 Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG When choose randconfig for kernel build, it reports below warning: "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)" In fact, USB_OTG is visual symbol and depends on PM, so the driver needs to depend on it to reduce dependency problem. Signed-off-by: Peter Chen Reported-by: Arnd Bergmann Cc: Felipe Balbi Acked-by: Arnd Bergmann --- drivers/usb/core/Kconfig | 3 +-- drivers/usb/phy/Kconfig | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig index a99c89e..dd28010 100644 --- a/drivers/usb/core/Kconfig +++ b/drivers/usb/core/Kconfig @@ -77,8 +77,7 @@ config USB_OTG_BLACKLIST_HUB config USB_OTG_FSM tristate "USB 2.0 OTG FSM implementation" - depends on USB - select USB_OTG + depends on USB && USB_OTG select USB_PHY help Implements OTG Finite State Machine as specified in On-The-Go diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 1731324..22e8ecb 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -21,7 +21,6 @@ config AB8500_USB config FSL_USB2_OTG bool "Freescale USB OTG Transceiver Driver" depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM - select USB_OTG select USB_PHY help Enable this to support Freescale USB OTG transceiver. @@ -168,8 +167,7 @@ config USB_QCOM_8X16_PHY config USB_MV_OTG tristate "Marvell USB OTG support" - depends on USB_EHCI_MV && USB_MV_UDC && PM - select USB_OTG + depends on USB_EHCI_MV && USB_MV_UDC && PM && USB_OTG select USB_PHY help Say Y here if you want to build Marvell USB OTG transciever