From patchwork Wed Nov 18 20:36:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 7652561 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 22B99BF90C for ; Wed, 18 Nov 2015 20:38:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5279B204A7 for ; Wed, 18 Nov 2015 20:38:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74BC020483 for ; Wed, 18 Nov 2015 20:38:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zz9TX-0004IW-MH; Wed, 18 Nov 2015 20:37:07 +0000 Received: from mail-bn1on0054.outbound.protection.outlook.com ([157.56.110.54] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zz9TU-00048Y-6W for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2015 20:37:05 +0000 Received: from DM2PR07MB622.namprd07.prod.outlook.com (10.141.177.146) by DM2PR07MB367.namprd07.prod.outlook.com (10.141.102.22) with Microsoft SMTP Server (TLS) id 15.1.325.17; Wed, 18 Nov 2015 20:36:42 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Received: from localhost (95.143.213.120) by DM2PR07MB622.namprd07.prod.outlook.com (10.141.177.146) with Microsoft SMTP Server (TLS) id 15.1.325.17; Wed, 18 Nov 2015 20:36:40 +0000 Date: Wed, 18 Nov 2015 23:36:20 +0300 From: Yury Norov To: Arnd Bergmann Subject: Re: [PATCH v6 16/19] aarch64: ilp32: use generic stat64 structure Message-ID: <20151118203620.GC11264@yury-N73SV> References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com> <1447795019-30176-17-git-send-email-ynorov@caviumnetworks.com> <4020528.IPMzSqapue@wuerfel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4020528.IPMzSqapue@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.120] X-ClientProxiedBy: HE1PR06CA0068.eurprd06.prod.outlook.com (25.164.28.164) To DM2PR07MB622.namprd07.prod.outlook.com (10.141.177.146) X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB622; 2:aSgGrdt6jRSzuAFF4J+4BFaQV/3NBgSUc1L4rk3CLeiX6BXNEDnIbmYvy8zrv0GCqAUCJ/FPLCQWs6R9doihFQd47zt4XFNKMkbBhYQW9c7koDPQxS7A+6YgYcbr5/vp8V3Mkk5D5O76A9hv6e1SW9yqdNLVYRReQ887dFv2Jh4=; 3:MPj22x1ymxnRDwzcS+TAuckK83eP5A54wBLtaG/hGAHDrImpCHLx28BKnTQ8Fu/QqFukJ8sP3+HDU4ADGSeEt4vN65GueR5ENuixslAkkLxY9bt3qVmVlQ9szSumyBG1s1cLxFc53rzj/gKPEx3Gdw==; 25:LpOC/XcOLojxqHJqjs6gCJgzL5ytBfZdngjZH3nAucb0HZnYRV7L2tkS6TUfTdQIL+q5gGt8JlOc+a3mHbD87/CK6iFqEWsKersq9WL7/OGQyWyzv8Tizf4vwMlH4/ZFQCRbvZbSkDYVgx73cPJuAXYCzai76QOBwog0PDIzMUe0QTXHIslouvkBrVtXeJwPYC4kiaiYeyDSCY+Ws9t8h/8Fu71htcfhcuGgGdb6/kPiwgQxvDWdudpNuvIJMy6LGflXuWCyZ94K/BhBfsV9Vw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB622; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB622; 20:7NMcfo0ve2pj5bJyZKObNGz58WAYbfag9CDCHpA4YJYElvbgVxXy9PZH87v7n9O8q4B48veGUAVKIYguTO1UNdpJ8IHfMb9K4gSUe6NY4asynDkoh33siPIaqSuVsLheD7bQOaqSTe6yVGmwgze7/3ROe6K+ZkfsFsRqBnd3eDnceIG7Fz1oDFGQV+Dsr5UqPWcud8WrmvdlTBCFbBpFRGgp+igXnQlrHlxTo4QrDX9zOnNuN49pbzxD5I/zWBWNBAT3KrQDwAcXHQtAeRe8d8Troy+fCpPb2Bbxccx4JZQbKeCssrzsuJXYtFK8buUDLZIbDznMnvirnNlMeHbjjJLfrThzgQYd/3sf5XWUygLTOnR2uTh6kRwEXVVgNWcRYSJq9mWK8AbbF1O+XS1r+8PjFguRhyzX62vGr5a8GVHaw2u3OZA29BEYX8fNANVKTw9vObYy+sgaUU/1hrKius4RFwWcQXse5wMtyzxtiHe17mB1yzSW8kvAqQTOyXgKt7hKrrjEYjByLWQc6DBplE65iZkk1cp5L6/Ad65VF81Ib8nAFgFwUC+OFmHP9Wylxq5uMrY6mxmpnkxLB7b9hSoolvLC72Uq6alEclALDOc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:DM2PR07MB622; BCL:0; PCL:0; RULEID:; SRVR:DM2PR07MB622; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB622; 4:4F3ywNOTUU/++1EvQ2HLoT99e4a+jzdivQbDa3xnSHQxJaxgHMC/zY9XwIz8SC42Lhk77qsw5QSSOXJvXMCI7vaWmEiPQ4TFEr+0uJDHYc7A4uk/OY63E8X5b795vTs1BTO5i/oz/VmDKcmdmfYz98eNSyktEoj17t2UrzDfBtwKfKGcPXch6eHGdIQQoZ4u7nGNF0kMvpsJX8r7Jxn3Ng2s6aeo2xTEDbeglZaewstzrdrkmM55S7WassriV/++Ce9xoXvXnLgkVvAbgkbJwKSEL9uOtdMwA3M3k2rJoSDB3ujzXW0tu6T/LDeH1OvMJT6IAemw89ok8UrzKUVpMqSwVNMOHImu5vTMZCEkOXVXqeeiny95SZFsDYy1rzRe X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6069001)(24454002)(189002)(199003)(5001960100002)(189998001)(92566002)(4001350100001)(122386002)(50466002)(81156007)(5001920100001)(97736004)(33716001)(110136002)(586003)(23726002)(46406003)(5008740100001)(33656002)(101416001)(76176999)(54356999)(50986999)(42186005)(76506005)(97756001)(77096005)(5007970100001)(5004730100002)(40100003)(2950100001)(47776003)(66066001)(83506001)(106356001)(87976001)(105586002)(6116002)(3846002)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR07MB622; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR07MB622; 23:8JrDuHeJYXoXc4GehWENWQEj0M9itvzyEix562939u?= =?us-ascii?Q?QwfKQ/nG++9KOI6TFVF+SVpT8OUC/Vsvpas8fhZ4r3pS9ncnXObNl4aoHwrL?= =?us-ascii?Q?vHrepvA+MhCTvnSdli3kvO8Gi3KRLz70RC+JlffzJfVUwUfOw8McRkJqqb4j?= =?us-ascii?Q?2JXn4+wKex/F27cNXeTcni862+EHJ/FRYMrMrAmODMiqcdCxJjQS0Bl71Pey?= =?us-ascii?Q?AgQDJE07rVD5eYK4LmbcZUVHVJAf5HMNAh+GHYHd1EART8+bJkDrX+Nf5sH+?= =?us-ascii?Q?JXc8DV69Zb/1kwlnDzuJ0lz8/xKXuU64eXNJzamcnKyUdk/nIwhapWcUGnr1?= =?us-ascii?Q?ajRDgaG5Ubn/C9n43wCWo4jCYJ/hXuShoewJ6g9tGENHnK/oM07jaZPu88nH?= =?us-ascii?Q?bQw77U+tb0c1cwA0TSNuVRURX0hzOQ1JzP/bPoQB1CpbJoq4/XSevQKbhkdl?= =?us-ascii?Q?ff2R7RzFAbpqT1SXY8ROXAjVOEKZSU8kWMQEtYyEHFlU0Yc3ClwOo4qnzCHp?= =?us-ascii?Q?4ckrV7PGPn8TUI1K7aESqv5YRgK4ZLbqPZY6RAICNLlB9IV/UNMuP2VkmWn0?= =?us-ascii?Q?kSeGRZUeSMS3AiHtzTLmlqfBIPCXXG4i5aiDQiwAMVXFXk7Z8YkbXBAT1f1j?= =?us-ascii?Q?wRjQSM73KfRBiJ4WATDbae5KZL7YXwlXGKD1ojTKQeCpKD1pLekOiXRut+JG?= =?us-ascii?Q?95lqS/ElFazA65SafV8xNDszMDc6EroS8CjuLy7pKPc1XIdwSTYklBCspg5/?= =?us-ascii?Q?+uCMK/OZHUAwc84M6MqJ0mUxj/2GVJO6phKmw6OqE4cf/zL5LkOu9Dxt3y8i?= =?us-ascii?Q?YlPa9plr1PTf4JiHKxt0fnTvnlpTpscCZAo7xoUC6lx98MR4ZNGNvfuCHD0n?= =?us-ascii?Q?myL9A8QN3HLiXR7R4HRfKJjwK2jSEpRKenP8Y6iUcCIRnnAdBc+F+DSXtwUD?= =?us-ascii?Q?91VbUjzcggkGsUZAEqgPR8LMFh/fs3dpNNcmbMDal/UaXzZ0GR555Dfrvpvn?= =?us-ascii?Q?DGz90dPBWJSOFamEPxQOM3kOcJJS7/Zb1SgjIvjNbtZ99pv40tenW0mwLMS0?= =?us-ascii?Q?oyeLnGc0AnnIt75qLZJbOfnWlNZ7DnS+uq3ptWZgVXfL6yBaYhz8vtiO4+Gv?= =?us-ascii?Q?uwnn5en64=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB622; 5:gv3toyXx440PzbmJ20ZPMZTiAxQxkgHotlOstU1ih/DtemN981fGbGC4ZEDuzKP3QObw8tGP2sEuKsz1Y5kO90r9SDGkuMOQAM0nTFyR5A2H/jBWofvhfq1EWmxJy66z/2BAT8ZaKTIg7b1HY7BtMg==; 24:O46ivjDTA+lSzDzzey86bfQESCYdEVNpMPg7TCPMwjmz5GetI/+ICOrCX/WVe0BMwjNsS0ufNAdeuYHbF5YrFSRwLUdJ9Q3iMQ7DfHQ/KGE=; 20:47eW0irQ5noyCheyZAGoo0nZPnlxqwhw9s/C9v75wKpUbgH1YzEDWR5UPaxJADFra5goagPkv4Fd1BnZCsgvtw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2015 20:36:40.3235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB622 X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB367; 2:UPrTGCCfx1NwNXYZ88nmZSwxM8whZW5uvcMuwgi38EjhQOk7FgybKQshRr/4yZ9X7W1Q8cGkqcs8/tMcYywaALRgCcOjpy1XnA9haVCpAOQ4mk8dfRbqxKpnUOISVzL7ZpIL6p1ZRtQx3Ju4S9Jbxe8NxyD82NnSYjADmTCbBag=; 23:O8lewpor+rf/eX7Bns+aBIZhuZksnSEi3LvrjAKFK9oBRwXKJ+hF85le4fgLAszwYYir8psP65wps44sl8dTIM7PXqmRRpxdYH7cfoqd66S97RdPgJde7uymTwuPmFoj6LcSzDup79dAhXzOTzybAKtLlFVBQLLxbpYVCMg3qpsJP6Ya9dKGR8RHF3tVRhWV X-OriginatorOrg: caviumnetworks.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151118_123704_508295_404A6E28 X-CRM114-Status: GOOD ( 13.81 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, catalin.marinas@arm.com, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, joseph@codesourcery.com, ddaney.cavm@gmail.com, schwab@suse.de, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, andrey.konovalov@linaro.org, linux-arm-kernel@lists.infradead.org, christoph.muellner@theobroma-systems.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Nov 17, 2015 at 11:09:05PM +0100, Arnd Bergmann wrote: > On Wednesday 18 November 2015 00:16:56 Yury Norov wrote: > > Generic 32-bit and AARCH32 stat64 structures has same names. > > ILP32 needs generic stat64. So we can either make ILP32 mutual > > exclusive with AARCH32, or duplicate generic cp_new_stat64 code > > and struct stat64 to sys_ilp32.c. We choose second because it's > > more flexible to have independend support for ABIs. > > > > I commented on the previous version, but you have not replied to that, > or changed anything. > > Arnd Hi Arnd, It seems I misunderstood you. Are you OK if we'll enable __ARCH_WANT_COMPAT_STAT64 for ILP32, as for AARCH32_EL0, and turn glibc to use struct stat from sysdeps/unix/sysv/linux/bits/stat.h with this calls? It seems, this is how ARM ABI works. Yury. --- arch/arm64/include/asm/stat.h | 2 -- arch/arm64/include/asm/unistd.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/include/asm/stat.h b/arch/arm64/include/asm/stat.h index af04276..15e3559 100644 --- a/arch/arm64/include/asm/stat.h +++ b/arch/arm64/include/asm/stat.h @@ -22,7 +22,6 @@ #include -#ifdef CONFIG_AARCH32_EL0 /* * struct stat64 is needed for compat tasks only. Its definition is different * from the generic struct stat64. @@ -60,4 +59,3 @@ struct stat64 { #endif #endif -#endif diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h index 696e638..3b196f3 100644 --- a/arch/arm64/include/asm/unistd.h +++ b/arch/arm64/include/asm/unistd.h @@ -19,7 +19,6 @@ #endif #ifdef CONFIG_AARCH32_EL0 #define __ARCH_WANT_COMPAT_SYS_GETDENTS64 -#define __ARCH_WANT_COMPAT_STAT64 #define __ARCH_WANT_SYS_GETHOSTNAME #define __ARCH_WANT_SYS_PAUSE #define __ARCH_WANT_SYS_GETPGRP @@ -42,6 +41,7 @@ #define __NR_compat_sigreturn 119 #define __NR_compat_rt_sigreturn 173 +#define __ARCH_WANT_COMPAT_STAT64 #define __ARCH_WANT_SYS_LLSEEK /*