| Message ID | 20151207152521.GA137768@lkp-hsx03 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
--- a/drivers/mtd/spi-nor/atmel-quadspi.c +++ b/drivers/mtd/spi-nor/atmel-quadspi.c @@ -757,7 +757,7 @@ static int atmel_qspi_probe(struct platf aq->mem = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(aq->mem)) { dev_err(&pdev->dev, "missing AHB memory\n"); - err = PTR_ERR(aq->regs); + err = PTR_ERR(aq->mem); goto exit; } aq->phys_addr = (dma_addr_t)res->start;
drivers/mtd/spi-nor/atmel-quadspi.c:758:5-11: inconsistent IS_ERR and PTR_ERR on line 760. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Cyrille Pitchen <cyrille.pitchen@atmel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- Please take the patch only if it's a positive warning. Thanks! atmel-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)