From patchwork Tue Jan 5 00:35:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 7952151 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C9AE69F1CC for ; Tue, 5 Jan 2016 00:37:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E5E6E20340 for ; Tue, 5 Jan 2016 00:37:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A6F202EC for ; Tue, 5 Jan 2016 00:37:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aGFbZ-0003IC-Fu; Tue, 05 Jan 2016 00:36:05 +0000 Received: from mail.linuxfoundation.org ([140.211.169.12]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aGFbX-0003Gp-EH for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2016 00:36:04 +0000 Received: from localhost (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DCBD11299; Tue, 5 Jan 2016 00:35:41 +0000 (UTC) Date: Mon, 4 Jan 2016 16:35:28 -0800 From: Andrew Morton To: Mark Brown Subject: Re: Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()" Message-Id: <20160104163528.be56a4b1.akpm@linux-foundation.org> In-Reply-To: <20160104235512.GW16023@sirena.org.uk> References: <20160104224233.GU16023@sirena.org.uk> <20160104150946.373ed02b8e8b81221340b7c8@linux-foundation.org> <20160104235512.GW16023@sirena.org.uk> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160104_163603_528058_F5307835 X-CRM114-Status: GOOD ( 16.84 ) X-Spam-Score: -4.2 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Stephen Rothwell , Tony Luck , Russell King , kernel-build-reports@lists.linaro.org, Mel Gorman , Tyler.Baker@linaro.org, Dave Hansen , Kevin.Hilman@linaro.org, linux-next@vger.kernel.org, Kamezawa Hiroyuki , Xishi Qiu , Taku Izumi , Matt Fleming Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 4 Jan 2016 23:55:12 +0000 Mark Brown wrote: > On Mon, Jan 04, 2016 at 03:09:46PM -0800, Andrew Morton wrote: > > On Mon, 4 Jan 2016 22:42:33 +0000 Mark Brown wrote: > > > > platforms in the kernelci.org boot tests[1]. Doing bisections with > > > Arndale and BeagleBone Black identifies 904769ac82ebf (mm/page_alloc.c: > > > calculate zone_start_pfn at zone_spanned_pages_in_node()) from the akpm > > > tree as the first broken commit[2,3]. An example bootlog from the > > > failure is: > > > Thanks. That patch has rather a blooper if > > CONFIG_HAVE_MEMBLOCK_NODE_MAP=n. Is that the case in your testing? > > Seems to be what's making a difference from a quick run through, yes. OK, thanks. Stephen, can we please retain mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node.patch mm-introduce-kernelcore=mirror-option.patch mm-introduce-kernelcore=mirror-option-fix.patch mm-introduce-kernelcore=mirror-option-fix-2.patch and add the below? Or don't bother - I'll do an mmotm tomorrow with these in it. I'd still like reviewing and testing from Taku Izumi please. From: Arnd Bergmann Subject: mm/page_alloc.c: set a zone_start_pfn value in zone_spanned_pages_in_node We got a new build warning in linux-next: mm/page_alloc.c: In function 'free_area_init_node': mm/page_alloc.c:5278:25: warning: 'zone_start_pfn' may be used uninitialized in this function [-Wmaybe-uninitialized] zone->zone_start_pfn = zone_start_pfn; mm/page_alloc.c:5265:17: note: 'zone_start_pfn' was declared here unsigned long zone_start_pfn, zone_end_pfn; The code indeed looks wrong, but this is just a guess of what the fix might be: I have not looked it in detail, so please treat this as a bug report. Signed-off-by: Arnd Bergmann Cc: Taku Izumi Cc: Tony Luck Signed-off-by: Andrew Morton --- mm/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN mm/page_alloc.c~mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node-fix mm/page_alloc.c --- a/mm/page_alloc.c~mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node-fix +++ a/mm/page_alloc.c @@ -5013,6 +5013,8 @@ static inline unsigned long __meminit zo unsigned long *zone_end_pfn, unsigned long *zones_size) { + *zone_start_pfn = node_start_pfn; + *zone_end_pfn = node_end_pfn; return zones_size[zone_type]; }