From patchwork Mon Jan 11 18:55:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 8008371 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 65D25BEEE5 for ; Mon, 11 Jan 2016 18:57:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B7C8202E9 for ; Mon, 11 Jan 2016 18:57:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5E0320295 for ; Mon, 11 Jan 2016 18:57:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIhcm-00046R-Oc; Mon, 11 Jan 2016 18:55:28 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIhcj-0003M2-7P for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2016 18:55:25 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6B42482D6; Mon, 11 Jan 2016 18:55:37 +0000 (UTC) Date: Mon, 11 Jan 2016 10:55:00 -0800 From: Tony Lindgren To: Guenter Roeck Subject: Re: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' Message-ID: <20160111185459.GZ12777@atomide.com> References: <5693EB8A.40802@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5693EB8A.40802@roeck-us.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160111_105525_426098_34F6ADA7 X-CRM114-Status: GOOD ( 14.06 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King , Tomeu Vizoso , Kevin Hilman , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD,UNPARSEABLE_RELAY,WEIRD_PORT autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Guenter Roeck [160111 09:51]: > Hi, > > I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points > to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain"). > Failures are silent - there is no output on the console. > Affected tests are > > arm:beagle:multi_v7_defconfig:omap3-beagle > arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm > arm:overo:multi_v7_defconfig:omap3-overo-tobi > arm:beagle:omap2plus_defconfig:omap3-beagle > arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm > arm:overo:omap2plus_defconfig:omap3-overo-tobi > > For details please see the 'next' column at http://server.roeck-us.net:8010/builders. > > Reverting the offending commit fixes the problems. > > Please let me know if there is anything I can do to help tracking down the problem. The following fixes the booting, but I wonder if it's a proper fix? Tested-by: Guenter Roeck --- a/drivers/base/power/common.c +++ b/drivers/base/power/common.c @@ -145,9 +145,10 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd) { if (dev->pm_domain == pd) return; - - WARN(device_is_bound(dev), - "PM domains can only be changed for unbound devices\n"); + if (device_is_registered(dev)) { + WARN(device_is_bound(dev), + "PM domains can only be changed for unbound devices\n"); + } dev->pm_domain = pd; device_pm_check_callbacks(dev); }