From patchwork Tue Apr 19 15:05:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 8881121 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 18E2B9F36E for ; Tue, 19 Apr 2016 15:07:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B4AB2026D for ; Tue, 19 Apr 2016 15:07:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675D02026C for ; Tue, 19 Apr 2016 15:07:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1asXEN-0004S5-11; Tue, 19 Apr 2016 15:06:23 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1asXEJ-0004OQ-Rv for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2016 15:06:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC66328; Tue, 19 Apr 2016 08:04:42 -0700 (PDT) Received: from red-moon (red-moon.cambridge.arm.com [10.1.203.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EB4B3F222; Tue, 19 Apr 2016 08:05:58 -0700 (PDT) Date: Tue, 19 Apr 2016 16:05:55 +0100 From: Lorenzo Pieralisi To: Jisheng Zhang Subject: Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle Message-ID: <20160419150555.GB15458@red-moon> References: <1458657329-2484-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1458657329-2484-1-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160419_080619_922978_B9EAE06E X-CRM114-Status: GOOD ( 12.67 ) X-Spam-Score: -7.9 (-------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jisheng, On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote: > psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after > booting, so mark them as __init. > > Signed-off-by: Jisheng Zhang > --- I've slightly changed the $SUBJECT, patch below FYI. Lorenzo -- >8 -- Subject: [PATCH] drivers: firmware: psci: mark idle init functions __init psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after booting, so mark them as __init. Signed-off-by: Jisheng Zhang [lpieralisi: updated patch subject] Signed-off-by: Lorenzo Pieralisi --- drivers/firmware/psci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c index 6d86881..4a6a7de 100644 --- a/drivers/firmware/psci.c +++ b/drivers/firmware/psci.c @@ -250,7 +250,7 @@ static int __init psci_features(u32 psci_func_id) #ifdef CONFIG_CPU_IDLE static DEFINE_PER_CPU_READ_MOSTLY(u32 *, psci_power_state); -static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) +static int __init psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) { int i, ret, count = 0; u32 *psci_states; @@ -310,7 +310,7 @@ free_mem: return ret; } -int psci_cpu_init_idle(unsigned int cpu) +int __init psci_cpu_init_idle(unsigned int cpu) { struct device_node *cpu_node; int ret;