From patchwork Mon May 2 13:47:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 8992421 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EAAB99F39D for ; Mon, 2 May 2016 13:50:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1D29B201FE for ; Mon, 2 May 2016 13:50:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5248F20122 for ; Mon, 2 May 2016 13:50:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1axEDT-0001v8-99; Mon, 02 May 2016 13:48:51 +0000 Received: from mail-bl2on0088.outbound.protection.outlook.com ([65.55.169.88] helo=na01-bl2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1axEDQ-0001l5-LB for linux-arm-kernel@lists.infradead.org; Mon, 02 May 2016 13:48:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-caviumnetworks-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Lei/bUbNQSdY0g/0ocwxcYeEsXxEEA7uIMJ0yJJ+C4w=; b=rMFBcCEVqHAqre4/dJHIRzvE1R6mcdA4f0T8wFSocYJLG/0pLv7wYKXim6YtItxF51E25TeWlZGo/gZEHP6QlyDormWR0Ohrdk0bSJ7UScquJKOMnU8aJyiJirmIm+9a7R3y0EmxO52I5wkcpZ+ooT3h8zdzmkf3wtRC+DzEGho= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none; arm.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost (95.143.213.121) by CY1PR07MB2230.namprd07.prod.outlook.com (10.164.112.144) with Microsoft SMTP Server (TLS) id 15.1.485.9; Mon, 2 May 2016 13:47:23 +0000 Date: Mon, 2 May 2016 16:47:06 +0300 From: Yury Norov To: Andre Przywara , Arnd Bergmann Subject: [question] pread2, pwrite2 unistd symbols for compat Message-ID: <20160502134706.GA11396@yury-N73SV> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: HE1PR03CA0038.eurprd03.prod.outlook.com (10.163.170.176) To CY1PR07MB2230.namprd07.prod.outlook.com (10.164.112.144) X-MS-Office365-Filtering-Correlation-Id: 17140bd3-d749-4545-d8dd-08d372904abb X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2230; 2:Bn41PsuKfOqt4eAcJC4t6WXpRusuO9ezj9UYEREx2Y1bOGlmDuqTCsUZNyzfiJLmfjo4DUMHx+vWOSGjYKDYEMErvFklZUdDKOTUHJtWbIOlAB/pIwP304ZfvWzSALWVCFlRE1+bMTxePEqiBlpQFm7h4a+/3fdFFuplvhpCh6K9iU8vxXm+EG4vap4M6bpk; 3:jvSeJGmss//vhuLVz6j0aoii9SgcbwLq8VTiC5h/obq+KdHRNmUfIB0F6LIA2uHwNAsyWi1Ajcn+/MWhVctvrdSJE7GH6JoHPvtNJcrd7ErR/gOdajvCZAcDHivoRuIs; 25:Yjrgk/4TwPA8TTIajII5+Snz/CPPD5MQEbM40+St/De/LqJEX7vdit/lLpwvTThcoDoGVH0bQ2TO2LHy+JTQ5mWL7e+GNDizxsJjAfkfM/Zp6BeXk90blsNVebloqdSb9jcNAUMYH0GcSnO0MY8gZa2NTAQh8g+RcTiRKQAekdkMNomwoEyKVBwiW07WZFZ9kaIrg74CWwLlh3J6lRUsy0GDZRRPLBTFi2XmAyWvW1+FEj9nqOxFXpEu//peL6fE6Isv2rLM44Jhc/zata9lxNN9eStZvsfOGYebBiuy9Hp//YP1KuAZtQxxZ+pLXFf6IYRySr9NeQHr/h3y1uIWTkFCC/uxf/TtciAwOUgG/6rb1gyPCK+wkIC/Sai/Tw0r9HD1wDfK+AIFTzDAXv42T5SaPKLJ9hiiQSAerEcuPmkmwqitU7H0lWn3bwsjrqOr X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2230; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2230; 20:OFTb7gLavxOQmPBdkejff0EZtqUYTutPQwSUSdLlW6RZ3Bfxf6Hn4RJFoUiD8kA2qPoZz7SGmkeC+pOOUr32th6NIVjZNq7fNUVbtBp0e8U7S0XGbYeFscqqU9rOTzUxJHr0GbAR9Tqkbqaz1ypHXl4P4qKaNRm8T0BoqK/2nI3c97lsvGtBlLQxGIIipFnfRHh6F2AnhGbm3BWf+xOAg4DIws0h/sPz/ee9mBrYNFA1TGy/8H/Nbz+G/U0/NPfa31nYlZ1ajpzV+wjbL1YVcV5yMoKTvEePmiDY3prL3fwbxjTf2yc1j0uYy0l9iczuVDz0PK20N/NX++YcglKcHqaWG6Fd3cqD/5wtJmpg0T48PAjK+0/C7sF9F5eTkVi4diEgAk0hdkgwR4vpbLycTWpAhSbJRpXtyAjoEAqdce8ECGayNWCx3+uj4c83ZRzfboWCfqxmOYbKYQ4ceXNPXdYIe8zjyrQ2Kr5swrlC0d84ld3DMb3UzqZxdcGtmwCB2z8b4npa4/btxkf+beDIu6rDcMnM6QgKyAA3QwZejLTU+nEy2enl19pUWW5KO5bkHB+uKMXmHRV01lGXNI45XWHFpQuyUr4M13hFiR6FhVo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(9101521094)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:CY1PR07MB2230; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2230; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2230; 4:DRUp9BXjJApA0fqIrNbYhjdT0OCiLxhJt/Rl+utNT4SGNhTy8PKIptmimVUzMBsDhHhVU8Zb+LrKTXJONIpiayx/qsArr0PojSPtWcoAnzx6b/mBDD7TbrPYkxzdGh/VwAemCLjuq8No86ziWwVS4Ev6EGK3wymFnvE7KgJ5heKW/emuF0FCUovPVbFuPOvwMfVJ92hLwzk2iRrz3zK1O5Vc+xtdrm2w5vhhYE3550JwmD5lidUzHAs+LD+grBOvN0zBF+pDQEXuwSiGdiuF2wqEHxTjq4GJqbcINEnl4s03nXId9PquhJjB8iYp+ZWi0dwcNGPQ+307zS5JjEMc/ctZeZk4vBdiFYFTzDZhUNOR9QUm4Eg7XWzdqXvINVBtOOg7HaM/fpNtmylFBm1vwQ== X-Forefront-PRVS: 0930AAFAD9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(81166005)(50466002)(83506001)(92566002)(5008740100001)(97756001)(189998001)(42186005)(2906002)(50986999)(76506005)(77096005)(54356999)(66066001)(46406003)(229853001)(1096002)(3846002)(4001350100001)(586003)(23726003)(5004730100002)(33656002)(6116002)(1076002)(9686002)(33716001)(4326007)(5001770100001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2230; H:localhost; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2230; 23:+ki21kXAWnJhqd9JwwEbl+imvhJGEK2NqD8t70srYCckPvbtdXz14ViI15WEpBG3Ofi7fyWV+FhVIxM+ZMu4j8aVqkd31xrPODRLACujIVVG3KsBHxtx3agDShe3xrpFkOsXrjNrtmyFrHcrtefJRGlPfdGynVTOEHGh6OPv5ml3M4XGSrnpze6bxA7QXgkw00gPtziWBZBICd4QiDsQI+Uc38qXoApag392tLIvgmGG0RsuXi2KFDT43WjtolnDaCOc5po+fOkb5SdYH1dI4haCfDcH6KPrvQTeyPGPSXbIWwcl3TjWmZ02eZbOLuVn2HCrj3NG+eler1XL5JdsYRBy3SFQA8XTuuKum5brhmsJUsWijoiuR3PKL9NwMe8btTawO5sASvuNwVXWpqshtQjZFWLth24xT3l5LiFAaKgn8VwuB7Hv4yIYerq75A1PtsSKhKBw8n/MQhTpV3VykWBHAIaWiFTpHY3vLlKc4vNwLHjOduVmGoTUxY+ByujRbO6WJ6S089jrX1gNbHPUX3c3yV6epZan1tocN4TssUc62tSGJClGrqEUQxaMM3cQNK3jPHQlfMhRav7wgs12kRhzHTkHMcVVjWfEfG36EJJT1dHaXW0RUpMyyVCwZQNl64IuTIkkmPqn5Q5F0cim7abAHVxr9mCeuRUE6ydHiz5sUgBke0xwejxsF0HJIT5FndOYL9izYsb90pnljWwf930bWszWiZszGSrWxSyX1HCzeB1Fn5hIWOnaKIpdrYUYDlGqUFIx6xFfRp0sTJMy3d36rFJQ5w/3Wsu9QtXncSdABjmipe4XNbOIo+OANiY29Imb0tIlIAQqfL0WL8B+dMoFEjKZENjgrVGTeQ+heOQoBM2OWyWKGeeJuRigzw5mOT/mW1uvGS54cEgg5jWkQA== X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2230; 5:q76UIG+BlKyI8fh86iqv1a+k2RmNqw9t3Rzvd76e09Umskl+ri1ObwHc5S1OCNEYMPeXLz/60smNspKxDhaetEGra4b5h7NRgoChSxjM7MNJmd2ihHrBNj8EL3ZLVqFl6PWh0lWIpbBAKEmYGay64w==; 24:3bmsMYjn8ArEkaohryuF2NZlPJz+HYu/WYUdgzH8C4Lz69Dvl43C+ckNt2jmM9+5NglL2PT9HblmMrQeEW1p470VSa3nELk5qWh5GureOsw=; 7:IZpsXm/rjOIqaYAe4+8b8aFmuXbuZ3lNeka+402ip1kquMS36pVkQ7CZoLkNcMfBgGroM5wxncGNQzvTMl1zA3GK4vHiia3UW3nMmnv51o6ZLtSe7LuZXZdDawWu9rhzPT4c6AD3A4qbbHpvKZ28TwordcE8lzkr5szwa2TFLvaYOMfp26Qd9i4LbGXSLLTd SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2016 13:47:23.8584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2230 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160502_064848_958955_CCC90887 X-CRM114-Status: UNSURE ( 4.08 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Andre, In patch 987aedb5d (eneric syscalls: wire up preadv2 and pwritev2 syscalls) you add those syscalls with __SYSCALL macro. However, compat architectures that does not use generic unistd (mips, s390), declare compat version in their syscall tables. Maybe we'd replace __SYSCALL macro with __SC_COMP? Yury. diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h index 723479c..6ed4613 100644 --- a/include/uapi/asm-generic/unistd.h +++ b/include/uapi/asm-generic/unistd.h @@ -721,9 +721,9 @@ __SC_WRAP(__NR_mlock2, sys_mlock2) #define __NR_copy_file_range 285 __SC_WRAP(__NR_copy_file_range, sys_copy_file_range) #define __NR_preadv2 286 -__SYSCALL(__NR_preadv2, sys_preadv2) +__SC_COMP(__NR_preadv2, sys_preadv2, compat_sys_preadv2) #define __NR_pwritev2 287 -__SYSCALL(__NR_pwritev2, sys_pwritev2) +__SC_COMP(__NR_pwritev2, sys_pwritev2, compat_sys_pwritev2) #undef __NR_syscalls #define __NR_syscalls 288